Record Autoplay Attempts UKM for iframes |
||
Issue descriptionAt the moment, Blink UKM goes trough the Document and forbids iframes recording. We have a UKM in Blink for autoplay attempts and we would like them for iframes. What was done for other UKMs in this case is to record them on the main frame but add a boolean mentioning that it was coming from an iframe. WatchTime UKM is a good example of this. Finding a generic solution for this might be good as we will want other UKMs in Blink following the same pattern :)
,
May 23 2018
LGTM by privacy
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa commit f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa Author: Becca Hughes <beccahughes@chromium.org> Date: Wed May 23 19:24:39 2018 UKM: Record DocumentCreated event Record a DocumentCreated event that contains the navigation source ID and whether the document is the main frame. This allows subframe UKM events to be linked to the top frame origin. BUG= 824081 Change-Id: I4efc9c86db0de124f02309dae324cfce3a3f6f6c Reviewed-on: https://chromium-review.googlesource.com/975184 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561199} [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/components/ukm/content/BUILD.gn [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/components/ukm/content/DEPS [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/components/ukm/content/source_url_recorder.cc [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/components/ukm/content/source_url_recorder_browsertest.cc [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/third_party/blink/public/BUILD.gn [add] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/third_party/blink/public/platform/ukm.mojom [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/f45c9fdb168bfe16fcf5ba079d1eb1a46b5102fa/tools/metrics/ukm/ukm.xml
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c4715c6ba139bb46dff26ad0451786b58a3160b commit 8c4715c6ba139bb46dff26ad0451786b58a3160b Author: Becca Hughes <beccahughes@chromium.org> Date: Wed May 23 20:43:20 2018 Autoplay: Record Autoplay UKM event on subframe Disable the main frame check so that autoplay attempt UKM events are recorded on subframes. These events will not be keyed to any URL but can be attributed to the top frame by joining the data with the DocumentCreated events. BUG= 824081 Change-Id: I9565e58dd23eec7c5f2b51af52a64df34f8d2e6e Reviewed-on: https://chromium-review.googlesource.com/1065581 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#561243} [add] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/chrome/browser/media/autoplay_metrics_browsertest.cc [modify] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/chrome/test/BUILD.gn [modify] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/8c4715c6ba139bb46dff26ad0451786b58a3160b/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
,
May 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by beccahughes@chromium.org
, Mar 21 2018