New issue
Advanced search Search tips

Issue 824068 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in cc::ScopedRasterFlags::DecodeRecordShader

Project Member Reported by ClusterFuzz, Mar 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6482078443765760

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  cc::ScopedRasterFlags::DecodeRecordShader
  cc::ScopedRasterFlags::ScopedRasterFlags
  cc::PaintOpBuffer::Playback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544613:544615

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6482078443765760

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 21 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 21 2018

Labels: Test-Predator-Auto-Owner
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/0c568dc759c39d7598cfd811f7f2096daebc26c0 (cc: Support animated images in PaintFilters.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb0d82a43ed2cfac6da93278b631d603eb072c55

commit fb0d82a43ed2cfac6da93278b631d603eb072c55
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Mar 22 02:01:42 2018

cc: Fix flags access in ScopedRasterFlags.

If an image fails to decode on a shader, abort early instead of trying
to decode the flags further. Since Flags() returns nullptr based on
whether the decode failed, it was causing crashes.

R=enne@chromium.org

Bug:  824068 , 824058 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1040598df19c94a10a71a5b494f196abfffee2ab
Reviewed-on: https://chromium-review.googlesource.com/974480
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544945}
[modify] https://crrev.com/fb0d82a43ed2cfac6da93278b631d603eb072c55/cc/paint/scoped_raster_flags.cc
[modify] https://crrev.com/fb0d82a43ed2cfac6da93278b631d603eb072c55/cc/paint/scoped_raster_flags.h

Project Member

Comment 4 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544942:544945.

Detailed report: https://clusterfuzz.com/testcase?key=6482078443765760

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  cc::ScopedRasterFlags::DecodeRecordShader
  cc::ScopedRasterFlags::ScopedRasterFlags
  cc::PaintOpBuffer::Playback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544613:544615
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=544942:544945

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6482078443765760

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6482078443765760 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment