Issue metadata
Sign in to add a comment
|
Regression: Black patch is observed on a page after resizing the window
Reported by
khushal....@etouch.net,
Mar 21 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3377.0 (Official Build) Revision: d77b019f5aa49e13a58521f3b1e3604bd391be53-refs/heads/master@{#544610} (32/64-bit) OS: Win (7, 8, 8.1, 10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and try to resize the window. Actual Result: Black patch is observed on resizing the window. Expected Result: Black patch should not be observed on resizing. This is a regression issue, broken in M-67 series, and will soon update other info. Good Build: 67.0.3375.0 Bad Build: 67.0.3377.0
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca55b814e692b9d6e53919a0764eb392f917239 commit 0ca55b814e692b9d6e53919a0764eb392f917239 Author: yiyix <yiyix@chromium.org> Date: Thu Mar 22 20:21:30 2018 Fix regression: fix the unwanted black screen during resize In DrawOcclusion, I made the assumption that the |quad_layer_rect| represents the union of the |rect| of DrawQuads in this SharedQuadState. With this assumption, I can use |quad_layer_rect| to occlude DrawQuads behind it. However this assumption was not well documented, so that some code was written after the draw occlusion algorithm did not follow it, ex: Gutter is using the size of the surfaceDrawQuad as |quad_layer_rect| and the actual |rect| size is very small. Bug:824037, 824035 , 824043 , 824054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4cc02559926c02a3a769050250f1753c37f65307 Reviewed-on: https://chromium-review.googlesource.com/975821 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#545215} [modify] https://crrev.com/0ca55b814e692b9d6e53919a0764eb392f917239/components/viz/common/quads/shared_quad_state.h [modify] https://crrev.com/0ca55b814e692b9d6e53919a0764eb392f917239/components/viz/service/display/surface_aggregator.cc [modify] https://crrev.com/0ca55b814e692b9d6e53919a0764eb392f917239/components/viz/service/display/surface_aggregator.h [modify] https://crrev.com/0ca55b814e692b9d6e53919a0764eb392f917239/components/viz/service/display/surface_aggregator_unittest.cc
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca9f07fb96e763bda3246f74b2b2419e530d9b68 commit ca9f07fb96e763bda3246f74b2b2419e530d9b68 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Mar 22 21:55:27 2018 Revert "Fix regression: fix the unwanted black screen during resize" This reverts commit 0ca55b814e692b9d6e53919a0764eb392f917239. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 545215 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBjYTU1YjgxNGU2OTJiOWQ2ZTUzOTE5YTA3NjRlYjM5MmY5MTcyMzkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20%28dbg%29/64167 Sample Failed Step: compile Original change's description: > Fix regression: fix the unwanted black screen during resize > > In DrawOcclusion, I made the assumption that the |quad_layer_rect| > represents the union of the |rect| of DrawQuads in this SharedQuadState. > With this assumption, I can use |quad_layer_rect| to occlude DrawQuads > behind it. However this assumption was not well documented, so that > some code was written after the draw occlusion algorithm did not > follow it, ex: Gutter is using the size of the surfaceDrawQuad as > |quad_layer_rect| and the actual |rect| size is very small. > > Bug:824037, 824035 , 824043 , 824054 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I4cc02559926c02a3a769050250f1753c37f65307 > Reviewed-on: https://chromium-review.googlesource.com/975821 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Yi Xu <yiyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545215} Change-Id: I08dad32c0661f7b9cf7151a00689b7b949ea92d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824037 , 824035 , 824043 , 824054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/976702 Cr-Commit-Position: refs/heads/master@{#545266} [modify] https://crrev.com/ca9f07fb96e763bda3246f74b2b2419e530d9b68/components/viz/common/quads/shared_quad_state.h [modify] https://crrev.com/ca9f07fb96e763bda3246f74b2b2419e530d9b68/components/viz/service/display/surface_aggregator.cc [modify] https://crrev.com/ca9f07fb96e763bda3246f74b2b2419e530d9b68/components/viz/service/display/surface_aggregator.h [modify] https://crrev.com/ca9f07fb96e763bda3246f74b2b2419e530d9b68/components/viz/service/display/surface_aggregator_unittest.cc
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0a2c99d57e900e1d57870911e62c22d9031571b commit a0a2c99d57e900e1d57870911e62c22d9031571b Author: yiyix <yiyix@chromium.org> Date: Fri Mar 23 00:36:23 2018 RELAND Fix regression: fix the unwanted black screen during resize In DrawOcclusion, I made the assumption that the |quad_layer_rect| represents the union of the |rect| of DrawQuads in this SharedQuadState. With this assumption, I can use |quad_layer_rect| to occlude DrawQuads behind it. However this assumption was not well documented, so that some code was written after the draw occlusion algorithm did not follow it, ex: Gutter is using the size of the surfaceDrawQuad as |quad_layer_rect| and the actual |rect| size is very small. TBR=fsamuel@chromium.org Bug: 824037 , 824035 , 824043 , 824054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ifb7cd120c0e42b0484d6765c4e617041e4d6a2db Reviewed-on: https://chromium-review.googlesource.com/976696 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#545308} [modify] https://crrev.com/a0a2c99d57e900e1d57870911e62c22d9031571b/components/viz/common/quads/shared_quad_state.h [modify] https://crrev.com/a0a2c99d57e900e1d57870911e62c22d9031571b/components/viz/service/display/surface_aggregator.cc [modify] https://crrev.com/a0a2c99d57e900e1d57870911e62c22d9031571b/components/viz/service/display/surface_aggregator.h [modify] https://crrev.com/a0a2c99d57e900e1d57870911e62c22d9031571b/components/viz/service/display/surface_aggregator_unittest.cc
,
Mar 26 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khushal....@etouch.net
, Mar 21 2018Owner: yiyix@chromium.org
Status: Assigned (was: Unconfirmed)