Regression:Theme doesn't appear on complete page after removing any thumbnail.
Reported by
vku...@etouch.net,
Mar 21 2018
|
|||||||||
Issue descriptionChrome Version:66.0.3359.45 (Official Build)Revision d10b5708865b34223d2014b60e8cdad9648ecc49-refs/branch-heads/3359@{#357} (32/64-bit) OS:Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux (14.04 LTS) OS. What steps will reproduce the problem? (1)Launch chrome and install theme 'Eiffel tower' from https://chrome.google.com/webstore/detail/ppbaibkigenhdcommebegmmmpoolmpip?hl=en (2)Open NTP and click on close icon of thumbnail, scroll down the page and observe Actual: Theme doesn't appear on complete page after removing any thumbnail. Expected: Theme should be applied on complete page even if any thumbnail is removed. This is a regression issue broken in 'M65' and below is the manual regression range Good Build: 65.0.3287.0 (Revision:522297) Bad Build: 65.0.3288.0 (Revision:522666) Note: Issue is seen on latest Dev #67.0.3371.0 & latest canary 67.0.3377.0
,
Mar 21 2018
I'm confused by the regression range. #0 says it regressed between 522297:522666, and #1 says it regressed between 543290:543291. I tried locally and can also reproduce on 543290. Unable to bisect earlier than 542521 because NTP is in different style which doesn't allow scrolling. Trying to create a reduced test case.
,
Mar 21 2018
vkupte@ can you confirm the chrome revision that you used to capture Expected_Theme.mp4? Did you see the same for the "good result" when you bisected to 522297:522666 and 543290:543291?
,
Mar 22 2018
With respect to comment # 2 & 3: wangxianzhu@: Sorry for the confusion created by regression range,video of Expected_Theme.mp4 was taken from chrome version 65.0.3287.0. Rechecked and bisected again and below is the per-revision info You are probably looking for a change made after 522427 (known good), but no later than 522428 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/034134229bfcfe39482304614c615b826979d822..773623d293ed991e20596c4cb00e58610af5f395 Suspect: https://chromium.googlesource.com/chromium/src/+/773623d293ed991e20596c4cb00e58610af5f395 @treib: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Mar 22 2018
Hm, that CL changed the <body>'s "display:" from the default (apparently "inline") to "block". I guess that had unintended side effects. That CL only affects the local NTP though. If this happens on the remote NTP too, then the culprit there must be something else. Kristi, as the new owner for all NTP-theme things, can you take this?
,
Mar 22 2018
,
Mar 27 2018
,
Mar 28 2018
,
Mar 28 2018
,
Mar 28 2018
https://critique.corp.google.com/190806987 fixes remote NTP and should roll out in a few days. Since it's server side, this will fix the current stable release of M65. Local NTP is only affected in M67.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a535b4aadd9d3371a2e4fa42455646f18b2feffd commit a535b4aadd9d3371a2e4fa42455646f18b2feffd Author: kristipark <kristipark@chromium.org> Date: Wed Mar 28 23:25:43 2018 [Local NTP] Fix body height not expanding beyond window height Setting body height=100% causes the height to only include the height of the window. If there is any content beyond the window height, the background will be cut off. Bug: 824040 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia47aa0dc8047ebc634e0c8f170f22fe9b2b39249 Reviewed-on: https://chromium-review.googlesource.com/984777 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546651} [modify] https://crrev.com/a535b4aadd9d3371a2e4fa42455646f18b2feffd/chrome/browser/resources/local_ntp/local_ntp.css
,
Mar 29 2018
,
Mar 29 2018
c12: The local NTP fix has been pushed to Canary, which is reached using chrome-search://local-ntp/local-ntp.html. The remote NTP is served by GWS, so the fix should roll out sometime next week.
,
Mar 29 2018
,
Apr 3 2018
With respect to comment #13: Rechecked above issue on latest dev build 67.0.3386.1 and latest canary 67.0.3387.0,issue is still reproducible on remote NTP But fixed using chrome-search://local-ntp/local-ntp.html Please refer attached screencast
,
Apr 3 2018
Apologies for the delay. The GWS server push is still in progress and is expected to finish later today or tomorrow.
,
Apr 4 2018
,
Apr 5 2018
The GWS server push has finished, and remote NTP should now be verifiable on all versions. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vku...@etouch.net
, Mar 21 2018Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)