New issue
Advanced search Search tips

Issue 824031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 771643



Sign in to add a comment

Regression: Text is not seen on print preview.

Reported by aiman.an...@etouch.net, Mar 21 2018

Issue description

Chrome Version: 67.0.3377.0 (Official Build) Revisiond77b019f5aa49e13a58521f3b1e3604bd391be53-refs/heads/master@{#544610} (32/64 Bit).
 	
OS: Win(7,8,8.1,10) and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://welcome and give print command.
2. Observe Print Preview..

Actual Result: Text is not seen on print preview.

Expected Result: Text should be seen on print preview.

This is a regression issue, broken in M-67 series, and will soon update other info

Good Build:67.0.3376.1
Bad Build:67.0.3377.0
 
Actual Result.mp4
696 KB View Download
Expected Result.mp4
451 KB View Download
Cc: wangxianzhu@chromium.org
Bisected to https://chromium.googlesource.com/chromium/src/+log/0629986b..4caa9288 (Please double check) Maybe r544561?
Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67 OS-Mac
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 series, Using the per-revision bisect providing the bisect results,

Good Build:67.0.3376.1(Revision:544069)
Bad Build:67.0.3377.0(Revision:544610)

You are probably looking for a change made after 544560 (known good), but no later than 544561 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/d289dbadf718e02a2b13d38e5bb1bfa26a090f9d..b7e8c6eb13e6eb297747b9e394854408b3f29195

Suspect: https://chromium.googlesource.com/chromium/src/+/b7e8c6eb13e6eb297747b9e394854408b3f29195

wangxianzhu@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also reproducible on Linux (14.04 LTS) OS.
   
Thank You!
Blocking: 771643
Owner: pdr@chromium.org

Comment 5 by pdr@chromium.org, Mar 27 2018

Here's a minimized repro:
<!doctype html>
<div style="overflow-y: hidden; opacity: 0.9; font-size: 50px;">
clip bug 1 clip  bug 2  clip  bug 3 
</div>

Reproduces with --disable-blink-features=SlimmingPaintV175, does not reproduce with --enable-blink-features=SlimmingPaintV175

Comment 6 by pdr@chromium.org, Mar 28 2018

Debug tip: it's possible to reproduce this without the print preview window by using ctrl+shift+p.

Comment 7 by pdr@chromium.org, Apr 3 2018

 Issue 826188  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e0db4628329fa2944926ea9a170a81e3ccbefe7

commit 3e0db4628329fa2944926ea9a170a81e3ccbefe7
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Apr 04 00:14:03 2018

[SPV175] Update visual rects when printing

Printing can change layout and we should update visual rects when this occurs.
After [1], visual rects are used for clipping which exposed a bug where painting
occurred with stale visual rects (the skia rtree is not used when printing which
would have exposed this in SPV1). This patch fully enables the paint
invalidation step to reduce special-cases in the document lifecycle, even though
only the visual rect update is strictly needed.

[1] https://chromium.googlesource.com/chromium/src/+/b7e8c6eb13e6eb297747b9e394854408b3f29195

Bug:  824031 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b9b358b078fa15b4aa1c26b494c213d62e571c4
Reviewed-on: https://chromium-review.googlesource.com/993700
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547881}
[modify] https://crrev.com/3e0db4628329fa2944926ea9a170a81e3ccbefe7/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
[modify] https://crrev.com/3e0db4628329fa2944926ea9a170a81e3ccbefe7/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/3e0db4628329fa2944926ea9a170a81e3ccbefe7/third_party/WebKit/Source/core/paint/PaintInvalidator.h
[modify] https://crrev.com/3e0db4628329fa2944926ea9a170a81e3ccbefe7/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Comment 9 by pdr@chromium.org, Apr 4 2018

Status: Fixed (was: Assigned)

Sign in to add a comment