New issue
Advanced search Search tips

Issue 824010 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: PotentialCompositingReasonsFromStyle(layer->GetLayoutObject()) == layer->Potenti

Project Member Reported by ClusterFuzz, Mar 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5816481481490432

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  PotentialCompositingReasonsFromStyle(layer->GetLayoutObject()) == layer->Potenti
  blink::CompositingReasonFinder::DirectReasons
  blink::CompositingRequirementsUpdater::Update
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=540023:540026

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5816481481490432

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 21 2018

Components: Blink>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 21 2018

Labels: Test-Predator-Auto-Owner
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ff4066808ef95efb35430d062ae6ad2705ca1ac6 ([Go] Skip updating compositing reasons if style has not changed.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: -Pri-1 Pri-2
I don't think this is a P1 situation. The reproduction case is a nightmare of JS selection manipulation code.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8585ccd6f3c904fcb0afa76ea1237d349d77e5

commit fa8585ccd6f3c904fcb0afa76ea1237d349d77e5
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Mar 27 21:59:27 2018

[PE] Re-compute compositing reasons if used transform-3d state changed.

This is a tricky case, where the used (== actually in effect) value
of preserves-3d changes when certain other properties are set.
See ComputedStyle::UsedTransformStyle3D() for more details.

Bug:  824010 

Change-Id: Ie96c7d51816ad7866d4648dcbcfe25d4284c8558
Reviewed-on: https://chromium-review.googlesource.com/982271
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546281}
[modify] https://crrev.com/fa8585ccd6f3c904fcb0afa76ea1237d349d77e5/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/fa8585ccd6f3c904fcb0afa76ea1237d349d77e5/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/fa8585ccd6f3c904fcb0afa76ea1237d349d77e5/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Mar 28 2018

ClusterFuzz has detected this issue as fixed in range 546276:546282.

Detailed report: https://clusterfuzz.com/testcase?key=5816481481490432

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  PotentialCompositingReasonsFromStyle(layer->GetLayoutObject()) == layer->Potenti
  blink::CompositingReasonFinder::DirectReasons
  blink::CompositingRequirementsUpdater::Update
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=540023:540026
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=546276:546282

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5816481481490432

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Mar 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5816481481490432 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment