hit-test aggregator should know to shrink hit-test data buffer size |
|
Issue descriptionright now hit-test aggregator knows how to grow the buffer size when we have too many hit-test regions [1]. it is possible that after a while, user closes a lot of tabs/iframes that we now only need a small buffer size. hit-test aggregator should know to shrink the buffer size in that case. [1] https://cs.chromium.org/chromium/src/components/viz/service/hit_test/hit_test_aggregator.h?type=cs&q=hit_test_agg&sq=package:chromium&l=56
,
Jan 14
afaik: this isn't done. It should still be done. Do we think that this would be a good task for an intern?
,
Jan 14
I think this becomes an issue only when/if we use shared-memory for the aggregated data. Right now, we always send a copy of the data back to the host*. So the task would involve actually switching back to using shared-memory for the transport. [*] If we don't plan on using shared-memory soon-ish, perhaps we could simplify the existing code a bit.
,
Jan 14
Yea it was used to know when to allocate new shared-memory block on the aggregator side, now it's being used to decide when to increase the vector size cuz we don't know children size yet when we start aggregating. |
|
►
Sign in to add a comment |
|
Comment 1 by kylec...@chromium.org
, Jan 14