New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823990 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

buildbucket.cfg: validate configs against swarming

Project Member Reported by no...@chromium.org, Mar 21 2018

Issue description

Today, it is possible to land a cr-buildbucket.cfg config that specifies dimensions for which we don't have bots, and nobody would notice until the builder has a long pending queue.

We should improve our config validation.

One downside is that config validation result would depend not only on the contents of the config, but also state of our services. Normally, validation result depends only on the config file contents.

context: https://chromium-review.googlesource.com/c/chromium/src/+/970907#message-70354bd8699bd7e812c7cb148a4e6e45135bd96b
 
(from CL above)
>> tandrii@: I think tricium's plugin performing the queries would be best.

> nodir@: good point. it would have to parse text proto itself to preserve line numbers, right? also understand config semantics

I was thinking of tricium plugin being a shim around API call to buildbucket itself. This way users still get feedback, but you don't get downside of validating proper depending on the state of swarming.

Comment 2 by no...@chromium.org, Apr 30 2018

Labels: buildbucket-go

Comment 3 by no...@chromium.org, May 19 2018

Status: Available (was: Untriaged)

Sign in to add a comment