New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823986 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

remove libwidevinecdmadapter.so from simple chrome workflow

Project Member Reported by osh...@chromium.org, Mar 21 2018

Issue description

Deploying chrome now fails with following error.

MissingPathError: /usr/local/google/home/oshima/chrome-git/src/out_caroline/Release/libwidevinecdmadapter.so does not exist and is required.

This is due to   crbug.com/772160   / crrev.com/c/957868. 

We need to remove this requirement from the flow?
 

Comment 1 by osh...@chromium.org, Mar 21 2018

By the way, if you already have so file built from past builds, this won't fail.

Components: -Tools>ChromeOS-Toolchain Infra>Client>ChromeOS
Owner: jen...@chromium.org
Chrome gardener should be looking into this.
Cc: vapier@chromium.org
CL under review: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/971665

Comment 4 by vapier@chromium.org, Mar 21 2018

Owner: xhw...@chromium.org
Status: Started (was: Untriaged)

Comment 5 by vapier@chromium.org, Mar 21 2018

Labels: -Restrict-View-Google

Comment 6 by xhw...@chromium.org, Mar 21 2018

Sorry for breaking this. I'll test my CL and land it asap.

Comment 7 by xhw...@chromium.org, Mar 21 2018

I am working remotely and don't have a real chromeos device to deploy chrome. What's the easiest way to reproduce this error?

I also found ./scripts/deploy_chrome_unittest.py, which covers _COPY_PATHS_CHROME. But how do I run the test?

Comment 8 by xhw...@chromium.org, Mar 21 2018

Description: Show this description

Comment 9 by vapier@chromium.org, Mar 21 2018

you can boot a VM and deploy to that

once chromite updates on the CrOS side, you'll need to do a deps roll on the Chromium side
Thanks! I haven't worked on ChromeOS for a while. So I feel I need more help.

Will deploy_chrome_unittest test this path as well? Does this test only work in the chroot?

Any instructions how to boot a VM and deploy to that? Is it like I don't really need a test image etc. As long as there's an ip we'll deploy files to the target folder on that ip address?
Anyone can help answer questions in #10? Otherwise, I'll setup a ChromeOS device with test image and test my CL.
Cc: achuith@chromium.org
SHould be pretty easy to use a cros VM instead of a DUT for this:
http://go/cros-vm

https://chromium.googlesource.com/chromiumos/docs/+/master/cros_vm.md


Cc: sammiequon@chromium.org bbudge@chromium.org raymes@chromium.org jrbarnette@chromium.org
 Issue 823974  has been merged into this issue.
Thanks! Trying VM now.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07

commit a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 03:48:34 2018

chrome-sdk: Remove Widevine CDM adapter

As part of pepper CDM deprecation, we do not have the Widevine CDM
adapter binary any more.

Bug:  772160 ,  823986 
Test: Tested by deploying chrome to cros vm.
      See http://go/simple-chrome and go/cros-vm.
Change-Id: I0d7e72006b468696a4b13dafebe1de041571e1cb
Reviewed-on: https://chromium-review.googlesource.com/971665
Commit-Ready: Xiaohan Wang <xhwang@chromium.org>
Tested-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07/lib/chrome_util.py

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c966e00e868ad1aeaa268d7c373e7ce8e5612968

commit c966e00e868ad1aeaa268d7c373e7ce8e5612968
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 06:36:31 2018

Roll src/third_party/chromite/ 8bf5a7243..a1ec7e112 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bf5a724397c..a1ec7e112c5e

$ git log 8bf5a7243..a1ec7e112 --date=short --no-merges --format='%ad %ae %s'
2018-03-21 xhwang chrome-sdk: Remove Widevine CDM adapter
2018-03-17 pberny atlas: Add master builder configuration

Created with:
  roll-dep src/third_party/chromite

TBR=achuith@chromium.org,vapier@chromium.org
BUG= 772160 , 823986 

Change-Id: I12d8487657339b574b5285c6598a84e14fa4afed
Reviewed-on: https://chromium-review.googlesource.com/974798
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544987}
[modify] https://crrev.com/c966e00e868ad1aeaa268d7c373e7ce8e5612968/DEPS

Status: Fixed (was: Started)

Sign in to add a comment