luci-notify: add support for static blamelist |
||||||||||
Issue descriptionauthors of CLs that break CI builds needs to be notified over email about that. Historically this was done by gatekeeper. It works with LUCI because of API emulation. Going forward, implement blamelist email notification in luci-notify. It must be opt-in to avoid spam and for security purposes. A bucket/builder should be explicitly configured to be opted-in. When opting-in, it should be possible to specify a CIA group as a filter of email recipients. note that, at least today - we don't need sophisticated dynamic blamelist implementation for this, because an email message does not change after it is sent. The blamelist can be computed at about the time of email generation related: issue 823934
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
FYI there are internal CI builds for which we do NOT want to notify the authors because those builders may be running on unreleased hardware, whereas the authors may be non-Googlers. An email would leak the name of the builder. In Buildbot world we've handled this by replacing the list of changes associated with the build with a fake 'trigger_proxy' author, but there are no changes in the LUCI world, so we would need to find a different solution for this. I can see 3 potential solutions: - disable emails for specific builders altogether (not good bcz noone is monitoring failures) - allow emails to fixed set of people (better, but those people will have to manually triage failures) - send emails to the whitelisted authors, e.g. based on a group in chrome-infra-auth (best solution) Additionally, we'd love to see support of more than a single repo, e.g. V8 perfbots check out https://chromium.googlesource.com/v8/v8/ and https://chrome-internal.googlesource.com/v8/v8-perf/ and we would like to notify the authors of both repos.
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
i've updated description to clarify that blamelist emails must be opt-in, it should be possible to specify a CIA group and removed "we don't really need to support DEPSed repos" > allow emails to fixed set of people (better, but those people will have to manually triage failures) this is supported today.
,
Mar 21 2018
+athom who needs this feature. i don't think our team currently has cycles for this. If this urgent, please consider helping.
,
Mar 21 2018
From the Dart perspective, Gatekeeper now does the job (in a mediocre sort of way with broken links bug #823360 and confusing messages bug #646972 ). Still, we just removed our luci-notify config, because it lacks: * blamelist notifications (this bug?) * nice emails (GK has a lot more interesting info and less Luci details that aren't relevant to our committers) * no configurable emails (the template is hardcoded) * on_change sends mails for the first failure, but also for the first success (which is different from GK, and undesired for us)
,
Mar 27 2018
,
Mar 27 2018
Issue 822694 has been merged into this issue.
,
Oct 18
,
Oct 18
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by no...@chromium.org
, Mar 21 2018