[CRD iOS] App crashes when host crashes while cursor is flinging |
||||
Issue descriptionApp Version: 67.0.3376.0 OS Version: 11.2 What steps will reproduce the problem? (1) Connect to a host (2) Choose trackpad mode (3) Keep flinging the cursor (4) While doing #3, kill the host What is the expected result? The app goes back to the host list without crashing. What happens instead? App crashes. This doesn't have a big impact because it has to be the connection closed from the remote side.
,
Mar 21 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efe133060a2337440c35e658ac77a74feb83f787 commit efe133060a2337440c35e658ac77a74feb83f787 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Mar 21 20:44:19 2018 [CRD iOS] Fix a crash when session is disconnected while the cursor is still flinging The issue is that DisconnectFromHost() invalidates gestureInterpreter before ClientGesture is destroyed (which is destroyed when the host view is removed). If the user is interacting with the view after gestureInterpreter is destroyed but before the view is removed then ClientGesture will call gestureInterpreter's methods on null, which crashes the app. This CL fixes this by always checking _client and _client.gestureInterpreter before using them. Bug: 823983 Change-Id: I3889c95daf28b84bbf9aecd26f0024dcb15adbe4 Reviewed-on: https://chromium-review.googlesource.com/972631 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544830} [modify] https://crrev.com/efe133060a2337440c35e658ac77a74feb83f787/remoting/client/gesture_interpreter.cc [modify] https://crrev.com/efe133060a2337440c35e658ac77a74feb83f787/remoting/client/gesture_interpreter.h [modify] https://crrev.com/efe133060a2337440c35e658ac77a74feb83f787/remoting/ios/client_gestures.mm
,
Mar 21 2018
,
Jul 19
gives an error indicating host has crashed, then you can hit back to go to host list. Verified Fixed in 67.0.3396.22 |
||||
►
Sign in to add a comment |
||||
Comment 1 by yuweih@chromium.org
, Mar 21 2018