New issue
Advanced search Search tips

Issue 823968 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: Mar 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Download progress bar shows 100% progress for failed download

Project Member Reported by eugene...@chromium.org, Mar 21 2018 
App Version (from "Chrome Settings > About Chrome"): M67
iOS Version: All
Device: All

Steps to reproduce: 
1.) Load https://www.barebones.com/products/bbedit/download.html
2.) Tap Download button on web page
3.) Turn on Airplane mode
4.) Tap Download button on Download Manager toolbar
5.) Wait until the download is failed
6.) Tap Try Again button

Observed behavior: 
Download progress bar shows 100% progress

Expected behavior: 
Download progress shows 0% progress

Frequency: 
5/5

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb8d800baa8970730cba39ba0a6d03a72cadae25

commit cb8d800baa8970730cba39ba0a6d03a72cadae25
Author: Eugene But <eugenebut@google.com>
Date: Wed Mar 21 16:11:11 2018

Reset percent_complete and received_bytes when DownloadTask is started.

When download is restarted after the failure the progress should be 0%.
This CL fixes the bug where download UI displayed 100% progress after
restarting the failed download.

Bug:  823968 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia44961f9602ea76b0a731bae1829d48fa5fc533f
Reviewed-on: https://chromium-review.googlesource.com/972575
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544722}
[modify] https://crrev.com/cb8d800baa8970730cba39ba0a6d03a72cadae25/ios/web/download/download_task_impl.mm
[modify] https://crrev.com/cb8d800baa8970730cba39ba0a6d03a72cadae25/ios/web/download/download_task_impl_unittest.mm

Comment 3 by eugene...@chromium.org, Mar 26 2018

Status: Fixed (was: Started)

Comment 4 by srikanthg@chromium.org, Mar 27 2018

Status: Assigned (was: Fixed)
Failed at step#5. Download is never timed out.
Downloading... status is displayed forever in airplane mode.
Let me know if that needs tobe reported as a new bug.

Tested on M67.0.3382.0 canary
iOS: 11.3, 10.3.3
Devices: iPhoneX, iPhone6, iPad Air2

Comment 5 by eugene...@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)
This bug was related to UI glitch, which is fixed now. Download never times out if there is no internet, so we need to use different way to test the failure. I test on Simulator, test test can use custom http server which closes the connection or test in Simulator as well.

Comment 6 by vbhatso...@chromium.org, May 18 2018

Status: Verified (was: Fixed)
Verified on iPad Pro 12'5 iOS 11.2.5, iPhone X iOS 11.2.6 on build 67.0.3396.50 Beta
►

Sign in to add a comment