Port existing UI to angular and update with material design. Provide any necessary build steps so that the app is compiled and packed with mobmonitor in a build.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/88ad0da083504aabd49012cf56f5ec57227e63b5 commit 88ad0da083504aabd49012cf56f5ec57227e63b5 Author: Matt Mallett <mattmallett@chromium.org> Date: Fri Mar 23 21:51:09 2018 nodejs: upgraded package to upstream Upgraded net-libs/nodejs to version 6.11.5 on amd64 BUG= chromium:823965 TEST=Verified that correct version was installed, and the version is compatible with our angular build Change-Id: I3868403fc6726f287ef99e87f1f4d6d54d5c46f6 Reviewed-on: https://chromium-review.googlesource.com/974454 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/88ad0da083504aabd49012cf56f5ec57227e63b5/net-libs/nodejs/metadata.xml [rename] https://crrev.com/88ad0da083504aabd49012cf56f5ec57227e63b5/metadata/md5-cache/net-libs/nodejs-6.11.5 [modify] https://crrev.com/88ad0da083504aabd49012cf56f5ec57227e63b5/net-libs/nodejs/Manifest [rename] https://crrev.com/88ad0da083504aabd49012cf56f5ec57227e63b5/net-libs/nodejs/nodejs-6.11.5.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23 commit 1bc43c4a8e4ada9c9a08722ce708acb303ca4e23 Author: Matt Mallett <mattmallett@chromium.org> Date: Fri Mar 23 21:50:55 2018 [moblab] First draft new mobmonitor UI New mobmonitor UI using Angular5 with Material design. First commit is to lay down a bare-bones app and get the build system checked in. BUG= chromium:823965 TEST=Build and test on workstation and on moblab Change-Id: Ife3f9af85a2b888f1036dfe39011d5dbcf5dc01b Reviewed-on: https://chromium-review.googlesource.com/973553 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/protractor.conf.js [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/e2e/app.e2e-spec.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/README.md [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/test.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/polyfills.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/.angular-cli.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/PRESUBMIT.cfg [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/tsconfig.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/environments/environment.prod.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/typings.d.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/environments/environment.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/favicon.ico [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/app.module.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/karma.conf.js [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/app.component.scss [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/e2e/app.po.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/index.html [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/package.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.spec.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/e2e/tsconfig.e2e.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/proxy.conf.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/health-checks/health-checks.component.html [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/health-checks/health-checks.component.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/package-lock.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/assets/.gitkeep [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/sass/styles.scss [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/health-checks/health-checks.component.spec.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/actions/actions.component.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/shared/health-check.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/app.component.spec.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/tsconfig.app.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/tslint.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/shared/action-info.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/actions/actions.component.spec.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/.gitignore [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/shared/repair-service-info.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/app.component.html [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/app.component.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/health-checks/health-checks.component.scss [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/actions/actions.component.html [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/shared/action.ts [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/app/actions/actions.component.scss [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/tsconfig.spec.json [add] https://crrev.com/1bc43c4a8e4ada9c9a08722ce708acb303ca4e23/src/mobmonitor-ui/src/main.ts
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f7be4fea3fe6b4633d1451e29529575b034c44f7 commit f7be4fea3fe6b4633d1451e29529575b034c44f7 Author: Matt Mallett <mattmallett@chromium.org> Date: Mon Mar 26 21:41:29 2018 [moblab] Adding nodejs to sdk Putting nodejs into sdk, so we can use it to compile our angular apps. BUG= chromium:823965 TEST=Ran build successfully with sdk nodejs Change-Id: Iaca361847cdba407f163ca2158f25a80a1480e34 Reviewed-on: https://chromium-review.googlesource.com/978845 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f7be4fea3fe6b4633d1451e29529575b034c44f7/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild [rename] https://crrev.com/f7be4fea3fe6b4633d1451e29529575b034c44f7/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r105.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0d0966f15542dca22c1538dd5af0774b96abcfcd commit 0d0966f15542dca22c1538dd5af0774b96abcfcd Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Mar 27 00:03:30 2018 [moblab] Create angular build for Mobmonitor Build Mobmonitor's angular frontend within the ebuild. The angular build process requires nodejs. I am upgrading the existing ebuild to v6.11.5, which will work for us. node_modules contains all the compile time dependencies include the angular libraries and angular compiler. Normally we would use `npm install` to pull all dependences down from the internet, but that's not very ebuild-friendly. I've pre-downloaded and packaged all the node_modules for this app in the localmirror. We would need to update a new version of this bundle whenever node_modules changes, but that shouldn't change _that_ often. BUG= chromium:823965 TEST=Ran the build and flashed to local moblab device, verified mobmonitor compiled correctly and runs. CQ-DEPEND=CL:974454, CL:973553, CL:978845 Change-Id: I7630ce60a1f72e3d967c0e12d7959e2366253051 Reviewed-on: https://chromium-review.googlesource.com/974475 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0d0966f15542dca22c1538dd5af0774b96abcfcd/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild [add] https://crrev.com/0d0966f15542dca22c1538dd5af0774b96abcfcd/project-moblab/sys-apps/mobmonitor-ui/mobmonitor-ui-9999.ebuild [add] https://crrev.com/0d0966f15542dca22c1538dd5af0774b96abcfcd/project-moblab/sys-apps/mobmonitor-ui/Manifest
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/a9de6cd901ad9d2b885587a46d178a40800073d3 commit a9de6cd901ad9d2b885587a46d178a40800073d3 Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Apr 03 03:12:56 2018 [moblab] add params dialog for running mobmonitor action Added the dialog that will prompt users for params if the action requires them. Refactored the backend to do away with args, kwargs, and instead use a 'params' key value map. Updated unit tests for frontend and backend for all changes Snuck in the collect logs as it's a small change BUG= chromium:824884 , chromium:823965 TEST=ng test, e2e/run_e2e.sh, python mobmonitor_unittest.py, python manager_unittest.py Change-Id: Ic94da179ed9bcfedc194c01f88bd82bcec0e1118 Reviewed-on: https://chromium-review.googlesource.com/985252 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor_unittest.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.e2e-spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.module.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/mobmonitor.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/app.po.ts [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/disk_check.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/moblab_actions.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/proxy.conf.json [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.scss [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.spec.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.scss [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/action-info.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/e2e/proxy-e2e.conf.json [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/README [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/shared/repair-service-info.ts [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfile/manager_unittest.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/app.component.html [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor/checkfiles/moblab/upstart_services_running_check.py [modify] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/actions/actions.component.html [add] https://crrev.com/a9de6cd901ad9d2b885587a46d178a40800073d3/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.html
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/5278d11f0aa36e2ba08337d11fb526254fc7c8fe commit 5278d11f0aa36e2ba08337d11fb526254fc7c8fe Author: Matt Mallett <mattmallett@chromium.org> Date: Thu Apr 05 01:52:12 2018 [moblab] Improve error handling in mobmonitor-ui Add an error dialog which will show a human readable diagnosis, the javascript error, and the stack trace. Also update the 'last updated at' with an error if it's determined that we have lost connection. map localhost:9991/ to the new UI, effectively removing the old UI. BUG= chromium:823965 TEST=ng test, e2e/run_e2e/sh Change-Id: I417a00fffecda755be63d304e487a9923722b612 Reviewed-on: https://chromium-review.googlesource.com/992867 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display-dialog/error-display-dialog.component.scss [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display-dialog/error-display-dialog.component.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/health-checks/health-checks.component.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/actions-param-dialog/actions-param-dialog.component.spec.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/app.component.scss [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/app.component.html [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/app.component.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.spec.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/actions/actions.component.ts [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display.service.spec.ts [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/shared/mobmonitor-error.ts [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display-dialog/error-display-dialog.component.html [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor/mobmonitor.py [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display-dialog/error-display-dialog.component.spec.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/app.module.ts [add] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/error-display.service.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/services/mobmonitor-rpc.service.ts [modify] https://crrev.com/5278d11f0aa36e2ba08337d11fb526254fc7c8fe/src/mobmonitor-ui/src/app/actions/actions.component.spec.ts
Comment 1 by bugdroid1@chromium.org
, Mar 23 2018