Fix one key error in Keyboard shortcut viewer |
||||||||
Issue descriptionToT The shortcut for page down is wrong. Should be Alt or Search + "arrow down".
,
Mar 21 2018
,
Mar 22 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 22 2018
+josafat@, One key was mistaken labeled. Request to merge back to M66. This change only affects the Keyboard Shortcut Helper app.
,
Mar 23 2018
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ce5135627d3d6ea7f74b3c2f15b34bf646776c2 commit 9ce5135627d3d6ea7f74b3c2f15b34bf646776c2 Author: wutao <wutao@chromium.org> Date: Fri Mar 23 18:03:01 2018 M66 Merge: cros: Fix one key error in KSV. This cl fixes one key error in Keyboard Shortcut Viewer (KSV). TBR=warx@google.com Bug: 823939 Test: manual test. Change-Id: Iffbed74601548e5980ec36bfbdc51c30d9b3304b Reviewed-on: https://chromium-review.googlesource.com/972167 Reviewed-by: Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#544600}(cherry picked from commit 1e8a681519729bd5dee443ad2576d2b895aa0773) Reviewed-on: https://chromium-review.googlesource.com/978454 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#402} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/9ce5135627d3d6ea7f74b3c2f15b34bf646776c2/ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc
,
Mar 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 21 2018