Any changes made to bitmaptools or toolchains that might cause this failure?

Talked to dpranke@, it might be a toolchain issue.

Full error:

chromeos-chrome-67.0.3377.0_alpha-r1: [106/40254] LINK ./bitmaptools
chromeos-chrome-67.0.3377.0_alpha-r1: FAILED: bitmaptools 
chromeos-chrome-67.0.3377.0_alpha-r1: python "../../../../../../../home/chrome-bot/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="./bitmaptools" -- x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -m64 -Wl,-O2 -Wl,--gc-sections -Wl,--gdb-index -Wl,--fatal-warnings --sysroot=../../../../../../../build/amd64-generic -L../../../../../../../build/amd64-generic/lib64 -Wl,-rpath-link=../../../../../../../build/amd64-generic/lib64 -L../../../../../../../build/amd64-generic/usr/lib64 -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/lib64 -L../../../../../../../build/amd64-generic/usr/local/lib64 -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/local/lib64 -L../../../../../../../build/amd64-generic/lib -Wl,-rpath-link=../../../../../../../build/amd64-generic/lib -L../../../../../../../build/amd64-generic/usr/lib -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/lib -L../../../../../../../build/amd64-generic/usr/local/lib -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/local/lib -L../../../../../../../build/amd64-generic/usr/x86_64-cros-linux-gnu/lib -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/x86_64-cros-linux-gnu/lib -L../../../../../../../build/amd64-generic/usr/lib/llvm/lib64 -Wl,-rpath-link=../../../../../../../build/amd64-generic/usr/lib/llvm/lib64 -fsanitize=address -fsanitize-address-use-after-scope -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -Wl,-u_sanitizer_options_link_helper -fsanitize=address -fsanitize-address-use-after-scope -Wl,-O1 -Wl,-O2 -Wl,--as-needed -stdlib=libc++  -o "./bitmaptools" -Wl,--start-group @"./bitmaptools.rsp"  -Wl,--end-group   -ldl -lpthread -lrt 
chromeos-chrome-67.0.3377.0_alpha-r1: /usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0/ld.gold.real: warning: Cannot export local symbol '_Unwind_RaiseException'
chromeos-chrome-67.0.3377.0_alpha-r1: /usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0/ld.gold.real: error: treating warnings as errors
chromeos-chrome-67.0.3377.0_alpha-r1: clang-7.0: error: linker command failed with exit code 1 (use -v to see invocation)
chromeos-chrome-67.0.3377.0_alpha-r1: 


thomasanderson@, any ideas? Maybe we changed something on linux that needed to be changed on CrOS as well and we're not linking in libunwind?

bitmaptools should be compiled with exceptions disabled.  libunwind is whitelisted to only libc++{abi}, which should be the only thing in the repo with exceptions enabled.

If, for whatever reason, bitmaptools *really* needs exceptions, just whitelist it from the libunwind target, and add libunwind as a dep.

+nednguyen for catapult-related things.

@thomasanderson - any idea why we would've just seen this only in this build on this builder, and not anywhere else?

Don't know :(

The failure happened very early in the build though, at only 106/40254 steps.  So this is likely unrelated to bitmaptools and is a broader build issue.

No one has touched bitmaptools code in a year, so I think this is toolchain/config failure type of thing.

I don't think we are interested in doing asan on Chrome in  ChromeOS. So maybe just mask the asan flag (See CL https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/970853) ?

Alternatively, since this is just a linker warning and we probably don't really care about running asan built Chrome on HW, just ignore the warning when use="asan" i.e. add the flag -Wl,--no-fatal-warnings.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0d90fcdad1b7e3c237bcd79ead34ec91a51a2246

commit 0d90fcdad1b7e3c237bcd79ead34ec91a51a2246
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Mar 28 03:35:06 2018

Chrome: Make linker warnings non-fatal for asan builds.

Some asan builders are failing because of linker warnings.
Make the linker warnings non-fatal so that Chrome builds.
The warnings are not issued when building with lld so
make the check dependent on both asan and gold.

BUG= chromium:823936 
TEST=Chrome builds.

Change-Id: I6bf8556d83389dec3e1ec826200bb6114718feca
Reviewed-on: https://chromium-review.googlesource.com/980580
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0d90fcdad1b7e3c237bcd79ead34ec91a51a2246/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

> I don't think we are interested in doing asan on Chrome in  ChromeOS

Should we just delete that bot then?

> Should we just delete that bot then?

The builder tests many Chrome OS packages with asan, so yes we need this testing. But IMO, testing Chrome itself with asan is probably better done by Chrome land bots.

In any case, I have fixed the Chrome build issue for now. 

why are we marking this fixed ?  there's a problem here.

The builder failures because of Chrome is fixed (though the underlying problem related to gold warning is still not fixed; Maybe I should open a different bug for that).

Or do you mean the asan bluetooth tests that are failing?

i mean landing a workaround to disable warnings for what looks like a bug in the Chrome build is not a long term fix.  but you've opened issue 827003 to track.