New issue
Advanced search Search tips

Issue 823935 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

CHECK failure: !!original_properties_->OverflowControlsClip() == !!object_properties->OverflowC

Project Member Reported by ClusterFuzz, Mar 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4766505766748160

Fuzzer: marty_html_twiddler
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !!original_properties_->OverflowControlsClip() == !!object_properties->OverflowC
  blink::FindObjectPropertiesNeedingUpdateScope::~FindObjectPropertiesNeedingUpdat
  blink::FragmentPaintPropertyTreeBuilder::UpdateForSelf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=530696:530699

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4766505766748160

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 20 2018

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 20 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/8b6cd640ca57f9848c4dde7c55546ff030296562 ([SPv175+] OverflowControlsClip).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Blocking: 771643
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ef05cca5b26fefffe1717276506ac3936038a5

commit 17ef05cca5b26fefffe1717276506ac3936038a5
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Mar 21 22:18:44 2018

[PE] Make NeedsOverflowControlsClip() more accurate

Previously the function was a static function which didn't know the
current paint offset so was unable to calculate the accurate pixel
snapped border box rect, so used a conservative border box rect which
caused some unnecessary OverflowControlsClip() whose change of
existence was not updated.

Now make it a method of FragmentPaintPropertyTreeBuilder to return
the accurate needs, so the change of needs is covered by existing
SetNeedsPaintPropertyTreeUpdate conditions.

Bug:  823935 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I07578033d202af3c996004a88f25711eaac245a2
Reviewed-on: https://chromium-review.googlesource.com/974167
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544870}
[modify] https://crrev.com/17ef05cca5b26fefffe1717276506ac3936038a5/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/17ef05cca5b26fefffe1717276506ac3936038a5/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Project Member

Comment 5 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544864:544873.

Detailed report: https://clusterfuzz.com/testcase?key=4766505766748160

Fuzzer: marty_html_twiddler
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !!original_properties_->OverflowControlsClip() == !!object_properties->OverflowC
  blink::FindObjectPropertiesNeedingUpdateScope::~FindObjectPropertiesNeedingUpdat
  blink::FragmentPaintPropertyTreeBuilder::UpdateForSelf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=530696:530699
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=544864:544873

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4766505766748160

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4766505766748160 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment