New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

extensions::PreSandboxStartup() should be removed

Project Member Reported by jcivelli@chromium.org, Mar 20 2018

Issue description

As part of the effort to move process launching to the service manager, we should remove extensions::PreSandboxStartup() as service processes don't have such a capability (service processes are sandboxed early on).

That method is used to initialize the media library, which gets the CPU info for libyuv and ffmep libraries. We should probably have the unsadnboxed process provide that information to them through IPC.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af

commit 5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af
Author: Jay Civelli <jcivelli@google.com>
Date: Wed Apr 04 23:12:41 2018

Add a test to validate CPU info init in media gallery util

Adds a test that validates that the third-party libraries used by the
chrome media gallery util service are using the right CPU info.
This is going to be usefull for an upcoming CL that changes how that
information is set (it'll be passed through IPC).

Bug:  823931 
Change-Id: I9e9586af8615739db0baf36ed547ef017546adb5
Reviewed-on: https://chromium-review.googlesource.com/996392
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548235}
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/BUILD.gn
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/DEPS
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/media_parser.cc
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/media_parser.h
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/public/cpp/BUILD.gn
[add] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/public/cpp/media_gallery_util_browsertest.cc
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify] https://crrev.com/5b8a06be104ad7ee2ad7f0220da4e8ed7179d9af/chrome/test/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/f34a90b2109007f1dace5824e26108b19d11cb81

commit f34a90b2109007f1dace5824e26108b19d11cb81
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Apr 05 18:48:07 2018

Expose a method in cpu.h that will soon be used by Chromium

Exposing the av_force_cpu_flags as it will be soon needed by Chromium.

Bug:  823931 

Change-Id: Ife7f0c7b4cf57661c0552bf9be9e99d4b180a1aa
Reviewed-on: https://chromium-review.googlesource.com/996583
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>

[modify] https://crrev.com/f34a90b2109007f1dace5824e26108b19d11cb81/chromium/ffmpeg.sigs

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc00d0dd230640a1b58f209071fa3cbf32a762a9

commit fc00d0dd230640a1b58f209071fa3cbf32a762a9
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Apr 06 01:38:08 2018

Roll src/third_party/ffmpeg/ dee930847..f34a90b21 (1 commit)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/dee930847568..f34a90b21090

$ git log dee930847..f34a90b21 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 jcivelli Expose a method in cpu.h that will soon be used by Chromium

Created with:
  roll-dep src/third_party/ffmpeg

Bug:  823931 
Change-Id: I5c98a3e98f5f5fb87e46b0d6da17a05a0a0f09a1
Reviewed-on: https://chromium-review.googlesource.com/998185
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548631}
[modify] https://crrev.com/fc00d0dd230640a1b58f209071fa3cbf32a762a9/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc2f693490f467467902c80fcf13444ba6de009

commit fbc2f693490f467467902c80fcf13444ba6de009
Author: Jay Civelli <jcivelli@google.com>
Date: Wed Apr 11 07:46:36 2018

Make media::InitMediaLibrary work with the sandbox

Initializing the media library entails getting information about the CPU
for the libyuv and ffmep libraries. Retrieving that information might
access the file system (/cpu/procinfo). The extension handler code would
initialize the media library before the sandbox is turned on.
As part of the effort to move process launching to the service manager
where the service process is always sandboxed, this CL  adds a new
InitializeMediaLibraryInSandbox method that lets callers specify the CPU
info so the initialization can be done inside the sandbox.

The client library of the media gallery util service which was the
reason why extension handlers would need to initialize the media
library, now do it explicitly and provide the CPU info. As a result,
extension handlers related files can be removed.

Bug:  823931 

Change-Id: Ie1630f3ff04c94901224750ffdea4423bd1b3186
Reviewed-on: https://chromium-review.googlesource.com/966925
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549813}
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/browser/media_galleries/fileapi/supported_audio_video_checker.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/BUILD.gn
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/manifest.json
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/media_gallery_util_service.cc
[add] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/media_parser_factory.cc
[add] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/media_parser_factory.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/BUILD.gn
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/DEPS
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/media_gallery_util_browsertest.cc
[add] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/media_parser_provider.cc
[add] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/media_parser_provider.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/safe_audio_video_checker.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/safe_audio_video_checker.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/utility/BUILD.gn
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/chrome/utility/chrome_content_utility_client.h
[delete] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/utility/extensions/DEPS
[delete] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/utility/extensions/OWNERS
[delete] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/utility/extensions/extensions_handler.cc
[delete] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/utility/extensions/extensions_handler.h
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/extensions/OWNERS
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/media/base/media.cc
[modify] https://crrev.com/fbc2f693490f467467902c80fcf13444ba6de009/media/base/media.h

Status: Fixed (was: Untriaged)

Sign in to add a comment