New issue
Advanced search Search tips

Issue 823930 link

Starred by 1 user
Status: Duplicate
Merged: issue 823507
Owner:
jgruber@chromium.org
Closed: Mar 2018
Cc:
yangguo@chromium.org
jgruber@chromium.org
m...@chromium.org
mstarzinger@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.7% regression in octane at 543993:544019

Project Member Reported by m...@chromium.org, Mar 20 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 20 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=823930

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9e3127ff184011b20453176fb6a67574204301c36e898edfc8b02e527145397a


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 21 2018

Cc: yangguo@chromium.org mstarzinger@chromium.org jgruber@chromium.org
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1235d059440000

Reland "[builtins] Remove off-heap builtins from the snapshot" by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/fd70917d520ea7bbcc5e401776c7dac7120c6942

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by jgruber@chromium.org, Mar 21 2018

Mergedinto: 823507
Status: Duplicate (was: Assigned)
It's interesting how regressions come not only from code changes (i.e. indirections for constants and external references), but also from this CL which simply executes binary-embedded code instead of on-heap code.

I'm currently working on improving perf by reducing said indirections, will also keep an eye on this.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 21 2018

Status: Assigned (was: Duplicate)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a91919440000

Reland "[builtins] Remove off-heap builtins from the snapshot" by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/fd70917d520ea7bbcc5e401776c7dac7120c6942

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by jgruber@chromium.org, Mar 21 2018

Status: Duplicate (was: Assigned)
►

Sign in to add a comment