New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823922 link

Starred by 5 users
Status: Started
Owner:
malaykeshav@chromium.org
Cc:
kaznacheev@chromium.org
█ reve...@chromium.org
afakhry@chromium.org
ovanieva@chromium.org
osh...@chromium.org
kylixrd@chromium.org
malaykeshav@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove the concept of UI scale from display

Project Member Reported by malaykeshav@chromium.org, Mar 20 2018 
With the implementation of Display zoom, we no longer require UI scale to simulate software resolutions for the internal display. The internal display no longer has different display modes and will only rely on display zoom to change the workspace size for the user.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ad9037cd524209b4a2b6505df84a120ec6b924f

commit 8ad9037cd524209b4a2b6505df84a120ec6b924f
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Wed Mar 21 22:35:22 2018

Move display zoom logic to ManagedDisplayInfo

This patch moves the display zoom state for a display from display
manager to the display's corresponding ManagedDisplayInfo.

Bug: 823922
Change-Id: Ib50e5d62102987900e80a1a866fc29f696e5482b
Component: ManagedDisplayInfo, Display Manager, Display Zoom
Reviewed-on: https://chromium-review.googlesource.com/972428
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544881}
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/chrome/browser/chromeos/display/display_prefs.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/ui/display/manager/display_manager.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/ui/display/manager/display_manager.h
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/ui/display/manager/managed_display_info.cc
[modify] https://crrev.com/8ad9037cd524209b4a2b6505df84a120ec6b924f/ui/display/manager/managed_display_info.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f9bdf495beb6a3ae6b0d7ace832bc39f92f5ad2

commit 0f9bdf495beb6a3ae6b0d7ace832bc39f92f5ad2
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Wed Mar 21 23:12:46 2018

Add check for the precision of display zoom value

Display preferences for chrome OS stores the display zoom value only
upto a precision of 2 decimal point.

This patch adds a check of precision to ensure that in the future if
any changes are made to the way display zoom values are generated then
those changes keep in mind this precision that is used by display prefs.

Bug: 823922
Change-Id: I8370415041bcaeac55c4afef9a4e4125979559b4
Component: Display Util Test
Reviewed-on: https://chromium-review.googlesource.com/974264
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544897}
[modify] https://crrev.com/0f9bdf495beb6a3ae6b0d7ace832bc39f92f5ad2/ui/display/manager/chromeos/display_utils_unittest.cc

Comment 3 Deleted

Comment 4 by craigtumblison@chromium.org, May 3 2018 

(Used the wrong account, sorry!)

Hey all,

It looks like this has started to land in M67 (beta channel) and is reseting the user's default preference instead of converting it from the old setting to the new setting.

Here's a bug with user feedback reports:
https://bugs.chromium.org/p/chromium/issues/detail?id=839458

Can you take a look?

Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07303144570844c24b93926d9c0ea40b1957c84e

commit 07303144570844c24b93926d9c0ea40b1957c84e
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Sat Jun 16 05:33:29 2018

Modify the string format to replace ui scale with zoom factor

This patch performs multiple tasks:
  - Modify the protocol that generates a ManagedDisplayInfo to use zoom
    factor instead of ui scale. When display zoom feature is disabled,
    it reverts back to the old string format.
  - Add a DCHECK in computing the effective Ui scale to ensure that it
    is 1 when display zoom is enabled.
  - Update all tests that fail due to this assertion. This is done
    mostly by creating a new test class with the display zoom feature
    disabled. OTOH, the tests that we want to keep in display zoom
    mode are modified to fit the assertion. We want to make sure that
    both ui scale and display zoom works for a few milestones before we
    completely deprecate and remove ui scale.

Bug: 823922
Change-Id: I9bab4f6cb0884242d5f9427ba004f4c677835b64
Component: Managed Display Info, ui scale, display zoom
Reviewed-on: https://chromium-review.googlesource.com/1099476
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567878}
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/cros_display_config_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/chrome/browser/extensions/system_display/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/testing/buildbot/filters/mash.ash_unittests.filter
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/display_manager.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/display_manager_utilities.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/managed_display_info.cc
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/managed_display_info.h
[modify] https://crrev.com/07303144570844c24b93926d9c0ea40b1957c84e/ui/display/manager/managed_display_info_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df4d7a28c3a81caca619021991e53fb6be3e1267

commit df4d7a28c3a81caca619021991e53fb6be3e1267
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Aug 15 04:26:53 2018

Remove kEnableDisplayZoomSetting feature flag

I'll remove ui_scale parameters in a separate CL.

Bug: 823922
Test: Removed/Updated unit tests. I kept a few tests
 which still makes sense.

Change-Id: Ia0a4b34a1fba02823dabec7ac91c73220740221f
Reviewed-on: https://chromium-review.googlesource.com/1175007
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583168}
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/accelerators/accelerator_commands.h
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/cros_display_config_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/display_prefs.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ash/wm/native_cursor_manager_ash_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/about_flags.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/components/exo/wayland/server.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/display_switches.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/display_switches.h
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/display_change_observer_unittest.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/display_manager.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/display_manager_utilities.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/managed_display_info.cc
[modify] https://crrev.com/df4d7a28c3a81caca619021991e53fb6be3e1267/ui/display/manager/managed_display_info_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06117e0f6f84eeae587753aa92df29b79640ab09

commit 06117e0f6f84eeae587753aa92df29b79640ab09
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 17 20:58:17 2018

Remove ui_scale parameters.

We now uses dsf for display zooming.

Notable changes:
* removed ui_scale_, effective_ui_scale parameters.
* ZoomInternalDisplay/ResetInternalDisplayZoom is now used
 only for UnifiedDesktop (we probably want to change this crbug.com/873828)
* ModeList for internal display now contains just one mode.
 I simplied the code for this cases.

I also left methods in ScreenManagerOzoneInternal because it's deprecated.

Bug: 823922
Test: Removed tests that are no longer necesary. Adjusted tests
 when they still make sense.

Change-Id: Ifca7d45bba15346bb1d0ae78faa150a57e1cb6e6
Reviewed-on: https://chromium-review.googlesource.com/1173726
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584184}
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/accelerators/accelerator_commands.h
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/cros_display_config.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/resolution_notification_controller_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/root_window_transformers.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/public/interfaces/cros_display_config.mojom
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/chrome/browser/extensions/system_display/display_info_provider_chromeos.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/chrome/browser/extensions/system_display/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/components/exo/pointer.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/components/exo/wm_helper.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/extensions/common/api/system_display.idl
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/services/ui/display/viewport_metrics.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/services/ui/display/viewport_metrics.h
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/services/ui/public/interfaces/window_manager_constants.mojom
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_change_observer.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_manager.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_manager.h
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_manager_utilities.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_manager_utilities.h
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/display_utils_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/managed_display_info.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/managed_display_info.h
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/managed_display_info_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/manager/touch_device_manager_unittest.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/test/display_manager_test_api.cc
[modify] https://crrev.com/06117e0f6f84eeae587753aa92df29b79640ab09/ui/display/test/display_manager_test_api.h
►

Sign in to add a comment