New issue
Advanced search Search tips

Issue 823909 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-X

Blocking:
issue 817419



Sign in to add a comment

interactive_ui_tests MacViews ConstrainedWindowViewTest Visibility Checks Fail with Animations

Project Member Reported by robliao@chromium.org, Mar 20 2018

Issue description

Tracking bug for disabling the animations. It's possible this may need to be the final state.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f29c539e990b1a737642c5cfa3d53b6e8d93ba8e

commit f29c539e990b1a737642c5cfa3d53b6e8d93ba8e
Author: Robert Liao <robliao@chromium.org>
Date: Wed Mar 21 16:41:47 2018

Disable Visibility Animations for interactive_ui_tests ConstrainedWindowViewTest

ConstrainedWindowViewTest.[TabMoveTest|ClosesOnEscape] are flaky on Mac
when animations are enabled.

BUG= 823909 

Change-Id: I53b5a042874e56aec0b2b82cc2e0d5a3a0e8a402
Reviewed-on: https://chromium-review.googlesource.com/972359
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544732}
[modify] https://crrev.com/f29c539e990b1a737642c5cfa3d53b6e8d93ba8e/chrome/browser/ui/views/constrained_window_views_browsertest.cc

Labels: MacViews-Tests
Labels: M-X

Comment 4 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: -Pri-1 Pri-2
This is a test only failure. Reassessing as P2.
Status: Assigned (was: Started)
Status: WontFix (was: Assigned)
Looking at the test, animations aren't critical for the functionality, so it's probably fine to keep this disabled.

If there are objections, feel free to reopen!

Sign in to add a comment