New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823895 link

Starred by 5 users

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

crash loop on m67 canary

Project Member Reported by osh...@chromium.org, Mar 20 2018

Issue description

m67 canary has been broken for a couple of days.
when I login, chrome keeps crashing.

P0 because canary is unusable.

I'll upload log and video.
 

Comment 1 by osh...@chromium.org, Mar 20 2018

video and ui logs:

https://drive.google.com/file/d/1GzPHT7uTWRlDIKvK3CnEeJ9MYkAAkM5O/view
ui.log.1
27.1 KB Download
ui.log.2
1.5 KB Download

Comment 2 by osh...@chromium.org, Mar 20 2018

chrome: 67.0.3376.0
platform: 10504.0.0-18-03-20)

Comment 3 by abodenha@google.com, Mar 20 2018

Are you able to get crash-id from the affected machine?

Comment 4 by osh...@chromium.org, Mar 20 2018

I only tested on test image. here are mini dumps


chrome.20180320.160223.4874.dmp
363 KB Download
chrome.20180320.132837.8268.dmp
432 KB Download

Comment 5 by osh...@chromium.org, Mar 21 2018

Labels: -Pri-0 Pri-1
This didn't happen with another account. Looks like this depends on app you have installed. Lowering to P1 although we still need to fix it. I hope we get crash reports soon from canary.

Comment 6 by osh...@chromium.org, Mar 21 2018

Cc: sky@chromium.org jamescook@chromium.org khmel@chromium.org yusukes@chromium.org
Owner: osh...@chromium.org
Status: Started (was: Untriaged)
Adding more (arc/mus)  folks in case they have an clue.

Actually that account didn't have ARC enabled, so it could be arc related. 
I could narrow the regression range down to 10492/67.0.3369.0(bad) - 10486/67.0.3366.3(good). I'll run bisect today.

Comment 7 by sky@chromium.org, Mar 21 2018

I don't think 67.0.3369.0 had mus enabled. If I'm reading things right 67.0.3369.0 is commit 66edfc19fe65cccd4e0bb80b5ba9ce1a0259e72e and https://chromium.googlesource.com/chromium/src/+/66edfc19fe65cccd4e0bb80b5ba9ce1a0259e72e/testing/variations/fieldtrial_testing_config.json doesn't have WindowService-ChromeOS .
Do you have a stack trace?

FYI for other people, dates on those builds:
2018-03-15 11:12	10492.0.0
2018-03-13 11:10	10486.0.0

Comment 9 by sky@chromium.org, Mar 21 2018

The log shows a bunch of errors, but I have no idea if those are expected or not.
Here is the regression range:
https://chromium.googlesource.com/chromium/src/+log/67.0.3366.3..67.0.3369.0?n=10000

I couldn't find anything suspicious about mus nor arc (yet). I'll update the bug later today.

Comment 11 by sky@chromium.org, Mar 21 2018

And to be clear, mus is NOT on in any canaries yet.
If you can ssh into the device you might be able to force crash uploads (even on test image) with:

metrics_client -C  # force metrics consent
# make crash_sender try to upload when running a test image
touch /run/crash_reporter/crash-test-in-progress
crash_sender -e FORCE_OFFICIAL=1 -e SECONDS_SEND_SPREAD=1
grep crash_sender /var/log/messages

Login works OK for me with 10506.0.0 / 67.0.3376.0 dev-channel eve test

Cc: jingwee@chromium.org wzang@chromium.org alemate@chromium.org jdufault@chromium.org songsuk@chromium.org ajha@chromium.org brajkumar@chromium.org osh...@chromium.org
 Issue 822661  has been merged into this issue.
Components: UI>Shell>Launcher
Owner: hejq@chromium.org
Status: Assigned (was: Started)

This is culprit:
https://chromium-review.googlesource.com/954355


0x0000571f75e15042	(chrome -ordinal.h:304 )	ChromeAppListModelUpdater::UpdateAppItemFromSyncItem(app_list::AppListSyncableService::SyncItem*, bool, bool)
0x0000571f75e0ff47	(chrome -app_list_syncable_service.cc:567 )	app_list::AppListSyncableService::ModelUpdaterDelegate::OnAppListItemAdded(ChromeAppListItem*)
0x0000571f75e15128	(chrome -chrome_app_list_model_updater.cc:481 )	ChromeAppListModelUpdater::OnFolderCreated(mojo::StructPtr<ash::mojom::AppListItemMetadata>)

This crash reports before and after

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_ChromeOS%27%20AND%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20product.Version%3D%2767.0.3369.0%27

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_ChromeOS%27%20AND%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20product.Version%3D%2767.0.3366.3%27


I confirmed on my device:
https://crash.corp.google.com/browse?stbtiq=b916676a393749a4

hejq@, can you look into this?
Cc: xiy...@chromium.org
+xiyuan

The codereview mentions the CL causing login crashes but says they are fixed.

Comment 16 by hejq@chromium.org, Mar 22 2018

Mergedinto: 824630
Status: Duplicate (was: Assigned)
I think it's same issue.
Status: Assigned (was: Duplicate)
The regression range had a few fixes, but wasn't probably eonugh.

Comment 18 by hejq@chromium.org, Mar 22 2018

I see. Let me quickly work on that issue first and check whether we have more.
Status: Duplicate (was: Assigned)
Sorry I didn't mean to change the status. If you think that's same (and probably is), please merge it back. 

Sign in to add a comment