New issue
Advanced search Search tips

Issue 823890 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Ephemeral profiles and force sign-in can result in no profiles showing up

Reported by da...@mhusd.org, Mar 20 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce the problem:
1. Turn on Ephemeral profiles. 
2. Turn on "Enables force sign in for Chrome users"
3. Start chrome 
4. Exit chrome
5. Start chrome again

What is the expected behavior?
At least one profile will be present

What went wrong?
No profiles will show up.

Did this work before? No 

Chrome version: 65.0.3325.162  Channel: stable
OS Version: 10.0
Flash Version: 

This can be confusing for end users, and can also end up locking you out from using chrome if you disable adding new profiles.
 
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue with chrome #65.0.3325.181 on GPO environment, as per steps mentioned in the comment #0

Observations:
1. After login into the chrome browser, there are 2 chrome icons appeared on the desktop
2. After closing the chrome session, the 2 chrome icons are disappeared from the desktop

Attaching the screen-cast for reference.

darej@ Could you please confirm the issue?
823890.mp4
7.1 MB View Download

Comment 2 by mad@chromium.org, Mar 21 2018

Owner: zmin@chromium.org
zmin@, can you take a look too?

Comment 3 by zmin@chromium.org, Mar 21 2018

Status: Started (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b052808737e66eb0f25c296b17ed24725a1002ac

commit b052808737e66eb0f25c296b17ed24725a1002ac
Author: Owen Min <zmin@chromium.org>
Date: Thu Mar 22 16:15:47 2018

Fix the conflict between ForceBrowserSignin and ForceEphemeralProfiles policy.

When Chrome clean up ephemeral profiles during launch, create a new profile
if all profiles are deleted and last used profile is guest profile.

Bug:  823890 
Change-Id: I64ff6b6230d73df9b97839b0d896fa56710b41e5
Reviewed-on: https://chromium-review.googlesource.com/974123
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545104}
[modify] https://crrev.com/b052808737e66eb0f25c296b17ed24725a1002ac/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/b052808737e66eb0f25c296b17ed24725a1002ac/chrome/browser/profiles/profile_manager_unittest.cc

Comment 5 by zmin@chromium.org, Mar 26 2018

This issue has been fixed in Chrome canary(67.0.3379.0). Please note that, for the Chrome that doesn't have any profile shown up, user need to manually create one by clicking "Add Person".

Comment 6 by zmin@chromium.org, Mar 26 2018

Labels: Merge-Request-66
This issue causing bad UX when both policies are enabled. I'd like to merge the patch into 66. The patch has also came with unit test.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 26 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 26 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a25e43b755bf2b552110eed3597ef98ee68adc5

commit 7a25e43b755bf2b552110eed3597ef98ee68adc5
Author: Owen Min <zmin@chromium.org>
Date: Mon Mar 26 18:05:49 2018

Merge "Fix the conflict between ForceBrowserSignin and ForceEphemeralProfiles policy."

When Chrome clean up ephemeral profiles during launch, create a new profile
if all profiles are deleted and last used profile is guest profile.

Bug:  823890 
Change-Id: I64ff6b6230d73df9b97839b0d896fa56710b41e5
Reviewed-on: https://chromium-review.googlesource.com/974123
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545104}(cherry picked from commit b052808737e66eb0f25c296b17ed24725a1002ac)
Reviewed-on: https://chromium-review.googlesource.com/980894
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#440}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/7a25e43b755bf2b552110eed3597ef98ee68adc5/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/7a25e43b755bf2b552110eed3597ef98ee68adc5/chrome/browser/profiles/profile_manager_unittest.cc

Comment 10 by zmin@chromium.org, Apr 3 2018

Status: Fixed (was: Started)

Sign in to add a comment