New issue
Advanced search Search tips

Issue 823882 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR



Sign in to add a comment

Improve VR Asset downloading

Project Member Reported by bsheedy@chromium.org, Mar 20 2018

Issue description

Currently, VR assets are downloaded during a gclient sync if checkout_src_internal is set in gclient. However, there are a number of cases where src_internal is available, but checkout_src_internal is not set, such as on some bots and on workstations with Clank checkouts.

We should tie the asset downloading more closely to src internal actually being present so that developers and bots can be certain they have the correct asset version without having to set anything.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b467300e0999d4263fb1bddea43a205be3347931

commit b467300e0999d4263fb1bddea43a205be3347931
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Mar 20 22:19:55 2018

Add two fixes to VR bisect script

Adds an option to the VR bisect script that allows each revision to be
run multiple times, and requires that each attempt during a revision be
good in order for the revision to be marked as good. This is to help
bisect flaky metrics that fluctuate between good/bad values.

Also forces the VR assets to be downloaded after syncing to ensure
that they are the correct version even if the user does not have
checkout_src_internal set in gclient.

Change-Id: Ic48e4402cb8669afd4097ef658b31b212fb1c483
Bug:  823882 
Reviewed-on: https://chromium-review.googlesource.com/971405
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544559}
[modify] https://crrev.com/b467300e0999d4263fb1bddea43a205be3347931/chrome/test/vr/auto_bisect.py

Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR
Would it be sufficient to just add it as a hook to src-internal/DEPS?
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/cd5702ead42806a52bb2a174ad4a34aa26028785

commit cd5702ead42806a52bb2a174ad4a34aa26028785
Author: Tibor Goldschwendt <tiborg@google.com>
Date: Thu Jan 10 18:11:58 2019

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02efec6f514a1f78fc14a7c4afc77e14fddab846

commit 02efec6f514a1f78fc14a7c4afc77e14fddab846
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Thu Jan 10 20:19:58 2019

Roll src-internal 29361b7bc9fc..5d0d8017656d (6 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29361b7bc9fc..5d0d8017656d


Created with:
  gclient setdep -r src-internal@5d0d8017656d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:823882 
TBR=mmoss@chromium.org

Change-Id: I5f50bfcf61baf05c75aab281d403045bcb046ded
Reviewed-on: https://chromium-review.googlesource.com/c/1405928
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621725}
[modify] https://crrev.com/02efec6f514a1f78fc14a7c4afc77e14fddab846/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11329ecb5c4891914d29b3166c97fa9d8d20d8ba

commit 11329ecb5c4891914d29b3166c97fa9d8d20d8ba
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Jan 10 21:49:53 2019

[vr] Move vr_assets hook to internal

Bug:  823882 
Change-Id: I4fbfffb482785b0ab7e32aec5e0214587c516bf6
Reviewed-on: https://chromium-review.googlesource.com/c/1404748
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621752}
[modify] https://crrev.com/11329ecb5c4891914d29b3166c97fa9d8d20d8ba/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment