Issue metadata
Sign in to add a comment
|
Print Preview -> Print With System Dialog broken |
||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3376.1, 66.0.3359.33, 65.0.3325.162 OS: Win10 What steps will reproduce the problem? (1) Navigate to chrome://version (or any page that generates a > 1 page preview) (2) Ctrl + P to bring up print preview (3) Click on "Print with System Dialog" link (4) Select XPS Document Writer (5) In system dialog, select some subset of pages (e.g. pg 1) and print What is the expected result? XPS document is created and can be opened to view printed page What happens instead? XPS document is not created. Okay on Stable 64. Everything works as expected if: (1) Page selection is done in Print Preview before opening system dialog (2) Print directly from system dialog or print preview, rather than the hybrid path (3) Entire document is printed via PP -> SD path
,
Mar 21 2018
,
Mar 21 2018
Working on a fix for this. Note that this is Windows only, as it is unique to the Windows Print Preview -> Print with System Dialog flow, which is different from other platforms.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/190d38b53a6294ca5ecb795e70520e585ed2128c commit 190d38b53a6294ca5ecb795e70520e585ed2128c Author: rbpotter <rbpotter@chromium.org> Date: Thu Mar 22 18:50:02 2018 Fix Print Preview to System dialog bug Update PrintJob::pdf_page_mapping_ so that PDF pages not in the user's selection are ignored instead of causing the print job to be cancelled. Also remove some comments that are significantly outdated, and caused confusion while investigating the bug. Bug: 823876 Change-Id: Id6c1c3acb67c4d460cffa937f7a9b87eda402a88 Reviewed-on: https://chromium-review.googlesource.com/974042 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545173} [modify] https://crrev.com/190d38b53a6294ca5ecb795e70520e585ed2128c/chrome/browser/printing/print_job.cc [modify] https://crrev.com/190d38b53a6294ca5ecb795e70520e585ed2128c/chrome/browser/printing/print_job.h [modify] https://crrev.com/190d38b53a6294ca5ecb795e70520e585ed2128c/chrome/browser/printing/print_job_worker.cc [modify] https://crrev.com/190d38b53a6294ca5ecb795e70520e585ed2128c/chrome/browser/printing/print_view_manager_base.cc
,
Mar 23 2018
Tested this issue on Windows 10 using chrome-67.0.3379.0 as per steps in C#0. Observed that .ops document got created & opened successfully after converting it into xps document on 67.0.3379.0 build.Seems issue got fixed on latest version hence adding TE Verified labels. Please find the attached screencast for reference. Thanks..!
,
Mar 23 2018
Requesting merge to M-66 since this is an M65 regression.
,
Mar 23 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dbec48e14762fdf6257a73c9e89bc1cf463bf51 commit 5dbec48e14762fdf6257a73c9e89bc1cf463bf51 Author: rbpotter <rbpotter@chromium.org> Date: Fri Mar 23 18:05:05 2018 PrintJob: Add unit test for ResetPageMapping(). Bug: 823876 Change-Id: I10b12d121becf8bda98f4200b18877e287e8ea7f Reviewed-on: https://chromium-review.googlesource.com/976808 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545516} [modify] https://crrev.com/5dbec48e14762fdf6257a73c9e89bc1cf463bf51/chrome/browser/printing/print_job.cc [modify] https://crrev.com/5dbec48e14762fdf6257a73c9e89bc1cf463bf51/chrome/browser/printing/print_job.h [modify] https://crrev.com/5dbec48e14762fdf6257a73c9e89bc1cf463bf51/chrome/browser/printing/print_job_unittest.cc
,
Mar 23 2018
Approving merge for M66. Branch:3359
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cbc3cf900a4d96d144b3e49b94faa91d4ef893b commit 6cbc3cf900a4d96d144b3e49b94faa91d4ef893b Author: rbpotter <rbpotter@chromium.org> Date: Mon Mar 26 14:37:48 2018 Fix Print Preview to System dialog bug Update PrintJob::pdf_page_mapping_ so that PDF pages not in the user's selection are ignored instead of causing the print job to be cancelled. Also remove some comments that are significantly outdated, and caused confusion while investigating the bug. Bug: 823876 Change-Id: Id6c1c3acb67c4d460cffa937f7a9b87eda402a88 Reviewed-on: https://chromium-review.googlesource.com/974042 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545173}(cherry picked from commit 190d38b53a6294ca5ecb795e70520e585ed2128c) TBR: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/980572 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#424} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/6cbc3cf900a4d96d144b3e49b94faa91d4ef893b/chrome/browser/printing/print_job.cc [modify] https://crrev.com/6cbc3cf900a4d96d144b3e49b94faa91d4ef893b/chrome/browser/printing/print_job.h [modify] https://crrev.com/6cbc3cf900a4d96d144b3e49b94faa91d4ef893b/chrome/browser/printing/print_job_worker.cc [modify] https://crrev.com/6cbc3cf900a4d96d144b3e49b94faa91d4ef893b/chrome/browser/printing/print_view_manager_base.cc
,
Mar 26 2018
,
Mar 28 2018
Tested this issue on Windows 10 using chrome-66.0.3359.66 as per steps provided in C#0. Observed that .ops document got created & opened successfully after converting it into .xps document on 66.0.3359.66 build. Seems that issue got fixed on latest version hence adding TE Verified labels. Please find the attached screencast for reference. Thanks! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rbpotter@chromium.org
, Mar 20 2018