Better support for OOPIF in DevTools memory.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/767b8edd9d170a1981ddc21d24e4fe52f67b5c47 commit 767b8edd9d170a1981ddc21d24e4fe52f67b5c47 Author: Alexei Filippov <alph@chromium.org> Date: Tue Mar 20 23:33:53 2018 [inspector] Add Runtime.getIsolateId & Runtime.getHeapUsage commands BUG= chromium:823874 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1df9347ead62dc84150f5549c29815600609c55b Reviewed-on: https://chromium-review.googlesource.com/972181 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52085} [modify] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/src/inspector/js_protocol.json [modify] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/src/inspector/js_protocol.pdl [modify] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/src/inspector/v8-runtime-agent-impl.cc [modify] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/src/inspector/v8-runtime-agent-impl.h [add] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/test/inspector/runtime/get-heap-usage-expected.txt [add] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/test/inspector/runtime/get-heap-usage.js [add] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/test/inspector/runtime/get-isolate-id-expected.txt [add] https://crrev.com/767b8edd9d170a1981ddc21d24e4fe52f67b5c47/test/inspector/runtime/get-isolate-id.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a commit a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a Author: Alexei Filippov <alph@chromium.org> Date: Wed Mar 21 20:22:11 2018 DevTools: Improve target selection on memory panel Group targets by isolate id. Show live heap size for each isolate. BUG= 823874 Change-Id: Ifbc9c51c30a06670f85eea1113a5a24686966658 Reviewed-on: https://chromium-review.googlesource.com/972153 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544823} [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/main/Main.js [add] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/profiler/IsolateSelector.js [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/profiler/module.json [add] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/profiler/profileLauncherView.css [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css [modify] https://crrev.com/a8f1bf8df6644b1fc825f50cccd9986d5ae20e7a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ed75605befc48d4ad2d67fa95523f1b04b79ff1 commit 5ed75605befc48d4ad2d67fa95523f1b04b79ff1 Author: Alexei Filippov <alph@chromium.org> Date: Thu Mar 22 23:16:08 2018 DevTools: Memory panel: show each target on a separate line BUG= 823874 Change-Id: I1f9da1393a20e0783519796d1f9c02cecbb4e2ad Reviewed-on: https://chromium-review.googlesource.com/974472 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#545283} [modify] https://crrev.com/5ed75605befc48d4ad2d67fa95523f1b04b79ff1/third_party/WebKit/Source/devtools/front_end/profiler/IsolateSelector.js [modify] https://crrev.com/5ed75605befc48d4ad2d67fa95523f1b04b79ff1/third_party/WebKit/Source/devtools/front_end/profiler/profileLauncherView.css
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/49f06fb59fb9945c31ff81443ab06a11b52a429e commit 49f06fb59fb9945c31ff81443ab06a11b52a429e Author: Alexei Filippov <alph@chromium.org> Date: Thu Mar 29 17:25:51 2018 [inspector] Use random generator for isolate id We cannot rely on base::OS::GetCurrentProcessId() as it is sandboxed. BUG= chromium:823874 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6aaa7f7f7dacbc8aba43581f9d489e4cc47799ff Reviewed-on: https://chromium-review.googlesource.com/985425 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#52303} [modify] https://crrev.com/49f06fb59fb9945c31ff81443ab06a11b52a429e/src/inspector/v8-inspector-impl.cc [modify] https://crrev.com/49f06fb59fb9945c31ff81443ab06a11b52a429e/src/inspector/v8-inspector-impl.h [modify] https://crrev.com/49f06fb59fb9945c31ff81443ab06a11b52a429e/src/inspector/v8-runtime-agent-impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e1b46d22b26fb7259a0a82772b4f21fe77843e0 commit 8e1b46d22b26fb7259a0a82772b4f21fe77843e0 Author: Alexei Filippov <alph@chromium.org> Date: Sat Mar 31 01:51:32 2018 DevTools: Move memory panel isolate selector out of experiment. BUG= 823874 Change-Id: Ib433aaf4bd56eef002861c0ea1a77f442283b5b6 Reviewed-on: https://chromium-review.googlesource.com/985248 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547358} [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-stopped-removed-race.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-profiler-profiling.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/Source/devtools/front_end/heap_profiler_test_runner/HeapProfilerTestRunner.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js [delete] https://crrev.com/24a7b027828631e79d71ca1a8edfe0fa1aa1ce7a/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js [modify] https://crrev.com/8e1b46d22b26fb7259a0a82772b4f21fe77843e0/third_party/WebKit/Source/devtools/front_end/profiler/module.json
Thanks! FYI, looks like r547358 was in 67.0.3386.
Yes, the last patch was landed a while ago.
Issue 778798 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Mar 20 2018