New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 49 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocked on: View detail
issue 404525
issue 462957
issue 515604
issue 569340
issue 598772
issue 617318
issue 623209
issue 636111
issue 659765
issue 666152
issue 672115
issue 693709
issue 700381
issue 703383
issue 703765
issue 716193
issue 752872
issue 753169
issue 757114
issue 767451
issue 772003
issue 772117
issue 774674
issue 782027
issue angleproject:736
issue 342069
issue 343960
issue 363676
issue 377008
issue 390990
issue 391347
issue 395405
issue 395843
issue 397585
issue 403594
issue 406957
issue 408313
issue 409105
issue 409399
issue 412902
issue 413266
issue 413478
issue 413727
issue 416269
issue 416747
issue 420328
issue 429498
issue 429752
issue 430101
issue 437916
issue 438382
issue 439761
issue 441052
issue 441053
issue 444904
issue 445406
issue 446368
issue 446374
issue 448935
issue 451078
issue 451290
issue 451454
issue 452694
issue 453691
issue 454118
issue 454590
issue 455488
issue 455966
issue 457003
issue 457078
issue 458266
issue 458545
issue 459797
issue 460381
issue 463906
issue 463926
issue 465015
issue 466627
issue 466752
issue 467287
issue 467925
issue 467927
issue 467928
issue 467929
issue 469813
issue 470689
issue 471868
issue 473978
issue 475643
issue 475768
issue 476316
issue 476317
issue 477476
issue 477986
issue 477988
issue 477994
issue 478419
issue 479328
issue 480015
issue 480091
issue 480546
issue 481029
issue 482292
issue 482294
issue 482703
issue 483065
issue 483367
issue 484903
issue 487346
issue 488156
issue 488634
issue 491209
issue 492283
issue 494442
issue 495396
issue 495773
issue 496928
issue 496975
issue 497826
issue 498033
issue 498276
issue 498544
issue 499336
issue 499673
issue 500934
issue 501367
issue 503684
issue 503687
issue 504017
issue 504657
issue 505888
issue 505916
issue 506038
issue 506446
issue 506453
issue 507826
issue 508948
issue 508955
issue 509161
issue 509256
issue 510555
issue 511837
issue 514512
issue 518191
issue 518204
issue 520982
issue 520986
issue 521298
issue 521652
issue 521788
issue 522165
issue 522804
issue 524308
issue 524604
issue 525131
issue 525897
issue 526741
issue 530785
issue 531802
issue 533183
issue 534665
issue 536726
issue 536963
issue 540897
issue 543182
issue 544127
issue 547142
issue 548295
issue 548348
issue 549765
issue 552241
issue 552909
issue 556735
issue 557968
issue 560836
issue 560972
issue 562308
issue 564691
issue 565700
issue 566751
issue 567205
issue 567877
issue 568610
issue 568781
issue 569633
issue 569964
issue 570775
issue 571497
issue 572237
issue 574490
issue 575700
issue 576773
issue 576774
issue 576842
issue 577620
issue 580241
issue 581845
issue 582570
issue 583674
issue 583676
issue 586243
issue 586511
issue 586525
issue 586590
issue 586714
issue 587530
issue 587835
issue 587843
issue 588518
issue 589977
issue 590086
issue 590221
issue 591437
issue 592745
issue 594360
issue 594361
issue 595050
issue 595702
issue 596201
issue 596366
issue 597549
issue 598316
issue 598344
issue 598761
issue 598767
issue 598807
issue 598849
issue 598943
issue 600157
issue 600775
issue 602265
issue 603935
issue 604034
issue 605570
issue 606810
issue 607197
issue 608705
issue 608901
issue 610367
issue 615437
issue 616152
issue 618440
issue 618511
issue 621087
issue 621999
issue 622339
issue 622923
issue 623099
issue 624523
issue 625175
issue 626336
issue 626477
issue 627273
issue 629141
issue 633277
issue 633629
issue 637456
issue 639853
issue 640000
issue 642027
issue 642351
issue 644768
issue 644841
issue 645544
issue 646451
issue 659219
issue 666994
issue 667891
issue 668203
issue 668207
issue 668212
issue 668748
issue 671663
issue 675018
issue 680947
issue 681800
issue 682500
issue 682754
issue 689666
issue 690271
issue 691286
issue 691714
issue 692255
issue 692561
issue 692564
issue 693713
issue 693717
issue 693718
issue 694670
issue 695101
issue 695584
issue 698841
issue 698848
issue 706552
issue 708769
issue 709690
issue 714609
issue 715315
issue 717207
issue 722880
issue 727193
issue 727447
issue 727458
issue 727463
issue 727488
issue 727490
issue 728324
issue 729334
issue 746971
issue v8:6626
issue 750446
issue 750447
issue 750703
issue 750923
issue 751220
issue 751225
issue 751634
issue 752057
issue 752168
issue 754277
issue 755611
issue 755863
issue 756555
issue 757042
issue 761859
issue 772002
issue 775174
issue 777579
issue 777642
issue 777924
issue 777943
issue 780056
issue 780124
issue 805894

Blocking:
issue 429328
issue 792131
issue 109558
issue 109559
issue 345874



Sign in to add a comment

Deploy Clang on windows

Project Member Reported by thakis@chromium.org, May 12 2011 Back to list

Issue description

clang's -fms-extensions support has improved dramatically. We should look into how viable building chrome on windows is with clang.
 
Showing comments 351 - 850 of 850 Older
Project Member

Comment 351 by bugdroid1@chromium.org, Nov 26 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/092983ab37029417aa4ecc800e27ebcc05c909b5

commit 092983ab37029417aa4ecc800e27ebcc05c909b5
Author: Nico Weber <thakis@chromium.org>
Date: Wed Nov 26 18:15:01 2014

Remove build-time warning from pe_image.cc

This warning has been printed for over 1.5 years on every 64-bit build. Things
like this make people blind to warnings.

The code does look questionable on 64-bit, and the tests for this code are
apparently disabled for 64-bit too. This should be looked at (see bug), but
a warning on every build is not how this will happen.

BUG=167707,82385
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/725293009

Cr-Commit-Position: refs/heads/master@{#305834}

[modify] http://crrev.com/092983ab37029417aa4ecc800e27ebcc05c909b5/base/win/pe_image.cc

Project Member

Comment 352 by bugdroid1@chromium.org, Nov 26 2014

------------------------------------------------------------------
r293130 | thakis@chromium.org | 2014-11-26T19:09:26.251877Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/patches/nspr-no-pointers-in-longs.patch?r1=293130&r2=293129&pathrev=293130
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/nspr/pr/src/threads/combined/pruthr.c?r1=293130&r2=293129&pathrev=293130
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/README.chromium?r1=293130&r2=293129&pathrev=293130

Win64: Fix a pointer truncation bug in nspr.

Found by this clang warning:

..\..\third_party\nss\nspr\pr\src\threads\combined\pruthr.c(82,23) :  warning(clang): cast to 'char *' from smaller integer type 'long' [-Wint-to-pointer-cast]
    stack->stackTop = (char*) ((((long)&type + _pr_pageSize - 1)
                      ^
..\..\third_party\nss\nspr\pr\src\threads\combined\pruthr.c(182,25) :  warning(clang): cast to 'char *' from smaller integer type 'long' [-Wint-to-pointer-cast]
        ts->allocBase = (char*) ((((long)&ts + _pr_pageSize - 1)
                        ^
2 warnings generated.

I don't know if this code path is hit in practice.

BUG=82385
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/757333003
-----------------------------------------------------------------
Project Member

Comment 353 by bugdroid1@chromium.org, Nov 26 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711e0bc408a3123e457006dfb5476da93a3dc592

commit 711e0bc408a3123e457006dfb5476da93a3dc592
Author: Nico Weber <thakis@chromium.org>
Date: Wed Nov 26 20:29:25 2014

Roll nss.

Brings in https://codereview.chromium.org/757333003/ , a fix for not storing
a pointer (which can be 64-bit) in a long (which is always 32-bit on Windows).

BUG=82385
R=scottmg@chromium.org
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/757703005

Cr-Commit-Position: refs/heads/master@{#305868}

[modify] http://crrev.com/711e0bc408a3123e457006dfb5476da93a3dc592/DEPS

Blockedon: chromium:437916
Project Member

Comment 355 by bugdroid1@chromium.org, Dec 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/643c24eb95e702dc0a59d26dd57d21c7e3ae3611

commit 643c24eb95e702dc0a59d26dd57d21c7e3ae3611
Author: thakis <thakis@chromium.org>
Date: Tue Dec 02 05:23:09 2014

Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode.

Also, remove V8_CC_CLANG since it's not read anywhere (and ideally shouldn't
be).

Clang tries to be compatible with gcc in clang mode, and with msvc in clang-cl
mode. It wants to go down the same code paths that these compilers want to go
down in most cases.

For example, V8PRIxPTR was set incorrectly on Windows 64-bit before this change
since macros.h assumed that checking for V8_CC_MSVC is enough to find LLP64
systems, but V8_CC_MSVC wasn't set for clang.  Most other existing checks for
V8_CC_MSVC should be taken for clang-cl too (and for the remaining ones,
clang-cl is happy with either code path).

Likewise, V8_IMMEDIATE_CRASH is currently set to a suboptimal value with clang
since __builtin_trap() is only used if V8_CC_GNU is set.

Including clang in the gcc and cl macros is also what chromium does.

BUG=chromium:82385
LOG=y

Review URL: https://codereview.chromium.org/757553004

Cr-Commit-Position: refs/heads/master@{#25592}

[modify] http://crrev.com/643c24eb95e702dc0a59d26dd57d21c7e3ae3611/include/v8config.h

Blockedon: chromium:438382
Blockedon: chromium:439761
Blockedon: chromium:441052
Blockedon: chromium:441053
Blocking: chromium:440579
Blocking: -chromium:440579
Blockedon: chromium:440579
Project Member

Comment 363 by bugdroid1@chromium.org, Dec 23 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34fead5eae3de03b4b63acbdbe8491f75e353232

commit 34fead5eae3de03b4b63acbdbe8491f75e353232
Author: thakis <thakis@chromium.org>
Date: Tue Dec 23 02:50:12 2014

Be explicit about not wanting a trigraph.

Both cl.exe and clang-cl don't use trigraphs on Windows by default, but
clang still warns about them.  Since the standard does include trigraphs,
fix the code to not (accidentally) include a trigraph rather than siliencing
the warning.

BUG=82385

Review URL: https://codereview.chromium.org/822813003

Cr-Commit-Position: refs/heads/master@{#309526}

[modify] http://crrev.com/34fead5eae3de03b4b63acbdbe8491f75e353232/sandbox/win/src/win_utils_unittest.cc

Blockedon: chromium:444904
Blockedon: chromium:445406
Blockedon: chromium:446368
Blockedon: chromium:446374
Blockedon: chromium:448935
Project Member

Comment 369 by bugdroid1@chromium.org, Jan 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b712af8a5f27641efdb337e58390ceefe4cd07de

commit b712af8a5f27641efdb337e58390ceefe4cd07de
Author: wfh <wfh@chromium.org>
Date: Sun Jan 18 06:54:30 2015

clang/win: Fix a few warnings/errors.

Add throw() declarations to fix clang compile errors and match the declarations in the MS SDK.

This is a followup to https://codereview.chromium.org/447513002

Also, cfree is deprecated and certainly isn't available on Windows, so removing the code.

BUG=82385

Review URL: https://codereview.chromium.org/827013006

Cr-Commit-Position: refs/heads/master@{#312048}

[modify] http://crrev.com/b712af8a5f27641efdb337e58390ceefe4cd07de/base/allocator/generic_allocators.cc

Comment 370 by h...@chromium.org, Jan 22 2015

Blockedon: chromium:451078
Blockedon: chromium:451290
Blockedon: chromium:451454
Blockedon: -chromium:440579
Project Member

Comment 374 by bugdroid1@chromium.org, Jan 27 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=189052

------------------------------------------------------------------
r189052 | thakis@chromium.org | 2015-01-27T19:44:20.461657Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGScriptElement.h?r1=189052&r2=189051&pathrev=189052
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/AudioDSPKernelProcessor.cpp?r1=189052&r2=189051&pathrev=189052
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement.cpp?r1=189052&r2=189051&pathrev=189052
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/audio/AudioDSPKernelProcessor.h?r1=189052&r2=189051&pathrev=189052
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGScriptElement.cpp?r1=189052&r2=189051&pathrev=189052
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement.h?r1=189052&r2=189051&pathrev=189052

Revert of Add explicit destructors to DOM classes containing smart pointers to incomplete types (patchset #2 id:20001 of https://codereview.chromium.org/412483007/)

Reason for revert:
This should no longer be necessary; clang should be able to handle this now. Reverting this to test that theory.

Original issue's description:
> Add explicit destructors to DOM classes containing smart pointers to incomplete types
> 
> Clang on Windows tries to declare the implicit virtual destructor of
> these classes so that it can diagnose mismatched exceptions
> specifications. This ends up requiring that the type of the smart
> pointer be complete, which it is not. This codepath does not fire on
> non-Windows platforms due to the Itanium C++ ABI key function
> optimization.
> 
> It is possible to fix Clang to avoid performing semantic analysis of the
> destructor when it only needs to compute the exception specification,
> but it is prohibitively difficult.  http://llvm.org/PR20337
> 
> Another possible fix on the Blink side would be to make the smart
> pointer type complete by including the relevant header, which has the
> cost of increasing transitive header bloat. Instead, simply define the
> destructor out of line. This is also a minor object file size
> optimization, as now the destructor is only emitted once.
> 
> R=thakis@chromium.org
> BUG=82385
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178838

TBR=rnk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/878273002
-----------------------------------------------------------------
Blockedon: chromium:452694
Blockedon: chromium:453691
Blockedon: chromium:454118
Blockedon: chromium:454590
Blockedon: chromium:455488
Blockedon: chromium:455966
Blockedon: chromium:457003
Blockedon: chromium:457078
Blockedon: chromium:458266
Project Member

Comment 384 by bugdroid1@chromium.org, Feb 12 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a249805f376e40174998be288ed64c6463d69000

commit a249805f376e40174998be288ed64c6463d69000
Author: thakis <thakis@chromium.org>
Date: Thu Feb 12 23:34:18 2015

Delete some tests from allocator_unittests.

The atomics and "die on OOM" bits are tested elsewhere.
The motivation is that this is the only file in all of Chromium that uses
`try` / `catch`.  Originally I wanted to remove just that bit, but when I tried
to compile the file I noticed that the target doesn't exist in most configs,
and the bots don't run the test, so I think the whole thing can go.

Note that no bots run this test. It's only compiled on Windows, and only
in static library builds, and only when building `all` (which means no devs
build it either). http://crbug.com/458309 tracks moving the tests that remain
in this file (which are useful) into base_unittests.

BUG=82385

Review URL: https://codereview.chromium.org/922863002

Cr-Commit-Position: refs/heads/master@{#316084}

[modify] http://crrev.com/a249805f376e40174998be288ed64c6463d69000/base/allocator/allocator_unittest.cc

Project Member

Comment 385 by bugdroid1@chromium.org, Feb 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e66594551c7bbeda37cb640314d24429387ae3b

commit 5e66594551c7bbeda37cb640314d24429387ae3b
Author: Nico Weber <thakis@chromium.org>
Date: Fri Feb 13 02:56:55 2015

clang/win: For 64-bit builds, enable warnings-as-errors and stop falling back to CL.

Clang can now build all of chrome's translation units in 64-bit.  Remove
/fallback so that the bot will turn red if this regresses.

Also turn on warnings-as-errors, so that warnings also turn the build red
(instead of just causing a fallback as before).

Also remove a superfluous 'RuntimeTypeInfo': 'false': This is already the
default for non-clang builds too.  (And for the few places where we do need
RTTI -- icu -- clang has been able to emit it for months now.)

BUG=82385
R=hans@chromium.org

Review URL: https://codereview.chromium.org/921633004

Cr-Commit-Position: refs/heads/master@{#316141}

[modify] http://crrev.com/5e66594551c7bbeda37cb640314d24429387ae3b/build/common.gypi

Blockedon: chromium:458545
Project Member

Comment 387 by bugdroid1@chromium.org, Feb 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/546fd7573148f233d37a2609931e70789d741786

commit 546fd7573148f233d37a2609931e70789d741786
Author: Nico Weber <thakis@chromium.org>
Date: Fri Feb 13 20:32:13 2015

clang/win: Fix compile error.

Const member variables must be set in constructors.

BUG=82385
TBR=perkj

Review URL: https://codereview.chromium.org/917183003

Cr-Commit-Position: refs/heads/master@{#316281}

[modify] http://crrev.com/546fd7573148f233d37a2609931e70789d741786/media/video/capture/win/capability_list_win.h

Project Member

Comment 388 by bugdroid1@chromium.org, Feb 13 2015

------------------------------------------------------------------
r294066 | thakis@chromium.org | 2015-02-13T20:57:57.310891Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.fyi/slaves.cfg?r1=294066&r2=294065&pathrev=294066

Reshuffle clang/win slaves.

Swap the slaves used by CrWinClang(shared) and CrWinClang64(dbg).  This way,
all 64-bit bots share a slave, which means that some 64-bit config is compiling
at all times.  Since the 64-bit bots build without fallback, this reduces the
window from the 64-bit breaking and us learning about it.

BUG=82385

Review URL: https://codereview.chromium.org/927663002
-----------------------------------------------------------------
Blockedon: chromium:459797
Blockedon: chromium:460381
Blockedon: chromium:462957
Blockedon: chromium:463906
Blockedon: chromium:463926
Blockedon: chromium:465015
Blockedon: chromium:466627
Blockedon: chromium:466752
Blockedon: chromium:467287
Blockedon: chromium:467925
Blockedon: chromium:467927
Blockedon: chromium:467928
Blockedon: chromium:467929
Project Member

Comment 402 by bugdroid1@chromium.org, Mar 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/920d194ed55addc327674dad9b415c90fb38b73b

commit 920d194ed55addc327674dad9b415c90fb38b73b
Author: thakis <thakis@chromium.org>
Date: Thu Mar 19 21:22:35 2015

clang/win: Don't disable warnings-as-errors for 3rd-party libs.

Not needed: On 32-bit builds, warnings-as-errors are disabled globally. On
64-bit builds, nothing warns, including 3rd-party code.

BUG=82385

Review URL: https://codereview.chromium.org/1011383007

Cr-Commit-Position: refs/heads/master@{#321433}

[modify] http://crrev.com/920d194ed55addc327674dad9b415c90fb38b73b/build/common.gypi

Project Member

Comment 403 by bugdroid1@chromium.org, Mar 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e28e5618dfc74f02bb7d26b1fbe02c22f26e3ef2

commit e28e5618dfc74f02bb7d26b1fbe02c22f26e3ef2
Author: Nico Weber <thakis@chromium.org>
Date: Sun Mar 22 04:52:46 2015

clang/win: Attempt to fix component build after #321658.

BUG=82385
NOTRY=true
R=hans@chromium.org

Review URL: https://codereview.chromium.org/1027693006

Cr-Commit-Position: refs/heads/master@{#321703}

[modify] http://crrev.com/e28e5618dfc74f02bb7d26b1fbe02c22f26e3ef2/base/profiler/stack_sampling_profiler.h

Blockedon: chromium:469813
Project Member

Comment 405 by bugdroid1@chromium.org, Mar 23 2015

Project: angle/angle
Branch : master
Author : Nico Weber <thakis@chromium.org>
Commit : 7e8320d88e3c392cade416d341bfe94a4249045e

Code-Review  0 : Nico Weber
Code-Review  +2: Jamie Madill
Verified     0 : Jamie Madill
Verified     +1: Nico Weber
Commit Queue   : Chumped
Change-Id      : I49a4120b15670d876613b22ba709d50bf4685006
Reviewed-at    : https://chromium-review.googlesource.com/261965

Make angle perftests build with clang.

::testing::WithParamInterface ends up calling deleting an object
with the type of the template parameter, and the pointer it deletes
could arguably point to a subclass of the param object -- so clang
warns that there's a delete on a class with a virtual method but
without a virtual dtor.  Make the param classes final to let the
compiler know that this can't happen in practice.

BUG=chromium:82385

src/tests/perf_tests/BufferSubData.cpp
src/tests/perf_tests/PointSprites.cpp
src/tests/perf_tests/TexSubImage.cpp
Project Member

Comment 406 by bugdroid1@chromium.org, Mar 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ad42c488a5a9f848294a306a517c94b39ffd8a

commit a1ad42c488a5a9f848294a306a517c94b39ffd8a
Author: jmadill <jmadill@chromium.org>
Date: Tue Mar 24 18:55:12 2015

Roll ANGLE bdd419f9f..3cd438d1.

https://chromium.googlesource.com/angle/angle/+log/bdd419f9f..3cd438d1

BUG=82385
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1034533002

Cr-Commit-Position: refs/heads/master@{#322036}

[modify] http://crrev.com/a1ad42c488a5a9f848294a306a517c94b39ffd8a/DEPS

Blockedon: chromium:470689
Blockedon: chromium:471868

Comment 409 Deleted

Comment 410 Deleted

Blockedon: chromium:473978
Project Member

Comment 412 by bugdroid1@chromium.org, Apr 6 2015

Project  : angle/angle
Branch   : master
Author   : Nico Weber <thakis@chromium.org>
Committer: Geoff Lang <geofflang@chromium.org>
Commit   : 51a1db16d7c7ea92686a16ee324f7fc0687ad095

Code-Review  0 : Jamie Madill, Nico Weber
Code-Review  +2: Geoff Lang
Verified     0 : Jamie Madill, Nico Weber
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I69033b1802b5dffbdf2d80889aca7019d710d481
Reviewed-at    : https://chromium-review.googlesource.com/264061

Give Timer a virtual destructor as it's deleted polymorphically.

Found by clang:

..\..\third_party\angle\src\common/angleutils.h(66,5) :  error: delete called on 'Timer' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete resource;
    ^
..\..\third_party\angle\src\tests\perf_tests\ANGLEPerfTest.cpp(26,5) :  note: in instantiation of function template specialization 'SafeDelete<Timer>' requested here
    SafeDelete(mTimer);
    ^

BUG=chromium:82385

util/Timer.h
Project Member

Comment 413 by bugdroid1@chromium.org, Apr 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c70479c70d1861d629f2657c0e459b2d3da7b8c

commit 6c70479c70d1861d629f2657c0e459b2d3da7b8c
Author: thakis <thakis@chromium.org>
Date: Mon Apr 06 19:51:25 2015

Roll ANGLE 99f075dad..51a1db16d.

https://chromium.googlesource.com/angle/angle/+log/99f075dad..51a1db16d

BUG=82385
TBR=geofflang@chromium.org

Review URL: https://codereview.chromium.org/1060583004

Cr-Commit-Position: refs/heads/master@{#323935}

[modify] http://crrev.com/6c70479c70d1861d629f2657c0e459b2d3da7b8c/DEPS

Blockedon: chromium:475643
Blockedon: chromium:475768
Blockedon: chromium:476316
Blockedon: chromium:476317
Blockedon: chromium:477476
Blockedon: chromium:477986
Blockedon: chromium:477988
Blockedon: chromium:477994
Blockedon: chromium:478419
Blockedon: chromium:479328
Blockedon: chromium:480015
Project Member

Comment 425 by bugdroid1@chromium.org, Apr 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1862ffcb911a6f8126b886057119300a8197035b

commit 1862ffcb911a6f8126b886057119300a8197035b
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Apr 22 22:58:57 2015

Fix printf format specifier when printing FilePath

Caught by Clang on Windows.

BUG=82385
R=dalecurtis@chromium.org
TBR=phoglund
NOTRY=true

Review URL: https://codereview.chromium.org/1088763003

Cr-Commit-Position: refs/heads/master@{#326386}

[modify] http://crrev.com/1862ffcb911a6f8126b886057119300a8197035b/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc

Project Member

Comment 426 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=194256

------------------------------------------------------------------
r194256 | thakis@chromium.org | 2015-04-23T02:57:32.724578Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/wtf/Assertions.h?r1=194256&r2=194255&pathrev=194256

Keep result of IMMEDIATE_CRASH void after r194230.

Fixes compile errors like

..\..\third_party\WebKit\Source\wtf/text/StringConcatenate.h(168,9) : error: right operand to ? is void, but left operand is of type 'volatile char'
        RELEASE_ASSERT(false);
        ^~~~~~~~~~~~~~~~~~~~~

on systems where __builtin_trap isn't available.

BUG=82385
TBR=hiroshige

Review URL: https://codereview.chromium.org/1072273008
-----------------------------------------------------------------
Blockedon: chromium:480091
Blockedon: chromium:480546
Project Member

Comment 429 by bugdroid1@chromium.org, Apr 23 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=194314

------------------------------------------------------------------
r194314 | thakis@chromium.org | 2015-04-23T18:32:34.563086Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/shaping/HarfBuzzShaper.h?r1=194314&r2=194313&pathrev=194314

clang/win: Attempt to fix component build after r194273.

We're seeing this error on the clang/win bots:

blink_platform_unittests.HarfBuzzShaperTest.obj :
error LNK2019: unresolved external symbol
"public: __thiscall blink::HarfBuzzShaper::HarfBuzzRun::~HarfBuzzRun(void)"
(??1HarfBuzzRun@HarfBuzzShaper@blink@@QAE@XZ) referenced in function
"private: virtual void __thiscall `anonymous namespace'::HarfBuzzShaperTest_ResolveCandidateRunsLatin_Test::TestBody(void)"
(?TestBody@HarfBuzzShaperTest_ResolveCandidateRunsLatin_Test@?A@@EAEXXZ)

We used to think that cl.exe (MSVC's compiler) doesn't apply __dllexport on
an outer class to inner classes (and continue to do so), but it's not clear
to me why this builds with cl.exe but doesn't with clang-cl.exe.  We'll have
to investigate, but for now this will get our component build bots back to
green.  (Similar to https://codereview.chromium.org/1027693006/, also see
discussion there.)

BUG=82385
R=hans@chromium.org
TBR=eae

Review URL: https://codereview.chromium.org/1058613007
-----------------------------------------------------------------
Blockedon: chromium:481029
Blockedon: chromium:482292
Blockedon: chromium:482294
Blockedon: chromium:482703

Comment 434 by h...@chromium.org, Apr 30 2015

Blockedon: chromium:483065
Blockedon: chromium:483367
Blockedon: chromium:484903
Blockedon: chromium:487346
Blockedon: chromium:488156
Blockedon: chromium:488634
Blockedon: chromium:491209
Blockedon: chromium:492283
Blockedon: chromium:494442
Blockedon: chromium:495773
Blockedon: chromium:495396
Cc: -timurrrr@chromium.org
Blockedon: chromium:496928
Blockedon: chromium:496975
Project Member

Comment 448 by bugdroid1@chromium.org, Jun 5 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb9d67e7b77484c4fa2a653c0f89b60cc3f894de

commit bb9d67e7b77484c4fa2a653c0f89b60cc3f894de
Author: thakis <thakis@chromium.org>
Date: Fri Jun 05 17:54:16 2015

clang/win/gn: Pass -msse flags to clang-cl.exe for skia

This is a port of https://codereview.chromium.org/475273002 to gn.

Also add a comment that explains that the skia_opts target in the GN build
isn't correct.

BUG=491209,82385,496512

Review URL: https://codereview.chromium.org/1155243010

Cr-Commit-Position: refs/heads/master@{#333091}

[modify] http://crrev.com/bb9d67e7b77484c4fa2a653c0f89b60cc3f894de/skia/BUILD.gn

Blockedon: chromium:497826
Blockedon: chromium:498033
Blockedon: chromium:498276
Blockedon: chromium:498544
Project Member

Comment 453 by bugdroid1@chromium.org, Jun 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4a2e23d70045832b3ffc12095cab4a89cd629e

commit ec4a2e23d70045832b3ffc12095cab4a89cd629e
Author: scottmg <scottmg@chromium.org>
Date: Wed Jun 10 02:22:52 2015

Set -fmsc-version appropriately for clang on VS2015

Mostly turns on char16_t and char32_t to not error out immediately.

R=thakis@chromium.org
BUG=82385,440500,498544

Review URL: https://codereview.chromium.org/1172903002

Cr-Commit-Position: refs/heads/master@{#333657}

[modify] http://crrev.com/ec4a2e23d70045832b3ffc12095cab4a89cd629e/build/common.gypi
[modify] http://crrev.com/ec4a2e23d70045832b3ffc12095cab4a89cd629e/build/config/compiler/BUILD.gn

Project Member

Comment 454 by bugdroid1@chromium.org, Jun 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4248771f4f3482c059dff8248de585c733b8b69f

commit 4248771f4f3482c059dff8248de585c733b8b69f
Author: hans <hans@chromium.org>
Date: Wed Jun 10 20:28:41 2015

Try to fix the Win-Clang gn build

Builds were failing with:

  ERROR at //build/config/compiler/BUILD.gn:116:11: Undefined identifier
        if (visual_studio_version == "2013") {
            ^--------------------

BUG=82385, 440500

Review URL: https://codereview.chromium.org/1178603002

Cr-Commit-Position: refs/heads/master@{#333787}

[modify] http://crrev.com/4248771f4f3482c059dff8248de585c733b8b69f/build/config/compiler/BUILD.gn

Blockedon: chromium:499336
Blockedon: chromium:499673
Project Member

Comment 457 by bugdroid1@chromium.org, Jun 12 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8cce88bf27fe0bb4614c401d7c5bdbf193c587f

commit b8cce88bf27fe0bb4614c401d7c5bdbf193c587f
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Jun 12 23:42:55 2015

Roll Win-Clang 238562:239639

This picks up several fixes related to dllexport on explicit
instantiation definitions, and name lookup in dependent base
classes.

BUG=82385, 492283
TBR=thakis

Review URL: https://codereview.chromium.org/1182953002.

Cr-Commit-Position: refs/heads/master@{#334283}

[modify] http://crrev.com/b8cce88bf27fe0bb4614c401d7c5bdbf193c587f/tools/clang/scripts/package.py
[modify] http://crrev.com/b8cce88bf27fe0bb4614c401d7c5bdbf193c587f/tools/clang/scripts/update.py

Project Member

Comment 458 by bugdroid1@chromium.org, Jun 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e76e7926ee51bdfdd635437920f455ae6444912

commit 4e76e7926ee51bdfdd635437920f455ae6444912
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Jun 13 03:32:45 2015

Build: Don't pass /GL to Clang on Windows

Windows Clang's support for LTO isn't ready to take on Chrome yet.

BUG=82385
R=thakis@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/1186743002.

Cr-Commit-Position: refs/heads/master@{#334321}

[modify] http://crrev.com/4e76e7926ee51bdfdd635437920f455ae6444912/build/common.gypi
[modify] http://crrev.com/4e76e7926ee51bdfdd635437920f455ae6444912/build/config/compiler/BUILD.gn

Project Member

Comment 459 by bugdroid1@chromium.org, Jun 15 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec6a579b7e47f84b384b98b6f04ee65beb55758

commit 7ec6a579b7e47f84b384b98b6f04ee65beb55758
Author: thakis <thakis@chromium.org>
Date: Mon Jun 15 18:26:59 2015

Revert of Build: Don't pass /GL to Clang on Windows (patchset #3 id:40001 of https://codereview.chromium.org/1186743002/)

Reason for revert:
Broke some official builds (http://crbug.com/500393). Will roll clang forward instead.

Original issue's description:
> Build: Don't pass /GL to Clang on Windows
>
> Windows Clang's support for LTO isn't ready to take on Chrome yet.
>
> BUG=82385
> R=thakis@chromium.org
> TBR=scottmg
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4e76e7926ee51bdfdd635437920f455ae6444912

TBR=scottmg@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/1185133004

Cr-Commit-Position: refs/heads/master@{#334419}

[modify] http://crrev.com/7ec6a579b7e47f84b384b98b6f04ee65beb55758/build/common.gypi
[modify] http://crrev.com/7ec6a579b7e47f84b384b98b6f04ee65beb55758/build/config/compiler/BUILD.gn

Blockedon: chromium:500934
Blockedon: chromium:501367
Project Member

Comment 462 by bugdroid1@chromium.org, Jun 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2490eae99cb38140e27dcb3e89fb21385a84f676

commit 2490eae99cb38140e27dcb3e89fb21385a84f676
Author: thakis <thakis@chromium.org>
Date: Thu Jun 18 05:21:30 2015

clang/win: Fix component build after https://codereview.chromium.org/1149383004/

The compiler may choose to inline ServiceWorkerVersionInfo's assignment
operator in clients.  The assignment operator needs to assign ClientInfo
objects in the clients map<>, which can call ~ClientInfo().  So ClientInfo needs
to be exported, as it can be referenced from outside content this way.

BUG=82385,466871
TBR=hans,horo

Review URL: https://codereview.chromium.org/1192653002

Cr-Commit-Position: refs/heads/master@{#334995}

[modify] http://crrev.com/2490eae99cb38140e27dcb3e89fb21385a84f676/content/browser/service_worker/service_worker_info.h

Project Member

Comment 463 by bugdroid1@chromium.org, Jun 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59fc7718fefd2c93e1acd94c4d5a405949a0cf10

commit 59fc7718fefd2c93e1acd94c4d5a405949a0cf10
Author: thakis <thakis@chromium.org>
Date: Fri Jun 19 23:43:34 2015

clang/win: Make diagnostics colored if ansicon is around at runhooks time.

BUG=82385
TEST=Run gyp or gn with ansicon active, build. Diagnostics should be colored
in cmd.exe.

Review URL: https://codereview.chromium.org/1194823004

Cr-Commit-Position: refs/heads/master@{#335394}

[modify] http://crrev.com/59fc7718fefd2c93e1acd94c4d5a405949a0cf10/build/common.gypi
[modify] http://crrev.com/59fc7718fefd2c93e1acd94c4d5a405949a0cf10/build/config/compiler/BUILD.gn
[add] http://crrev.com/59fc7718fefd2c93e1acd94c4d5a405949a0cf10/build/win/use_ansi_codes.py

Blockedon: chromium:503684
Blockedon: chromium:503687
Project Member

Comment 467 by bugdroid1@chromium.org, Jun 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c

commit 4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c
Author: scottmg <scottmg@chromium.org>
Date: Tue Jun 23 20:50:38 2015

Revert of Fix incorrect libxml fprintf, erroring on clang win x64 (patchset #1 id:1 of https://codereview.chromium.org/1204813002/)

Reason for revert:
Broke cast android whatever that is. http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/1035

Original issue's description:
> Fix incorrect libxml fprintf, erroring on clang win x64
>
> R=thakis@chromium.org
> BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410
> BUG=82385
>
> Committed: https://crrev.com/73a2484753cd6b2e4af673cd6dc752ba5b00c116
> Cr-Commit-Position: refs/heads/master@{#335736}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410

Review URL: https://codereview.chromium.org/1202303002

Cr-Commit-Position: refs/heads/master@{#335743}

[modify] http://crrev.com/4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c/third_party/libxml/README.chromium
[modify] http://crrev.com/4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c/third_party/libxml/src/timsort.h

Project Member

Comment 468 by bugdroid1@chromium.org, Jun 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d31995076e55f1aac2f935c53b585a90ece27a11

commit d31995076e55f1aac2f935c53b585a90ece27a11
Author: scottmg <scottmg@chromium.org>
Date: Wed Jun 24 01:25:26 2015

Another attempt at fixing incorrect libxml fprintf, affecting clang win x64

Previous attempt https://codereview.chromium.org/1204813002.

R=thakis@chromium.org
BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410
BUG=82385

Review URL: https://codereview.chromium.org/1207553002

Cr-Commit-Position: refs/heads/master@{#335844}

[modify] http://crrev.com/d31995076e55f1aac2f935c53b585a90ece27a11/third_party/libxml/src/timsort.h

Blockedon: chromium:504017
Blockedon: chromium:504657
Project Member

Comment 471 by bugdroid1@chromium.org, Jun 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ad0cfd95a0e90bcfb817168cade7bd1143ada4

commit e0ad0cfd95a0e90bcfb817168cade7bd1143ada4
Author: thakis <thakis@chromium.org>
Date: Fri Jun 26 19:00:02 2015

clang/win: Don't pass -Wno-inconsistent-missing-override twice.

It's already passed unconditionally everywhere if clang is used, there's
no need to pass it again for clang/win.

BUG=82385,428099

Review URL: https://codereview.chromium.org/1208363002

Cr-Commit-Position: refs/heads/master@{#336431}

[modify] http://crrev.com/e0ad0cfd95a0e90bcfb817168cade7bd1143ada4/build/common.gypi
[modify] http://crrev.com/e0ad0cfd95a0e90bcfb817168cade7bd1143ada4/build/config/compiler/BUILD.gn

Blockedon: chromium:505888
Blockedon: chromium:505916
Blockedon: chromium:506038
Blockedon: chromium:506446
Blockedon: chromium:506453
Blockedon: chromium:507826
Blockedon: chromium:508948
Blockedon: chromium:508955
Blockedon: chromium:509161
Blockedon: chromium:509256
Project Member

Comment 482 by bugdroid1@chromium.org, Jul 15 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2776ee378ee7d309d5d837e1e4405460403556ff

commit 2776ee378ee7d309d5d837e1e4405460403556ff
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jul 15 15:01:29 2015

win/clang: Roll clang 239674:242130

32-bit SEH, member pointers with virtual bases, inttypes.h warning fix...

BUG=509256,82385
R=hans@chromium.org

Review URL: https://codereview.chromium.org/1234713002 .

Cr-Commit-Position: refs/heads/master@{#338860}

[modify] http://crrev.com/2776ee378ee7d309d5d837e1e4405460403556ff/build/common.gypi
[modify] http://crrev.com/2776ee378ee7d309d5d837e1e4405460403556ff/build/config/compiler/BUILD.gn
[modify] http://crrev.com/2776ee378ee7d309d5d837e1e4405460403556ff/tools/clang/scripts/update.py

Blockedon: chromium:510555
Project Member

Comment 484 by bugdroid1@chromium.org, Jul 15 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586

commit c17fbc86ef53cb21dc03cfab09d12be3e1cb1586
Author: thakis <thakis@chromium.org>
Date: Wed Jul 15 19:45:45 2015

Revert of win/clang: Roll clang 239674:242130 (patchset #3 id:40001 of https://codereview.chromium.org/1234713002/)

Reason for revert:
Looks like this caused http://crbug.com/510555

Original issue's description:
> win/clang: Roll clang 239674:242130
>
> 32-bit SEH, member pointers with virtual bases, inttypes.h warning fix...
>
> BUG=509256,82385
> R=hans@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2776ee378ee7d309d5d837e1e4405460403556ff

TBR=hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509256,82385

Review URL: https://codereview.chromium.org/1240813002

Cr-Commit-Position: refs/heads/master@{#338891}

[modify] http://crrev.com/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586/build/common.gypi
[modify] http://crrev.com/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586/build/config/compiler/BUILD.gn
[modify] http://crrev.com/c17fbc86ef53cb21dc03cfab09d12be3e1cb1586/tools/clang/scripts/update.py

Project Member

Comment 485 by bugdroid1@chromium.org, Jul 15 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/13ecc48d1200084cc32b6f01acb5fcc82f14b1bd

commit 13ecc48d1200084cc32b6f01acb5fcc82f14b1bd
Author: thakis@chromium.org <thakis@chromium.org>
Date: Wed Jul 15 20:12:10 2015

Make the static clang/win ToT bots do official builds.

That makes them match the regular win/clang bots.

(It means we lose waterfall coverage for unofficial static library builds,
but coverage from unofficial component builders hopefully gives us most of
that.)

BUG=82385
TBR=akuegel

Review URL: https://codereview.chromium.org/1241913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@296026 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/13ecc48d1200084cc32b6f01acb5fcc82f14b1bd/scripts/slave/recipe_modules/chromium/config.py
[modify] http://crrev.com/13ecc48d1200084cc32b6f01acb5fcc82f14b1bd/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] http://crrev.com/13ecc48d1200084cc32b6f01acb5fcc82f14b1bd/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json
[modify] http://crrev.com/13ecc48d1200084cc32b6f01acb5fcc82f14b1bd/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json

Project Member

Comment 486 by bugdroid1@chromium.org, Jul 15 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/be4419e74b8386067ea02c6432f798eaec1ad821

commit be4419e74b8386067ea02c6432f798eaec1ad821
Author: thakis@chromium.org <thakis@chromium.org>
Date: Wed Jul 15 20:52:10 2015

Revert of Make the static clang/win ToT bots do official builds. (patchset #1 id:1 of https://codereview.chromium.org/1241913003/)

Reason for revert:
Looks like the bot doesn't have a src-internal checkout and this isn't enough to give it one. Reverting until src-internalness is figured out.

Original issue's description:
> Make the static clang/win ToT bots do official builds.
> 
> That makes them match the regular win/clang bots.
> 
> (It means we lose waterfall coverage for unofficial static library builds,
> but coverage from unofficial component builders hopefully gives us most of
> that.)
> 
> BUG=82385
> TBR=akuegel
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296026

TBR=hans@chromium.org,rnk@chromium.org,akuegel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/1238993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@296028 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/be4419e74b8386067ea02c6432f798eaec1ad821/scripts/slave/recipe_modules/chromium/config.py
[modify] http://crrev.com/be4419e74b8386067ea02c6432f798eaec1ad821/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] http://crrev.com/be4419e74b8386067ea02c6432f798eaec1ad821/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json
[modify] http://crrev.com/be4419e74b8386067ea02c6432f798eaec1ad821/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json

Project Member

Comment 487 by bugdroid1@chromium.org, Jul 16 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4b943ccc3cede127db38d008539e8fa239db86fd

commit 4b943ccc3cede127db38d008539e8fa239db86fd
Author: thakis@chromium.org <thakis@chromium.org>
Date: Thu Jul 16 02:32:27 2015

Make the static clang/win ToT bots do official builds.

That makes them match the regular win/clang bots.

(It means we lose waterfall coverage for unofficial static library builds,
but coverage from unofficial component builders hopefully gives us most of
that.)

BUG=82385
TBR=akuegel

Review URL: https://codereview.chromium.org/1241913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@296036 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/4b943ccc3cede127db38d008539e8fa239db86fd/scripts/slave/recipe_modules/chromium/config.py
[modify] http://crrev.com/4b943ccc3cede127db38d008539e8fa239db86fd/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] http://crrev.com/4b943ccc3cede127db38d008539e8fa239db86fd/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json
[modify] http://crrev.com/4b943ccc3cede127db38d008539e8fa239db86fd/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json

Project Member

Comment 489 by bugdroid1@chromium.org, Jul 17 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d0897658e728ea186c057ec414d53176913b2f

commit b5d0897658e728ea186c057ec414d53176913b2f
Author: rnk <rnk@chromium.org>
Date: Thu Jul 16 23:59:55 2015

Remove /fallback flag from 32-bit clang-cl invocations and enable -Werror

Clang can now compile all of Chromium in 32-bit as well as 64-bit without warnings.

R=thakis@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/1235033008

Cr-Commit-Position: refs/heads/master@{#339178}

[modify] http://crrev.com/b5d0897658e728ea186c057ec414d53176913b2f/build/common.gypi
[modify] http://crrev.com/b5d0897658e728ea186c057ec414d53176913b2f/build/config/compiler/BUILD.gn

Project Member

Comment 490 by bugdroid1@chromium.org, Jul 17 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d32d89e5081223fab2982dc97252fd5150e721

commit 28d32d89e5081223fab2982dc97252fd5150e721
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jul 17 20:02:52 2015

clang/win: Add back /fallback for asan builds for now.

In asan builds, a few translation units still fall back to CL, see
http://llvm.org/PR24167

Also update the gn files to pass /WX (warnings-as-errors) in 32-bit non-asan
clang builds.

BUG=82385
TBR=rnk

Review URL: https://codereview.chromium.org/1229083005.

Cr-Commit-Position: refs/heads/master@{#339309}

[modify] http://crrev.com/28d32d89e5081223fab2982dc97252fd5150e721/build/common.gypi
[modify] http://crrev.com/28d32d89e5081223fab2982dc97252fd5150e721/build/config/compiler/BUILD.gn

Blockedon: chromium:511837
Project Member

Comment 492 by bugdroid1@chromium.org, Jul 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14bfe39c883b7b082deecd182f28b10af56f9d3c

commit 14bfe39c883b7b082deecd182f28b10af56f9d3c
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jul 22 02:37:28 2015

clang/win: Fix build after https://codereview.chromium.org/1248543002/

Fixes:
..\..\media\audio\win\audio_device_listener_win_unittest.cc(24,19) : error:
unused variable 'kNoDevice' [-Werror,-Wunused-const-variable]
static const char kNoDevice[] = "";
                  ^
No intended behavior change.

BUG=506712,82385
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/1250933002.

Cr-Commit-Position: refs/heads/master@{#339820}

[modify] http://crrev.com/14bfe39c883b7b082deecd182f28b10af56f9d3c/media/audio/win/audio_device_listener_win_unittest.cc

Project Member

Comment 493 by bugdroid1@chromium.org, Jul 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa9d4fad367939eb0ac68b86914c6d86339da3c

commit 0fa9d4fad367939eb0ac68b86914c6d86339da3c
Author: thakis <thakis@chromium.org>
Date: Mon Jul 27 19:43:46 2015

clang/win/asan: Remove /fallback and enable warnings-as-errors.

This removes the last case where we still needed /fallback.

BUG=82385

Review URL: https://codereview.chromium.org/1259813002

Cr-Commit-Position: refs/heads/master@{#340533}

[modify] http://crrev.com/0fa9d4fad367939eb0ac68b86914c6d86339da3c/build/common.gypi
[modify] http://crrev.com/0fa9d4fad367939eb0ac68b86914c6d86339da3c/build/config/compiler/BUILD.gn

Blockedon: chromium:514512
Project Member

Comment 495 by bugdroid1@chromium.org, Jul 28 2015

Project Member

Comment 496 by bugdroid1@chromium.org, Jul 28 2015

Project Member

Comment 497 by bugdroid1@chromium.org, Jul 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e2ad0af670ec59055b16f37918059e68d34d2007

commit e2ad0af670ec59055b16f37918059e68d34d2007
Author: thakis@chromium.org <thakis@chromium.org>
Date: Thu Jul 30 18:09:25 2015

Fix LLD64 bot config.

https://codereview.chromium.org/1257683007/ forgot to add the new scheduler
to the scheduler list, resulting in "no scheduler: cr_win_clang_lld64"
errors.

BUG=82385

Review URL: https://codereview.chromium.org/1253233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@296172 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/e2ad0af670ec59055b16f37918059e68d34d2007/masters/master.chromium.fyi/master.cfg

Blockedon: chromium:515604
Project Member

Comment 499 by bugdroid1@chromium.org, Aug 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c900e6e00f63108f144cf0435097c7d953c04ff

commit 7c900e6e00f63108f144cf0435097c7d953c04ff
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 06 22:10:50 2015

Roll pdfium to 905cc10ecd.

https://codereview.chromium.org/1259123005 broke the clang/win bots thusly:

..\..\third_party\pdfium\core\src\fxge\ge\fx_ge_fontmap.cpp(456,7) :
error: field 'm_pFontInfo' will be initialized after field
'm_bListLoaded' [-Werror,-Wreorder]
    : m_pFontInfo(nullptr),
      ^

905cc10 fixed this, so roll pdfium forward in the hope of fixing the clang/win
bots.

905cc10  Add CFX_FontFaceInfo constructor.
2526930  Early object closing in PDF via premature 'endobj' keyword
8d8a990  Remove the unused IFX_StreamRead::SetRange() mechanism.
2b91781  CPDF_Parser shouldnt be in the business of opening files
5cd3985  FPDF_Creator can only create file through embedder-supplied callback.

BUG=82385,493126
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1274263005 .

Cr-Commit-Position: refs/heads/master@{#342212}

[modify] http://crrev.com/7c900e6e00f63108f144cf0435097c7d953c04ff/DEPS

Project Member

Comment 500 by bugdroid1@chromium.org, Aug 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf282f824bbcc867bbd22415f751490bfc55a848

commit cf282f824bbcc867bbd22415f751490bfc55a848
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 07 04:48:27 2015

clang/win: Attempt to fix bots after https://codereview.chromium.org/1275833002

Should fix:
..\..\chrome\browser\media\encrypted_media_browsertest.cc(42,12) :
    error: unused variable 'kExternalClearKeyDecryptOnlyKeySystem'
           [-Werror,-Wunused-const-variable]
const char kExternalClearKeyDecryptOnlyKeySystem[] =
           ^
BUG=82385
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1280893002.

Cr-Commit-Position: refs/heads/master@{#342285}

[modify] http://crrev.com/cf282f824bbcc867bbd22415f751490bfc55a848/chrome/browser/media/encrypted_media_browsertest.cc

Blockedon: chromium:518191
Blockedon: chromium:518204
Project Member

Comment 503 by bugdroid1@chromium.org, Aug 12 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49bac10701d666cd09a9a636ed599ece997fe330

commit 49bac10701d666cd09a9a636ed599ece997fe330
Author: hans <hans@chromium.org>
Date: Wed Aug 12 21:24:05 2015

Address Win/Clang style plugin error in hwnd_message_handler.h

This should fix the error below, and also make the code adhere to the comment
in the header: "The WeakPtrFactories below must occur last" :-)

In file included from ..\..\ui\views\win\hwnd_message_handler.cc:5:
..\..\ui/views/win/hwnd_message_handler.h(594,44) :  error: [chromium-style]
WeakPtrFactory members which refer to their outer class must be the last member
in the outer class definition.
  base::WeakPtrFactory<HWNDMessageHandler> autohide_factory_;
                                           ^

BUG=82385
TBR=sky

Review URL: https://codereview.chromium.org/1286273002

Cr-Commit-Position: refs/heads/master@{#343096}

[modify] http://crrev.com/49bac10701d666cd09a9a636ed599ece997fe330/ui/views/win/hwnd_message_handler.h

Blocking: chromium:520982
Blockedon: chromium:520982
Blockedon: chromium:520986
Blocking: -chromium:520982
Blockedon: chromium:521298
Blockedon: chromium:521652
Blockedon: chromium:521788
Blockedon: chromium:522165
Project Member

Comment 512 by bugdroid1@chromium.org, Aug 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/204f0a762771bccf7f7d5e8858c0baa1b78733f3

commit 204f0a762771bccf7f7d5e8858c0baa1b78733f3
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 19 15:56:23 2015

clang/win: Fix component builds after https://codereview.chromium.org/1272113002

BUG=82385,516971
TBR=tyoshino

Review URL: https://codereview.chromium.org/1287263007 .

Cr-Commit-Position: refs/heads/master@{#344237}

[modify] http://crrev.com/204f0a762771bccf7f7d5e8858c0baa1b78733f3/url/url_util.h

Blockedon: chromium:522804
Project Member

Comment 514 by bugdroid1@chromium.org, Aug 20 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca3862cb26d8708d31f82ca6c91399c328afa6b

commit 2ca3862cb26d8708d31f82ca6c91399c328afa6b
Author: hans <hans@chromium.org>
Date: Thu Aug 20 16:14:37 2015

Don't try to dllexport InkDropAnimationControllerStub

It's in an anonymous namespace, so it cannot be exported, and this causes
an error on the Win-Clang bots:

..\..\ui\views\animation\ink_drop_animation_controller_factory.cc(20,20) :
  error: 'views::(anonymous namespace)::InkDropAnimationControllerStub'
  must have external linkage when declared 'dllexport'

  class VIEWS_EXPORT InkDropAnimationControllerStub
                     ^

I'm pretty sure this class was never intended to be exported.

BUG=82385
TBR=bruthig,sadrul

Review URL: https://codereview.chromium.org/1302913002

Cr-Commit-Position: refs/heads/master@{#344511}

[modify] http://crrev.com/2ca3862cb26d8708d31f82ca6c91399c328afa6b/ui/views/animation/ink_drop_animation_controller_factory.cc

Project Member

Comment 515 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d0864694d7fbc16b0db8b4c454666fb08cd8f1

commit 90d0864694d7fbc16b0db8b4c454666fb08cd8f1
Author: Nico Weber <thakis@chromium.org>
Date: Mon Aug 24 03:33:12 2015

Fix style checker errors after https://codereview.chromium.org/1263403002/

Functions marked 'override' should not be marked 'virtual' also.

BUG=82385,516402
TBR=wittman

Review URL: https://codereview.chromium.org/1313543002 .

Cr-Commit-Position: refs/heads/master@{#345021}

[modify] http://crrev.com/90d0864694d7fbc16b0db8b4c454666fb08cd8f1/base/profiler/win32_stack_frame_unwinder.h

Project Member

Comment 516 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02

commit ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Aug 24 17:59:38 2015

Fix Clang style-plugin errors in memory_pressure component

From http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/2796/steps/compile/logs/stdio:

..\..\components/memory_pressure/filtered_memory_pressure_calculator.h(31,3) :
error: [chromium-style] Complex destructor has an inline body.
  ~FilteredMemoryPressureCalculator() {}
  ^
..\..\components/memory_pressure/filtered_memory_pressure_calculator.h(31,39) :
error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  ~FilteredMemoryPressureCalculator() {}
                                      ^
                                       override
..\..\components/memory_pressure/direct_memory_pressure_calculator.h(41,45) :
error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~DirectMemoryPressureCalculator() {}
                                            ^
                                             override

BUG=82385, 520962
TBR=chrisha

Review URL: https://codereview.chromium.org/1314553003 .

Cr-Commit-Position: refs/heads/master@{#345121}

[modify] http://crrev.com/ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02/components/memory_pressure/direct_memory_pressure_calculator.h
[modify] http://crrev.com/ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02/components/memory_pressure/filtered_memory_pressure_calculator.cc
[modify] http://crrev.com/ea3ec1ea7c1ad2ac50f54f50a14b644904f7df02/components/memory_pressure/filtered_memory_pressure_calculator.h

Project Member

Comment 517 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd14e4671f08bb253f9cf81300eee4277196a28b

commit fd14e4671f08bb253f9cf81300eee4277196a28b
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Aug 24 19:47:09 2015

direct_memory_pressure_calculator.h: remove 'virtual'

I messed this up in https://codereview.chromium.org/1314553003

BUG=82385, 520962
TBR=chrisha

Review URL: https://codereview.chromium.org/1312893002 .

Cr-Commit-Position: refs/heads/master@{#345152}

[modify] http://crrev.com/fd14e4671f08bb253f9cf81300eee4277196a28b/components/memory_pressure/direct_memory_pressure_calculator.h

Project Member

Comment 518 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fccff3faca71ad785bad9c8eea0e0419a198a0b

commit 4fccff3faca71ad785bad9c8eea0e0419a198a0b
Author: hans <hans@chromium.org>
Date: Mon Aug 24 23:08:42 2015

One more memory_pressure style fix

BUG=82385, 520962
TBR=chrisha
NOTRY=true

Review URL: https://codereview.chromium.org/1311743005

Cr-Commit-Position: refs/heads/master@{#345199}

[modify] http://crrev.com/4fccff3faca71ad785bad9c8eea0e0419a198a0b/components/memory_pressure/test_memory_pressure_calculator.h

Project Member

Comment 519 by bugdroid1@chromium.org, Aug 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8ca12b69aa89fa781998764c19504967810237

commit ad8ca12b69aa89fa781998764c19504967810237
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Aug 24 23:12:50 2015

Mojo Mutex: fix declspec and GNU attribute order

Clang can't parse this:

   class __declspec(dllexport) __attribute__((lockable)) Mutex { };

the attribute and declspec have to come in the other order.

BUG=82385
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1310423002 .

Cr-Commit-Position: refs/heads/master@{#345202}

[modify] http://crrev.com/ad8ca12b69aa89fa781998764c19504967810237/third_party/mojo/src/mojo/edk/system/mutex.h

Blockedon: chromium:524308
Blockedon: chromium:524604
Project Member

Comment 522 by bugdroid1@chromium.org, Aug 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7926aeca384a139803d5b9a0f7c886d9b95563e2

commit 7926aeca384a139803d5b9a0f7c886d9b95563e2
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 25 22:30:08 2015

Fix clang/win build after https://codereview.chromium.org/1284053004/

The change removed a function, but not its declaration, angering
-Wunused-function.

BUG=345845,82385
TBR=charliea

Review URL: https://codereview.chromium.org/1312313002 .

Cr-Commit-Position: refs/heads/master@{#345460}

[modify] http://crrev.com/7926aeca384a139803d5b9a0f7c886d9b95563e2/base/time/time_win.cc

Comment 523 by h...@chromium.org, Aug 26 2015

Blockedon: chromium:525131
Project Member

Comment 524 by bugdroid1@chromium.org, Aug 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/external/mojo.git/+/edad3cdc473a9afc29e3b73ccc926f24e91f4b10

commit edad3cdc473a9afc29e3b73ccc926f24e91f4b10
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Aug 27 22:31:12 2015

Fix declspec and GNU attribute order

Clang fails at parsing

  clsas __declspec(dllexport) __attribute__((lockable)) Mutex {};

but it can parse when attribute and declspec are swapped.

BUG=82385
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/1317933004 .

[modify] http://crrev.com/edad3cdc473a9afc29e3b73ccc926f24e91f4b10/mojo/edk/system/mutex.h

Blockedon: chromium:525897
Blockedon: chromium:526741
Project Member

Comment 527 by bugdroid1@chromium.org, Sep 4 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17572a3c8ba9cc987d69fbd8a461fe621a89c83

commit f17572a3c8ba9cc987d69fbd8a461fe621a89c83
Author: hans <hans@chromium.org>
Date: Fri Sep 04 15:49:31 2015

SkTraceMemoryDump_Chrome: fix -Wreorder warning

Clang on Windows (is this file only built on Windows?) was failing with:

  ..\..\skia\ext\SkTraceMemoryDump_chrome.cc(25,7) :
error: field 'dump_name_prefix_' will be initialized after field 'process_memory_dump_' [-Werror,-Wreorder]
      : dump_name_prefix_(dump_name_prefix),
        ^

BUG=82385
TBR=ssid

Review URL: https://codereview.chromium.org/1318823012

Cr-Commit-Position: refs/heads/master@{#347414}

[modify] http://crrev.com/f17572a3c8ba9cc987d69fbd8a461fe621a89c83/skia/ext/SkTraceMemoryDump_chrome.h

Project Member

Comment 528 by bugdroid1@chromium.org, Sep 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8ed85742313f6a3b7db1d81277e01c3f5d23bf7

commit d8ed85742313f6a3b7db1d81277e01c3f5d23bf7
Author: Nico Weber <thakis@chromium.org>
Date: Mon Sep 07 16:34:11 2015

win/clang: Try to fix build after https://codereview.chromium.org/1243293003

chrome\browser\safe_browsing\incident_reporting\platform_state_store.cc(139,11):
      error: enumeration value 'NUM_RESULTS' not handled in switch
             [-Werror,-Wswitch]
  switch (result) {
          ^

BUG=82385,496744
TBR=grt

Review URL: https://codereview.chromium.org/1320093003 .

Cr-Commit-Position: refs/heads/master@{#347637}

[modify] http://crrev.com/d8ed85742313f6a3b7db1d81277e01c3f5d23bf7/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

Project Member

Comment 529 by bugdroid1@chromium.org, Sep 11 2015

Labels: merge-merged-2501
The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=78379

------------------------------------------------------------------
r78379 | thakis@google.com | 2015-09-11T19:34:11.474021Z

-----------------------------------------------------------------
Project Member

Comment 530 by bugdroid1@chromium.org, Sep 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf276242dd0cd58b3e538015f1c18c1e18ff4bab

commit bf276242dd0cd58b3e538015f1c18c1e18ff4bab
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 11 19:34:28 2015

win: Enable clang on Canary branch 2501.

This change does two things:
1. It sets the gyp variable "clang%" to 1 by default on Windows, letting the
   build use clang.
2. It changes DEPS to download the clang compiler unconditionally.
   (DEPS in src isn't used in release branches; the CL that actually does this
   is https://chromereviews.googleplex.com/252237013/)

With these changes, the canary builder should download clang and then use it
to build chrome/win on the 2501 branch without any bot config changes.
The intent is to try to release one canary built with clang to find any issues
this might have.

BUG=82385

Review URL: https://codereview.chromium.org/1334423002 .

Cr-Commit-Position: refs/branch-heads/2501@{#4}
Cr-Branched-From: e35c4f7b0579cb239c9229f9a0878d5355a3d3f4-refs/heads/master@{#347299}

[modify] http://crrev.com/bf276242dd0cd58b3e538015f1c18c1e18ff4bab/DEPS
[modify] http://crrev.com/bf276242dd0cd58b3e538015f1c18c1e18ff4bab/build/common.gypi

Blockedon: chromium:530785
Blockedon: chromium:531802
Blockedon: chromium:533183
Project Member

Comment 534 by bugdroid1@chromium.org, Sep 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b4647fa61f5ffbfac96a5ba508aabc5cba8787

commit a0b4647fa61f5ffbfac96a5ba508aabc5cba8787
Author: Nico Weber <thakis@chromium.org>
Date: Sat Sep 19 04:38:17 2015

Fix clang/win build after https://codereview.chromium.org/1348363003

kRescheduleTimeOutDelay is no longer used after that change, causing a
compiler warning.

BUG=514813,82385
TBR=sunnyps@chromium.org

Review URL: https://codereview.chromium.org/1352003003 .

Cr-Commit-Position: refs/heads/master@{#349848}

[modify] http://crrev.com/a0b4647fa61f5ffbfac96a5ba508aabc5cba8787/gpu/command_buffer/service/gpu_scheduler.cc

Project Member

Comment 535 by bugdroid1@chromium.org, Sep 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc8254be282454c26a228545fca479e3b257daaa

commit fc8254be282454c26a228545fca479e3b257daaa
Author: thakis <thakis@chromium.org>
Date: Mon Sep 21 15:35:26 2015

clang packager/win: Check that GnuWin32 is in the path at the start.

It's needed to run tests, and I prefer getting an error message
immediately over getting one 17 minutes in, when the build is done
and tests start running.

BUG=82385

Review URL: https://codereview.chromium.org/1351143006

Cr-Commit-Position: refs/heads/master@{#349932}

[modify] http://crrev.com/fc8254be282454c26a228545fca479e3b257daaa/tools/clang/scripts/package.py

Blockedon: chromium:534665
Project Member

Comment 537 by bugdroid1@chromium.org, Sep 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b4647fa61f5ffbfac96a5ba508aabc5cba8787

commit a0b4647fa61f5ffbfac96a5ba508aabc5cba8787
Author: Nico Weber <thakis@chromium.org>
Date: Sat Sep 19 04:38:17 2015

Fix clang/win build after https://codereview.chromium.org/1348363003

kRescheduleTimeOutDelay is no longer used after that change, causing a
compiler warning.

BUG=514813,82385
TBR=sunnyps@chromium.org

Review URL: https://codereview.chromium.org/1352003003 .

Cr-Commit-Position: refs/heads/master@{#349848}

[modify] http://crrev.com/a0b4647fa61f5ffbfac96a5ba508aabc5cba8787/gpu/command_buffer/service/gpu_scheduler.cc

Project Member

Comment 538 by bugdroid1@chromium.org, Sep 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc8254be282454c26a228545fca479e3b257daaa

commit fc8254be282454c26a228545fca479e3b257daaa
Author: thakis <thakis@chromium.org>
Date: Mon Sep 21 15:35:26 2015

clang packager/win: Check that GnuWin32 is in the path at the start.

It's needed to run tests, and I prefer getting an error message
immediately over getting one 17 minutes in, when the build is done
and tests start running.

BUG=82385

Review URL: https://codereview.chromium.org/1351143006

Cr-Commit-Position: refs/heads/master@{#349932}

[modify] http://crrev.com/fc8254be282454c26a228545fca479e3b257daaa/tools/clang/scripts/package.py

Project Member

Comment 539 by bugdroid1@chromium.org, Sep 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3442a5559a27b3ba64a277d5171b89f005a2f5db

commit 3442a5559a27b3ba64a277d5171b89f005a2f5db
Author: Nico Weber <thakis@chromium.org>
Date: Thu Sep 24 15:42:33 2015

clang/win: Fix component build after https://codereview.chromium.org/1365003002

CORE_EXPORT GC_PLUGIN_IGNORE("535448") expands to
`__declspec(dllexport) __attribute__((annotate("blink_gc_plugin_ignore")))` with
clang/win, but clang only understands the other order.  (On non-Windows,
CORE_EXPORT expands to an __attribute__ too, and those can be listed in any
order.)

This causes a pretty bad diagnostic, I filed a clang bug to improve it (http://llvm.org/PR24925):

In file included from ..\..\third_party\WebKit\Source\core\animation\DeferredLegacyStyleInterpolation.cpp:10:
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration of anonymous class must be a definition
class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue {
^
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(46,1) : error: declaration does not declare anything [-Werror,-Wmissing-declarations]
class CORE_EXPORT GC_PLUGIN_IGNORE("535448") CSSBasicShapeValue : public CSSValue {
^
..\..\third_party\WebKit\Source\core/css/CSSBasicShapeValue.h(78,47) : error: base class has incomplete type
class CSSBasicShapeCircleValue final : public CSSBasicShapeValue {
                                       ~~~~~~~^~~~~~~~~~~~~~~~~~

BUG=82385
R=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1363363002 .

Cr-Commit-Position: refs/heads/master@{#350563}

[modify] http://crrev.com/3442a5559a27b3ba64a277d5171b89f005a2f5db/third_party/WebKit/Source/core/css/CSSBasicShapeValue.h

Project Member

Comment 540 by bugdroid1@chromium.org, Sep 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062e865ea118e386fdab92bebccec32920fac21d

commit 062e865ea118e386fdab92bebccec32920fac21d
Author: hans <hans@chromium.org>
Date: Fri Sep 25 16:37:35 2015

Fix CreateApplicationShortcutView::AddCheckbox compile error

It was failing to compile on Win-Clang with this error message:

..\..\chrome\browser\ui\views\create_application_shortcut_view.cc(397,79) :
error: non-pointer operand type 'bool' incompatible with nullptr
  creation_locations.in_quick_launch_bar = quick_launch_check_box_ == nullptr ?
                                                                              ^

TBR=bcwhite, msw
BUG=82385

Review URL: https://codereview.chromium.org/1372623003

Cr-Commit-Position: refs/heads/master@{#350846}

[modify] http://crrev.com/062e865ea118e386fdab92bebccec32920fac21d/chrome/browser/ui/views/create_application_shortcut_view.cc

Project Member

Comment 541 by bugdroid1@chromium.org, Sep 25 2015

Blockedon: chromium:536726
Blockedon: chromium:536963
Project Member

Comment 544 by bugdroid1@chromium.org, Sep 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48b0df0b36406d369a7a4894aa255ee594e3e375

commit 48b0df0b36406d369a7a4894aa255ee594e3e375
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Sep 30 20:14:42 2015

Fix -Wunused-const-variable warning in Win-Clang build

BUG=82385
TBR=msw

Review URL: https://codereview.chromium.org/1368293009 .

Cr-Commit-Position: refs/heads/master@{#351628}

[modify] http://crrev.com/48b0df0b36406d369a7a4894aa255ee594e3e375/base/test/test_file_util_win.cc

Project Member

Comment 545 by bugdroid1@chromium.org, Oct 1 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f6cfd0ed67110e9fc22801b0b4b814e1b1bf5f2

commit 2f6cfd0ed67110e9fc22801b0b4b814e1b1bf5f2
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Oct 01 22:28:12 2015

Fix 'enumeration not handled in switch' error on Win-Clang bots

BUG=82385
TBR=erikchen

Review URL: https://codereview.chromium.org/1385493002 .

Cr-Commit-Position: refs/heads/master@{#351908}

[modify] http://crrev.com/2f6cfd0ed67110e9fc22801b0b4b814e1b1bf5f2/ipc/attachment_broker_unprivileged_win.cc

Project Member

Comment 546 by bugdroid1@chromium.org, Oct 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8032beb66fd40d1f67afb080c96af47da2e1876

commit e8032beb66fd40d1f67afb080c96af47da2e1876
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Oct 02 00:39:38 2015

Fix another 'enumerator not handled in switch' Win-Clang warning

BUG=82385
TBR=erikchen

Review URL: https://codereview.chromium.org/1386553002 .

Cr-Commit-Position: refs/heads/master@{#351922}

[modify] http://crrev.com/e8032beb66fd40d1f67afb080c96af47da2e1876/ipc/attachment_broker_privileged_win.cc

Project Member

Comment 547 by bugdroid1@chromium.org, Oct 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8964dbc4cdb8498c09c61e69b63df3d7fe86785e

commit 8964dbc4cdb8498c09c61e69b63df3d7fe86785e
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Oct 06 21:19:38 2015

Suppress -Wextern-initializer in chromoting_lib.dlldata.c

With the new SDK, Clang builds were failing with:

error: 'extern' variable has an initializer [-Werror,-Wextern-initializer]
PROXYFILE_LIST_START
^
C:\b\depot_tools\win_toolchain\vs2013_files\win_sdk/Include/10.0.10240.0/um\rpcproxy.h(823,39):
note: expanded from macro 'PROXYFILE_LIST_START'
    extern const ProxyFileInfo* const aProxyFileList[]    = {
                                      ^

BUG=491424, 82385
R=scottmg@chromium.org
TBR=joedow, scottmg, thakis

Review URL: https://codereview.chromium.org/1393473003 .

Cr-Commit-Position: refs/heads/master@{#352687}

[modify] http://crrev.com/8964dbc4cdb8498c09c61e69b63df3d7fe86785e/remoting/remoting_host_win.gypi

Project Member

Comment 548 by bugdroid1@chromium.org, Oct 8 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afed53480839e71ad84de41dfdaa5aacf6b559f8

commit afed53480839e71ad84de41dfdaa5aacf6b559f8
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Oct 08 15:45:58 2015

Fix -Wunused-function error in native_stack_sampler_win.cc

This was breaking Windows Clang builds:

..\..\base\profiler\native_stack_sampler_win.cc(82,6) :
error: unused function 'RewritePointerIfInOriginalStack' [-Werror,-Wunused-function]
void RewritePointerIfInOriginalStack(uintptr_t top, uintptr_t bottom,
     ^

BUG=82385
TBR=wittman

Review URL: https://codereview.chromium.org/1394203003 .

Cr-Commit-Position: refs/heads/master@{#353063}

[modify] http://crrev.com/afed53480839e71ad84de41dfdaa5aacf6b559f8/base/profiler/native_stack_sampler_win.cc

Project Member

Comment 549 by bugdroid1@chromium.org, Oct 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9118aca83ca5a71ec91f1b345e86344ba2616f6b

commit 9118aca83ca5a71ec91f1b345e86344ba2616f6b
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Oct 13 15:59:00 2015

Fix order of initialization warning in target_process.cc.

The build was failing with the following Clang error:

..\..\sandbox\win\src\target_process.cc(77,7):
error: field 'initial_token_' will be initialized after field 'lowbox_token_' [-Werror,-Wreorder]
      initial_token_(initial_token.Pass()),
      ^

BUG=82385
TBR=forshaw

Review URL: https://codereview.chromium.org/1408443002 .

Cr-Commit-Position: refs/heads/master@{#353765}

[modify] http://crrev.com/9118aca83ca5a71ec91f1b345e86344ba2616f6b/sandbox/win/src/target_process.h

Project Member

Comment 550 by bugdroid1@chromium.org, Oct 14 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a4e4ab217da89850f1a098a0f8d61c9e5704c2

commit a5a4e4ab217da89850f1a098a0f8d61c9e5704c2
Author: thakis <thakis@chromium.org>
Date: Wed Oct 14 00:55:45 2015

win: Let about:version list the C++ compiler used to build chrome.

We're hoping to send out a single clang-built canary later this week, and
this will be useful for identifying that.  After that, we can remove this
row again.

BUG=82385,530785

Review URL: https://codereview.chromium.org/1404063002

Cr-Commit-Position: refs/heads/master@{#353930}

[modify] http://crrev.com/a5a4e4ab217da89850f1a098a0f8d61c9e5704c2/chrome/browser/resources/about_version.html
[modify] http://crrev.com/a5a4e4ab217da89850f1a098a0f8d61c9e5704c2/chrome/browser/ui/webui/version_ui.cc

Blockedon: chromium:543182
Blockedon: chromium:544127
Blockedon: chromium:547142
Blockedon: chromium:548295
Blockedon: chromium:548348
Project Member

Comment 556 by bugdroid1@chromium.org, Oct 28 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3402cf119541d1b9cca88fe0621d4b2c5193afdb

commit 3402cf119541d1b9cca88fe0621d4b2c5193afdb
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 28 03:57:10 2015

clang/win: Fix -Wunused-function warnings after https://codereview.chromium.org/1420003004/

Fixes:

..\..\components/leveldb_proto/proto_database_impl.h(102,6) : error: unused
function 'InitFromTaskRunner' [-Werror,-Wunused-function]
void InitFromTaskRunner(LevelDB* database, const base::FilePath& database_dir,
     ^
..\..\components/leveldb_proto/proto_database_impl.h(110,6) : error: unused
function 'DestroyFromTaskRunner' [-Werror,-Wunused-function]
void DestroyFromTaskRunner(const base::FilePath& database_dir, bool* success) {
     ^

Defining non-inline functions in a .h file generally can't work, so the
warning pointed at bad code here.

BUG=82385
TBR=jianli

Review URL: https://codereview.chromium.org/1422313003 .

Cr-Commit-Position: refs/heads/master@{#356509}

[modify] http://crrev.com/3402cf119541d1b9cca88fe0621d4b2c5193afdb/components/leveldb_proto/proto_database_impl.h

Project Member

Comment 557 by bugdroid1@chromium.org, Oct 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80004a8df9cf8b81f5b231696e3a24d190a8e05b

commit 80004a8df9cf8b81f5b231696e3a24d190a8e05b
Author: Nico Weber <thakis@chromium.org>
Date: Fri Oct 30 16:18:53 2015

Remove a static initializer on Windows.

clang-cl complains:
..\..\third_party\WebKit\Source\core\html\HTMLSelectElement.cpp(80,23) :
error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
static const unsigned maxListItems = std::numeric_limits<int>::max();
                      ^

See also thread "[chromium-dev] std::numeric_limits vs INTN_MAX"

BUG=82385
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1411323005 .

Cr-Commit-Position: refs/heads/master@{#357118}

[modify] http://crrev.com/80004a8df9cf8b81f5b231696e3a24d190a8e05b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Blockedon: chromium:549765
Project Member

Comment 559 by bugdroid1@chromium.org, Nov 1 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51ca06cec30b81d20c1360abeca8e57b4b9a6040

commit 51ca06cec30b81d20c1360abeca8e57b4b9a6040
Author: thakis <thakis@chromium.org>
Date: Sun Nov 01 02:55:14 2015

win/clang: Fix a -Wmicrosoft-cast warning.

http://llvm.org/viewvc/llvm-project?view=revision&revision=251738 let
clang warn on converting function pointers to object pointers.  Fix one
such instance.  No intended behavior change.

Fixes
..\..\chrome\...\verifier_test_dll.cc(24,19) :
error: implicit conversion between pointer-to-function and
pointer-to-object is a Microsoft extension [-Wmicrosoft-cast]
    g_somestate = &DummyExport;
                  ^~~~~~~~~~~~

BUG=82385

Review URL: https://codereview.chromium.org/1428673005

Cr-Commit-Position: refs/heads/master@{#357281}

[modify] http://crrev.com/51ca06cec30b81d20c1360abeca8e57b4b9a6040/chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc

Blockedon: chromium:550065
Blockedon: -chromium:550065
Blockedon: chromium:552241
Blockedon: chromium:552909
Project Member

Comment 564 by bugdroid1@chromium.org, Nov 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d993608af3e766af8e8e941d60e4c0e2abe88cb

commit 2d993608af3e766af8e8e941d60e4c0e2abe88cb
Author: sorin <sorin@chromium.org>
Date: Fri Nov 13 20:47:01 2015

Fix compile-time error: unused variable
'kSwitchDisableBackgroundDownloads'

BUG=552028,82385

Review URL: https://codereview.chromium.org/1442123002

Cr-Commit-Position: refs/heads/master@{#359628}

[modify] http://crrev.com/2d993608af3e766af8e8e941d60e4c0e2abe88cb/components/component_updater/configurator_impl.cc

Comment 565 by h...@chromium.org, Nov 16 2015

Blockedon: chromium:556735

Comment 566 by h...@chromium.org, Nov 18 2015

Blockedon: chromium:557968
Project Member

Comment 568 by bugdroid1@chromium.org, Nov 19 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b606300e56e3e8a8b11ccc150bf1092c72828709

commit b606300e56e3e8a8b11ccc150bf1092c72828709
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 19 23:13:36 2015

Roll pdfium 76b01042:8840ec9b

Pick up:
8840ec9b "Remove unused function"

BUG=82385, 558413
R=thestig@chromium.org
TBR=thestig

Review URL: https://codereview.chromium.org/1459163004 .

Cr-Commit-Position: refs/heads/master@{#360680}

[modify] http://crrev.com/b606300e56e3e8a8b11ccc150bf1092c72828709/DEPS

Project Member

Comment 569 by bugdroid1@chromium.org, Nov 20 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29623f15f93140805385e3c328339c7919e5f2e2

commit 29623f15f93140805385e3c328339c7919e5f2e2
Author: Nico Weber <thakis@chromium.org>
Date: Fri Nov 20 22:19:58 2015

Fix build after https://codereview.chromium.org/1457033002

..\..\skia\ext\platform_device.cc(20,6) :  error: unused function 'SetBoolMetaData' [-Werror,-Wunused-function]
void SetBoolMetaData(const SkCanvas& canvas, const char* key,  bool value) {
     ^
..\..\skia\ext\platform_device.cc(25,6) :  error: unused function 'GetBoolMetaData' [-Werror,-Wunused-function]
bool GetBoolMetaData(const SkCanvas& canvas, const char* key) {
     ^

BUG=82385
TBR=tomhudson

Review URL: https://codereview.chromium.org/1464783003 .

Cr-Commit-Position: refs/heads/master@{#360930}

[modify] http://crrev.com/29623f15f93140805385e3c328339c7919e5f2e2/skia/ext/platform_device.cc

Project Member

Comment 570 by bugdroid1@chromium.org, Nov 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db730725a86c540c8d9ba7d77c9651eb35389469

commit db730725a86c540c8d9ba7d77c9651eb35389469
Author: Nico Weber <thakis@chromium.org>
Date: Mon Nov 23 16:07:08 2015

Make SerialIoHandlerWin::UiThreadHelper final.

Fixes the clang/win build after https://codereview.chromium.org/1439443002/
clang rightfully complains that UiThreadHelper has virtual methods, is
deleted polymorphically, and doesn't have a virtual destructor:

..\..\base/sequenced_task_runner_helpers.h(40,5) :  error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete reinterpret_cast<const T*>(object);
    ^
..\..\base/sequenced_task_runner_helpers.h(86,38) :  note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here
        from_here, &DeleteHelper<T>::DoDelete, object);
                                     ^
..\..\base/sequenced_task_runner.h(126,48) :  note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here
        subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner(
                                               ^
..\..\device\serial\serial_io_handler_win.cc(374,28) :  note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here
  ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_);
                           ^

Making the class final fixes this as it makes sure that nobody adds
a subclass of UiThreadHelper.

Also don't mix initializer styles for the different fields of this
class.

No intended behavior change.

BUG=82385
TBR=juncai

Review URL: https://codereview.chromium.org/1470983002 .

Cr-Commit-Position: refs/heads/master@{#361117}

[modify] http://crrev.com/db730725a86c540c8d9ba7d77c9651eb35389469/device/serial/serial_io_handler_win.cc
[modify] http://crrev.com/db730725a86c540c8d9ba7d77c9651eb35389469/device/serial/serial_io_handler_win.h

Blockedon: chromium:560836
Blockedon: chromium:560972
Project Member

Comment 573 by bugdroid1@chromium.org, Nov 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c5b560af04db599b4b2a62a32366f8b2a80154

commit d1c5b560af04db599b4b2a62a32366f8b2a80154
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 26 00:34:52 2015

Fix Clang-plugin style error in ChildBrokerHost

BUG=82385
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1476143002 .

Cr-Commit-Position: refs/heads/master@{#361763}

[modify] http://crrev.com/d1c5b560af04db599b4b2a62a32366f8b2a80154/mojo/edk/system/child_broker_host.h

Blockedon: chromium:562308
Project Member

Comment 576 by bugdroid1@chromium.org, Nov 30 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a042ba7e0ac563546841a9ddcc35967e8e25ef73

commit a042ba7e0ac563546841a9ddcc35967e8e25ef73
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Nov 30 19:02:50 2015

Fix unused function: SetBoolMetaData

To unbreak the Windows Clang build.
From http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/5143/steps/compile/logs/stdio:

..\..\skia\ext\platform_canvas.cc(19,6) :  error: unused function 'SetBoolMetaData' [-Werror,-Wunused-function]
void SetBoolMetaData(const SkCanvas& canvas, const char* key,  bool value) {
     ^
..\..\skia\ext\platform_canvas.cc(24,6) :  error: unused function 'GetBoolMetaData' [-Werror,-Wunused-function]
bool GetBoolMetaData(const SkCanvas& canvas, const char* key) {
     ^

BUG=82385
TBR=tomhudson

Review URL: https://codereview.chromium.org/1480393002 .

Cr-Commit-Position: refs/heads/master@{#362178}

[modify] http://crrev.com/a042ba7e0ac563546841a9ddcc35967e8e25ef73/skia/ext/platform_canvas.cc

Blockedon: chromium:564691
Blockedon: chromium:565700
Blockedon: chromium:540897
Blockedon: chromium:567205
Blockedon: chromium:566751
Blockedon: chromium:567877
Blockedon: chromium:568610
Blockedon: chromium:568781
Project Member

Comment 585 by bugdroid1@chromium.org, Dec 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08cd0dff06d075273155efa5f724434521224232

commit 08cd0dff06d075273155efa5f724434521224232
Author: thakis <thakis@chromium.org>
Date: Thu Dec 10 22:40:45 2015

Remove IAccessible2Proxy

It was added for chrome frame testing, but chrome frame is no more.
Nothing depends on this target nowadays.

It doesn't build with clang/win, and the only reason we didn't notice
is because the 'all' target doesn't include all targets in gyp.  The
gn build gets this right.  Since this target doesn't build with
clang/win and is unused, just delete it.

BUG=82385

Review URL: https://codereview.chromium.org/1521443002

Cr-Commit-Position: refs/heads/master@{#364511}

[modify] http://crrev.com/08cd0dff06d075273155efa5f724434521224232/third_party/iaccessible2/BUILD.gn
[delete] http://crrev.com/8224d69c949ca117ec7cc706b4e1bf81e4eaee49/third_party/iaccessible2/IAccessible2Proxy.def
[modify] http://crrev.com/08cd0dff06d075273155efa5f724434521224232/third_party/iaccessible2/README.chromium
[modify] http://crrev.com/08cd0dff06d075273155efa5f724434521224232/third_party/iaccessible2/iaccessible2.gyp

Project Member

Comment 586 by bugdroid1@chromium.org, Dec 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd148966bcdf4087db82bbaac36b8ea082faa53

commit acd148966bcdf4087db82bbaac36b8ea082faa53
Author: thakis <thakis@chromium.org>
Date: Fri Dec 11 00:23:38 2015

Make metro_driver_unittests build with clang/win.

Explicit specializations must not have a storage class. Since the whole
thing is in an unnamed namespace anyway, drop it on the template
declaration too.

..\..\win8\metro_driver\winrt_utils_unittest.cc(19,16) :  error: explicit specialization cannot have a storage class [-W
error]
static HRESULT CreateProperty<const wchar_t*>(
~~~~~~~        ^

BUG=82385

Review URL: https://codereview.chromium.org/1521473002

Cr-Commit-Position: refs/heads/master@{#364543}

[modify] http://crrev.com/acd148966bcdf4087db82bbaac36b8ea082faa53/win8/metro_driver/winrt_utils_unittest.cc

Project Member

Comment 587 by bugdroid1@chromium.org, Dec 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51f492a4b97bf2fe6ef15faf255c418db796e0ed

commit 51f492a4b97bf2fe6ef15faf255c418db796e0ed
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Dec 11 01:23:27 2015

Roll WebRTC 10978:10982

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/090af54..d4bc829

This picks up a build fix for Win-Clang (#10978).

BUG=82385
R=emircan@chromium.org

Review URL: https://codereview.chromium.org/1517853003 .

Cr-Commit-Position: refs/heads/master@{#364564}

[modify] http://crrev.com/51f492a4b97bf2fe6ef15faf255c418db796e0ed/DEPS

Project Member

Comment 588 by bugdroid1@chromium.org, Dec 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a6783b56f6f566a754d4c12a4412e600e5905e7

commit 6a6783b56f6f566a754d4c12a4412e600e5905e7
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Dec 11 04:43:33 2015

Roll WebRTC 10982:10983

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/d4bc829..b9919f6

This picks up a build fix for Win-Clang, take 2.

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/1513123004 .

Cr-Commit-Position: refs/heads/master@{#364613}

[modify] http://crrev.com/6a6783b56f6f566a754d4c12a4412e600e5905e7/DEPS

Project Member

Comment 589 by bugdroid1@chromium.org, Dec 12 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d44840e9d3cd750eee01183b5a7834c9961e5e

commit d7d44840e9d3cd750eee01183b5a7834c9961e5e
Author: Nico Weber <thakis@chromium.org>
Date: Sat Dec 12 14:34:22 2015

clang/win: Fix build after https://codereview.chromium.org/1456663003

Fixes:
..\..\sandbox\win\src\sandbox_policy_base.cc(165,5) : error: delete called on
        'sandbox::PolicyBase' that has virtual functions but non-virtual
        destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete this;
    ^
BUG=82385
R=rickyz@chromium.org
TBR=wfh

Review URL: https://codereview.chromium.org/1521703003 .

Cr-Commit-Position: refs/heads/master@{#364933}

[modify] http://crrev.com/d7d44840e9d3cd750eee01183b5a7834c9961e5e/sandbox/win/src/sandbox_policy_base.h

Blockedon: chromium:569340
Blockedon: chromium:569633
Blockedon: chromium:569964
Project Member

Comment 593 by bugdroid1@chromium.org, Dec 16 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/415f7da181d489b006cd5ef6c4c8f7098ffeb65c

commit 415f7da181d489b006cd5ef6c4c8f7098ffeb65c
Author: Nico Weber <thakis@chromium.org>
Date: Wed Dec 16 13:56:21 2015

clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org

Review URL: https://codereview.chromium.org/1523163005 .

Cr-Commit-Position: refs/heads/master@{#365519}

[modify] http://crrev.com/415f7da181d489b006cd5ef6c4c8f7098ffeb65c/chrome/installer/mini_installer/mini_installer.cc

Project Member

Comment 594 by bugdroid1@chromium.org, Dec 17 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eac2435210f650ceba686aad370bfaca915ca7b

commit 0eac2435210f650ceba686aad370bfaca915ca7b
Author: Nico Weber <thakis@chromium.org>
Date: Thu Dec 17 12:11:08 2015

Remove an unneeded std::move(), found by clang/win.

https://codereview.chromium.org/1530923002 changed this from a Pass() to
std::move(), which has the effect that the compiler can now reason about it
and is able to point out:

..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  error: moving a local object
      in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(instance);
         ^
..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  note: remove std::move
      call here
  return std::move(instance);
         ^~~~~~~~~~

BUG=82385
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/1525293004 .

Cr-Commit-Position: refs/heads/master@{#365811}

[modify] http://crrev.com/0eac2435210f650ceba686aad370bfaca915ca7b/ui/gfx/win/direct_manipulation.cc

Project Member

Comment 595 by bugdroid1@chromium.org, Dec 17 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83201c236e56ee4725a2543db01b5bef5f1674fc

commit 83201c236e56ee4725a2543db01b5bef5f1674fc
Author: Nico Weber <thakis@chromium.org>
Date: Thu Dec 17 12:37:48 2015

clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/1537483003 .

Cr-Commit-Position: refs/heads/master@{#365812}

[modify] http://crrev.com/83201c236e56ee4725a2543db01b5bef5f1674fc/content/common/cursors/webcursor_unittest.cc

Comment 596 Deleted

Project Member

Comment 597 by bugdroid1@chromium.org, Dec 21 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709d0def5bdd564e63b41d9b2ea67723dd2a1945

commit 709d0def5bdd564e63b41d9b2ea67723dd2a1945
Author: thakis <thakis@chromium.org>
Date: Mon Dec 21 20:25:24 2015

gn: Make command_buffer_gles2 deps less weird.

The target used to pull in source_sets that are part of the gpu
component in component builds.  This usually won't link well, so
just depend on gpu directly.

Happens to fix a build error in clang/win gn component builds too.

BUG=82385
TBR=dpranke

Review URL: https://codereview.chromium.org/1542683002

Cr-Commit-Position: refs/heads/master@{#366450}

[modify] http://crrev.com/709d0def5bdd564e63b41d9b2ea67723dd2a1945/gpu/BUILD.gn

Blockedon: chromium:571497
Project Member

Comment 599 by bugdroid1@chromium.org, Dec 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0a8e7542c9d6824eb34bcdcc8f4b1738df2f08

commit 3f0a8e7542c9d6824eb34bcdcc8f4b1738df2f08
Author: Nico Weber <thakis@chromium.org>
Date: Wed Dec 23 21:31:22 2015

Fix clang/win build after https://codereview.chromium.org/1543173002/

That change made metrics_aura.cc include build_config.h.  Before,
nothing did, so `defined(OS_WIN)` was always false (even on Windows!).
Now that it isn't, clang-cl complains that a constant is unused
on Windows, so move it to a more local scope.

BUG=82385
R=tfarina@chromium.org
TBR=avi

Review URL: https://codereview.chromium.org/1544083002 .

Cr-Commit-Position: refs/heads/master@{#366771}

[modify] http://crrev.com/3f0a8e7542c9d6824eb34bcdcc8f4b1738df2f08/ui/views/metrics_aura.cc

Blockedon: chromium:572237
Project Member

Comment 601 by bugdroid1@chromium.org, Dec 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e2963a777189ff269b2bb48b1882f55301afae

commit f0e2963a777189ff269b2bb48b1882f55301afae
Author: dcheng <dcheng@chromium.org>
Date: Tue Dec 29 03:02:53 2015

Fix an unneeded std::move in //third_party/libaddressinput.

std::move is not needed when returning local variables. This wasn't
caught in the initial commit because only Windows builds //third_party
with -Wall.

BUG=82385
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1549373004

Cr-Commit-Position: refs/heads/master@{#367043}

[modify] http://crrev.com/f0e2963a777189ff269b2bb48b1882f55301afae/third_party/libaddressinput/chromium/json.cc

Project Member

Comment 602 by bugdroid1@chromium.org, Dec 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c95337d638df3289758257448a90556e9fcdd071

commit c95337d638df3289758257448a90556e9fcdd071
Author: Nico Weber <thakis@chromium.org>
Date: Tue Dec 29 14:31:15 2015

Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove std::move call here
  return std::move(response);
         ^~~~~~~~~~

..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka

Review URL: https://codereview.chromium.org/1552613003 .

Cr-Commit-Position: refs/heads/master@{#367067}

[modify] http://crrev.com/c95337d638df3289758257448a90556e9fcdd071/cloud_print/gcp20/prototype/cloud_print_request.cc
[modify] http://crrev.com/c95337d638df3289758257448a90556e9fcdd071/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc
[modify] http://crrev.com/c95337d638df3289758257448a90556e9fcdd071/cloud_print/gcp20/prototype/privet_http_server.cc

Project Member

Comment 603 by bugdroid1@chromium.org, Dec 29 2015

Blockedon: chromium:574490
Project Member

Comment 605 by bugdroid1@chromium.org, Jan 6 2016

Project Member

Comment 606 by bugdroid1@chromium.org, Jan 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d41b0472651991ca51aa167e618a80e9ee225759

commit d41b0472651991ca51aa167e618a80e9ee225759
Author: thakis <thakis@chromium.org>
Date: Wed Jan 06 17:24:54 2016

Roll ANGLE 69bbc98..e1743f3

https://chromium.googlesource.com/angle/angle.git/+log/69bbc98..e1743f3

BUG=82385,512869

TEST=bots
TBR=jmadill

Review URL: https://codereview.chromium.org/1562823002

Cr-Commit-Position: refs/heads/master@{#367846}

[modify] http://crrev.com/d41b0472651991ca51aa167e618a80e9ee225759/DEPS

Project Member

Comment 607 by bugdroid1@chromium.org, Jan 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7da247515b4c2f0fc8d6474f891f50335a0cc90

commit b7da247515b4c2f0fc8d6474f891f50335a0cc90
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Jan 08 14:33:52 2016

Fix Win Clang -Wpessimizing-move error

The build was failing with:

..\..\ipc\attachment_broker_privileged_win_unittest.cc(105,10) :
error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(shared_memory);
         ^

BUG=82385
TBR=erikchen

Review URL: https://codereview.chromium.org/1575433002 .

Cr-Commit-Position: refs/heads/master@{#368328}

[modify] http://crrev.com/b7da247515b4c2f0fc8d6474f891f50335a0cc90/ipc/attachment_broker_privileged_win_unittest.cc

Blockedon: chromium:575700
Blockedon: chromium:576773
Blockedon: chromium:576774
Blockedon: chromium:576842
Project Member

Comment 612 by bugdroid1@chromium.org, Jan 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4542e5e8b12f32a7fec0cf7ea72cb8d36998751

commit c4542e5e8b12f32a7fec0cf7ea72cb8d36998751
Author: Nico Weber <thakis@chromium.org>
Date: Tue Jan 12 20:53:40 2016

Mark mini_installer as chromium_code in gyp builds.

This matches the gn build. Also fix a warning that only fires in
chromium_code mode -- which means that this CL also fixes the
clang/win/gn build of mini_installer.

BUG=82385
R=gab@chromium.org

Review URL: https://codereview.chromium.org/1580673004 .

Cr-Commit-Position: refs/heads/master@{#368983}

[modify] http://crrev.com/c4542e5e8b12f32a7fec0cf7ea72cb8d36998751/chrome/installer/mini_installer.gyp
[modify] http://crrev.com/c4542e5e8b12f32a7fec0cf7ea72cb8d36998751/chrome/installer/mini_installer/mini_installer.cc

Project Member

Comment 613 by bugdroid1@chromium.org, Jan 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea48fddb6200ffec6dc01a246f2931baed501505

commit ea48fddb6200ffec6dc01a246f2931baed501505
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jan 13 15:32:23 2016

Remove useless std::move().

https://codereview.chromium.org/1579583004/ converted a Pass() to
std::move(), which enabled the compiler to tell us that it's not needed
and actually harmful:

..\..\chrome\installer\util\shell_util.cc(277,10) :
    error: moving a local object in a return statement prevents copy elision
    [-Werror,-Wpessimizing-move]
  return std::move(entries);
         ^
..\..\chrome\installer\util\shell_util.cc(277,10) :
    note: remove std::move call here
  return std::move(entries);
         ^~~~~~~~~~
BUG=82385
TBR=mgiuca

Review URL: https://codereview.chromium.org/1581083003 .

Cr-Commit-Position: refs/heads/master@{#369176}

[modify] http://crrev.com/ea48fddb6200ffec6dc01a246f2931baed501505/chrome/installer/util/shell_util.cc

Project Member

Comment 614 by bugdroid1@chromium.org, Jan 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ba896b9298211d2e504f590e82bdae323aaf4b

commit 37ba896b9298211d2e504f590e82bdae323aaf4b
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jan 13 17:37:21 2016

Remove an unused function after https://codereview.chromium.org/1581473002

Found by clang/win.

BUG=82385
TBR=scottmg

Review URL: https://codereview.chromium.org/1585703002 .

Cr-Commit-Position: refs/heads/master@{#369205}

[modify] http://crrev.com/37ba896b9298211d2e504f590e82bdae323aaf4b/chrome/browser/process_singleton_win.cc

Project Member

Comment 615 by bugdroid1@chromium.org, Jan 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c125eaa7b02dd16c71bcbe8191ec7e9a21903c

commit c8c125eaa7b02dd16c71bcbe8191ec7e9a21903c
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jan 13 19:07:50 2016

Remove another unused function after https://codereview.chromium.org/1581473002

BUG=82385,558054
TBR=scottmg

Review URL: https://codereview.chromium.org/1583733004 .

Cr-Commit-Position: refs/heads/master@{#369232}

[modify] http://crrev.com/c8c125eaa7b02dd16c71bcbe8191ec7e9a21903c/chrome/browser/first_run/upgrade_util_win.cc

Blockedon: chromium:577620
Project Member

Comment 617 by bugdroid1@chromium.org, Jan 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cf1712f9f097ff610d679b2bd942fcff596979

commit e1cf1712f9f097ff610d679b2bd942fcff596979
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jan 15 02:19:08 2016

clang/win: Fix a -Wmissing-braces regression from https://codereview.chromium.org/1563183008/

No behavior change.

BUG=547914,82385
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/1589253002 .

Cr-Commit-Position: refs/heads/master@{#369661}

[modify] http://crrev.com/e1cf1712f9f097ff610d679b2bd942fcff596979/ui/gfx/win/physical_size.cc

Project Member

Comment 618 by bugdroid1@chromium.org, Jan 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/459c246b5b9e02eb98310e729bdfaada5f7b4521

commit 459c246b5b9e02eb98310e729bdfaada5f7b4521
Author: scottmg <scottmg@chromium.org>
Date: Tue Jan 19 04:15:54 2016

Remove unused function after https://codereview.chromium.org/1586843002

Found by clang:
..\..\win8\delegate_execute\command_execute_impl.cc(69,6) :  error: unused function 'LaunchChromeBrowserProcess' [-Werror,-Wunused-function]

R=thakis@chromium.org
TBR=ananta@chromium.org
BUG=558054,82385

Review URL: https://codereview.chromium.org/1604693002

Cr-Commit-Position: refs/heads/master@{#370074}

[modify] http://crrev.com/459c246b5b9e02eb98310e729bdfaada5f7b4521/win8/delegate_execute/command_execute_impl.cc

Project Member

Comment 619 by bugdroid1@chromium.org, Jan 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974c76184af04263ab344f6e2094e5b24e2a8a77

commit 974c76184af04263ab344f6e2094e5b24e2a8a77
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jan 20 15:24:27 2016

Unbreak clang/win gn bots after https://codereview.chromium.org/1556923002/

Fixes a bunch of
clang-cl.exe: error: unknown argument: '-fdebug-prefix-map=E:/b/build/slave/CrWinClang64_dbg_/build/src=.'

BUG=82385,439949
TBR=zforman@chromium.org

Review URL: https://codereview.chromium.org/1610633002 .

Cr-Commit-Position: refs/heads/master@{#370398}

[modify] http://crrev.com/974c76184af04263ab344f6e2094e5b24e2a8a77/build/config/compiler/BUILD.gn

Project Member

Comment 620 by bugdroid1@chromium.org, Jan 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/d23b1fd98423d95c9a72a3167cb5ab4249619fb9

commit d23b1fd98423d95c9a72a3167cb5ab4249619fb9
Author: thakis@chromium.org <thakis@chromium.org>
Date: Wed Jan 20 20:53:00 2016

Set SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385

Review URL: https://codereview.chromium.org/1604423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298326 0039d316-1c4b-4281-b951-d872f2087c98

[modify] http://crrev.com/d23b1fd98423d95c9a72a3167cb5ab4249619fb9/win_toolchain/package_from_installed.py

Project Member

Comment 621 by bugdroid1@chromium.org, Jan 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b7851a6d4410fa5aecb3a8c13cae8c709f9d2ee

commit 9b7851a6d4410fa5aecb3a8c13cae8c709f9d2ee
Author: brucedawson <brucedawson@chromium.org>
Date: Thu Jan 21 02:43:07 2016

VS 2015 package with VSINSTALLDIR and VCINSTALLDIR

This is a rebuild of the VS 2015 package that incorporates
the changes made in crrev.com/1604423002

BUG=82385

Review URL: https://codereview.chromium.org/1608373002

Cr-Commit-Position: refs/heads/master@{#370586}

[modify] http://crrev.com/9b7851a6d4410fa5aecb3a8c13cae8c709f9d2ee/build/vs_toolchain.py

Blockedon: chromium:580241
Project Member

Comment 623 by bugdroid1@chromium.org, Jan 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80a9d9b6ec09e3565f3a509bf0dde3509e61e451

commit 80a9d9b6ec09e3565f3a509bf0dde3509e61e451
Author: thakis <thakis@chromium.org>
Date: Tue Jan 26 16:03:12 2016

clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002

Also turn on chromium_code for these targets in gyp.  This makes warnings
for these targets consistent between gyp and gn.

BUG=550983, 581133, 82385
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1637793003

Cr-Commit-Position: refs/heads/master@{#371520}

[modify] http://crrev.com/80a9d9b6ec09e3565f3a509bf0dde3509e61e451/chrome/installer/test/alternate_version_generator.cc
[modify] http://crrev.com/80a9d9b6ec09e3565f3a509bf0dde3509e61e451/chrome/installer/upgrade_test.gyp

Comment 624 by h...@chromium.org, Jan 27 2016

Blockedon: chromium:581845
Project Member

Comment 625 by bugdroid1@chromium.org, Jan 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7163128dcbf6808756a2715d009e59c3c608ca1f

commit 7163128dcbf6808756a2715d009e59c3c608ca1f
Author: thakis <thakis@chromium.org>
Date: Fri Jan 29 16:34:42 2016

Give InputMethodWin an out-of-line destructor.

Fixes
..\..\ui/base/ime/input_method_win.h(20,1) :
    error: [chromium-style] Complex class/struct needs
    an explicit out-of-line destructor.
class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
^

BUG=82385
TBR=azurewei

Review URL: https://codereview.chromium.org/1651453002

Cr-Commit-Position: refs/heads/master@{#372356}

[modify] http://crrev.com/7163128dcbf6808756a2715d009e59c3c608ca1f/ui/base/ime/input_method_win.cc
[modify] http://crrev.com/7163128dcbf6808756a2715d009e59c3c608ca1f/ui/base/ime/input_method_win.h

Project Member

Comment 626 by bugdroid1@chromium.org, Jan 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eadfa70b3668311b230e3f27f17621668eaa8641

commit eadfa70b3668311b230e3f27f17621668eaa8641
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jan 29 17:30:38 2016

Add an override I forgot in https://codereview.chromium.org/1651453002/

BUG=82385
TBR=azurewei@chromium.org

Review URL: https://codereview.chromium.org/1644403002 .

Cr-Commit-Position: refs/heads/master@{#372366}

[modify] http://crrev.com/eadfa70b3668311b230e3f27f17621668eaa8641/ui/base/ime/input_method_win.h

Blockedon: chromium:582570
Blockedon: chromium:583674
Blockedon: chromium:583676
Project Member

Comment 630 by bugdroid1@chromium.org, Feb 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e502a2e82b175f0424b6cd98a9bf84368ff960e6

commit e502a2e82b175f0424b6cd98a9bf84368ff960e6
Author: gab <gab@chromium.org>
Date: Wed Feb 03 17:16:52 2016

Fix compile error for gn build of mini_installer

Invalid conversion from size_t to DWORD on line 529.

BUG=82385
(not sure that bug is relevant but https://codereview.chromium.org/1580673004/
 made me think it was...)

Review URL: https://codereview.chromium.org/1662683002

Cr-Commit-Position: refs/heads/master@{#373261}

[modify] http://crrev.com/e502a2e82b175f0424b6cd98a9bf84368ff960e6/chrome/installer/mini_installer/mini_installer.cc

Project Member

Comment 631 by bugdroid1@chromium.org, Feb 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b8827f887030911545998cf25a4a23fb21b49b

commit 57b8827f887030911545998cf25a4a23fb21b49b
Author: Nico Weber <thakis@chromium.org>
Date: Wed Feb 03 21:00:17 2016

clang/win: Fix -Wmissing-braces warning.

No behavior change.

BUG=82385,504006
TBR=pennymac

Review URL: https://codereview.chromium.org/1660103005 .

Cr-Commit-Position: refs/heads/master@{#373336}

[modify] http://crrev.com/57b8827f887030911545998cf25a4a23fb21b49b/sandbox/win/src/process_mitigations.cc

Project Member

Comment 632 by bugdroid1@chromium.org, Feb 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6cc36668e3c84e19498ecc6f2187cfa9407047

commit fc6cc36668e3c84e19498ecc6f2187cfa9407047
Author: Nico Weber <thakis@chromium.org>
Date: Sat Feb 06 03:00:30 2016

Roll ffmpeg forward by one

Picks up https://chromium-review.googlesource.com/#/c/326560/1

BUG=82385,498544
TBR=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1671403003 .

Cr-Commit-Position: refs/heads/master@{#374001}

[modify] http://crrev.com/fc6cc36668e3c84e19498ecc6f2187cfa9407047/DEPS

Project Member

Comment 633 by bugdroid1@chromium.org, Feb 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0

commit e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0
Author: Nico Weber <thakis@chromium.org>
Date: Sat Feb 06 05:13:42 2016

Try to get LayoutUnit.h compiling on clang/win bots after VS2015 switch.

BUG=82385,498544
TBR=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1675803004 .

Cr-Commit-Position: refs/heads/master@{#374008}

[modify] http://crrev.com/e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0/third_party/WebKit/Source/platform/LayoutUnit.h

Project Member

Comment 634 by bugdroid1@chromium.org, Feb 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12896e15fd7b1fc217c2b0f8f02da497a891cfaa

commit 12896e15fd7b1fc217c2b0f8f02da497a891cfaa
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Feb 08 22:48:58 2016

Fix Clang -Wreorder error in bluetooth_task_manager_win.cc

..\..\device\bluetooth\bluetooth_task_manager_win.cc(144,7) :
error: field 'current_logging_batch_count_' will be initialized
after field 'adapter_handle_' [-Werror,-Wreorder]

BUG=82385
TBR=gogerald1

Review URL: https://codereview.chromium.org/1676423002 .

Cr-Commit-Position: refs/heads/master@{#374206}

[modify] http://crrev.com/12896e15fd7b1fc217c2b0f8f02da497a891cfaa/device/bluetooth/bluetooth_task_manager_win.cc

Project Member

Comment 635 by bugdroid1@chromium.org, Feb 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9009d066d7ecd1c600e799230bc7e99a8523868

commit b9009d066d7ecd1c600e799230bc7e99a8523868
Author: Nico Weber <thakis@chromium.org>
Date: Tue Feb 09 02:49:55 2016

Fix Wreorder warning after https://codereview.chromium.org/1639623003/

BUG=426656,82385
TBR=robliao@chromium.org

Review URL: https://codereview.chromium.org/1677073003 .

Cr-Commit-Position: refs/heads/master@{#374282}

[modify] http://crrev.com/b9009d066d7ecd1c600e799230bc7e99a8523868/ui/gfx/win/display_info.cc

Project Member

Comment 637 by bugdroid1@chromium.org, Feb 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92600e9c8db99a4bf85cb3489741731bbd7f892e

commit 92600e9c8db99a4bf85cb3489741731bbd7f892e
Author: Nico Weber <thakis@chromium.org>
Date: Tue Feb 09 12:07:15 2016

Fix -Wsign-compare warning after https://codereview.chromium.org/1557133002

BUG=570908,82385
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/1683673002 .

Cr-Commit-Position: refs/heads/master@{#374359}

[modify] http://crrev.com/92600e9c8db99a4bf85cb3489741731bbd7f892e/net/cert/cert_verify_proc_win.cc

Project Member

Comment 638 by bugdroid1@chromium.org, Feb 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f8a5d6ac8db14ee2704a414542c20cfdba5507

commit 97f8a5d6ac8db14ee2704a414542c20cfdba5507
Author: Nico Weber <thakis@chromium.org>
Date: Tue Feb 09 14:16:03 2016

Fix chromium-style warning after https://codereview.chromium.org/1639623003/

Also fix a -Wsign-compare warning.

BUG=426656,82385
TBR=robliao@chromium.org

Review URL: https://codereview.chromium.org/1679743004 .

Cr-Commit-Position: refs/heads/master@{#374370}

[modify] http://crrev.com/97f8a5d6ac8db14ee2704a414542c20cfdba5507/ui/gfx/screen_win_unittest.cc

Project Member

Comment 639 by bugdroid1@chromium.org, Feb 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fff44b3077c182f38554dd7cf13a47c74e30fdc

commit 8fff44b3077c182f38554dd7cf13a47c74e30fdc
Author: Nico Weber <thakis@chromium.org>
Date: Wed Feb 10 02:53:47 2016

Fix 64-bit clang/win build after https://codereview.chromium.org/1225183003

Fixes two Wint-to-void-pointer-cast warnings.

BUG=464430,82385
TBR=liamjm@chromium.org

Review URL: https://codereview.chromium.org/1685473004 .

Cr-Commit-Position: refs/heads/master@{#374588}

[modify] http://crrev.com/8fff44b3077c182f38554dd7cf13a47c74e30fdc/sandbox/win/src/process_policy_test.cc

Project Member

Comment 640 by bugdroid1@chromium.org, Feb 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e651c1686c1a9945080df22d7acbb5d1cbe27f

commit e6e651c1686c1a9945080df22d7acbb5d1cbe27f
Author: thakis <thakis@chromium.org>
Date: Wed Feb 10 22:40:24 2016

Swarm components_unittests, content_browsertests, content_unittests everywhere.

Also blacklist a few more bots in manage.py.

This mostly affects the Clang ToT and the clang/win FYI bots:

$  testing/buildbot/manage.py --convert content_unittests
Convert content_unittests to run exclusively on Swarming
4 used to run locally and were converted:
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.fyi.json: CrWinClang64(dbg) tester

$  testing/buildbot/manage.py --convert components_unittests
Convert components_unittests to run exclusively on Swarming
18 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: ClangToTLinuxASan tester
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester

$  testing/buildbot/manage.py --convert content_browsertests
Convert content_browsertests to run exclusively on Swarming
2 used to run locally and were converted:
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: CrWinClang64(dbg) tester

BUG=98637,82385

Review URL: https://codereview.chromium.org/1683253003

Cr-Commit-Position: refs/heads/master@{#374755}

[modify] http://crrev.com/e6e651c1686c1a9945080df22d7acbb5d1cbe27f/testing/buildbot/chromium.fyi.json
[modify] http://crrev.com/e6e651c1686c1a9945080df22d7acbb5d1cbe27f/testing/buildbot/manage.py

Project Member

Comment 641 by bugdroid1@chromium.org, Feb 11 2016

Project Member

Comment 642 by bugdroid1@chromium.org, Feb 11 2016

Blockedon: chromium:586243
Blockedon: chromium:586511
Blockedon: chromium:586590
Blockedon: chromium:586714
Blockedon: chromium:586525
Project Member

Comment 648 by bugdroid1@chromium.org, Feb 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb04d6d974378d95e020db77738f88faaed465c1

commit fb04d6d974378d95e020db77738f88faaed465c1
Author: thakis <thakis@chromium.org>
Date: Mon Feb 15 21:27:13 2016

Give CrWinClang dbg testers 20 shards for browser_tests

They currently wait 10 minutes on swarming for browser_tests, and 20
shards matches the main waterfall win dbg tester.

BUG=82385

Review URL: https://codereview.chromium.org/1696243002

Cr-Commit-Position: refs/heads/master@{#375490}

[modify] http://crrev.com/fb04d6d974378d95e020db77738f88faaed465c1/testing/buildbot/chromium.fyi.json

Project Member

Comment 649 by bugdroid1@chromium.org, Feb 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080920dff337ea2e22a33bed25e97d289628bac1

commit 080920dff337ea2e22a33bed25e97d289628bac1
Author: Nico Weber <thakis@chromium.org>
Date: Wed Feb 17 15:29:17 2016

clang/win: Fix style errors after https://codereview.chromium.org/1585193002

..\..\ui/events/keycodes/platform_key_map_win.h(21,1) :
    error: [chromium-style] Complex class/struct needs
           an explicit out-of-line destructor.
class EVENTS_BASE_EXPORT PlatformKeyMap {
^

..\..\ui\events\keycodes\platform_key_map_win.cc(47,21) :
    error: comparison of integers of different signs:
           'int' and 'unsigned int' [-Werror,-Wsign-compare]
  for (int i = 0; i < arraysize(modifier_flags); ++i) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~

BUG=82385
TBR=chongz

Review URL: https://codereview.chromium.org/1705053002 .

Cr-Commit-Position: refs/heads/master@{#375888}

[modify] http://crrev.com/080920dff337ea2e22a33bed25e97d289628bac1/ui/events/keycodes/platform_key_map_win.cc
[modify] http://crrev.com/080920dff337ea2e22a33bed25e97d289628bac1/ui/events/keycodes/platform_key_map_win.h

Blockedon: chromium:587530
Blockedon: chromium:587843
Blockedon: chromium:587835
Project Member

Comment 653 by bugdroid1@chromium.org, Feb 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83fb3a4c55025a39a0ec95ba10504affdc33e95

commit a83fb3a4c55025a39a0ec95ba10504affdc33e95
Author: hans <hans@chromium.org>
Date: Fri Feb 19 18:48:20 2016

chrome_watcher_main.cc: Fix -Wsign-compare error

..\..\chrome\chrome_watcher\chrome_watcher_main.cc(269,23):
error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long')
and 'int' [-Werror,-Wsign-compare]
    if (suspend_count != -1) {
        ~~~~~~~~~~~~~ ^  ~~

BUG=82385
TBR=siggi

Review URL: https://codereview.chromium.org/1719443002

Cr-Commit-Position: refs/heads/master@{#376500}

[modify] https://crrev.com/a83fb3a4c55025a39a0ec95ba10504affdc33e95/chrome/chrome_watcher/chrome_watcher_main.cc

Project Member

Comment 654 by bugdroid1@chromium.org, Feb 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0512c8bd27962ab3cd16871bec499870f119155

commit e0512c8bd27962ab3cd16871bec499870f119155
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Feb 19 21:21:55 2016

event_utils_win_unittest.cc: add missing override

BUG=82385
TBR=leliukmar

Review URL: https://codereview.chromium.org/1719433003 .

Cr-Commit-Position: refs/heads/master@{#376536}

[modify] https://crrev.com/e0512c8bd27962ab3cd16871bec499870f119155/ui/events/win/event_utils_win_unittest.cc

Project Member

Comment 656 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a30b38f3e54e25db749a72d03d7a2e0acdd6119

commit 6a30b38f3e54e25db749a72d03d7a2e0acdd6119
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Mar 02 00:38:12 2016

Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor.

BUG=82385
R=scheib@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1745273005 .

Cr-Commit-Position: refs/heads/master@{#378627}

[modify] https://crrev.com/6a30b38f3e54e25db749a72d03d7a2e0acdd6119/device/bluetooth/bluetooth_remote_gatt_descriptor_win.h

Project Member

Comment 657 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/6a30b38f3e54e25db749a72d03d7a2e0acdd6119

commit 6a30b38f3e54e25db749a72d03d7a2e0acdd6119
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Mar 02 00:38:12 2016

Project Member

Comment 658 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2181f05f6446e2d6999a37d723800462762430

commit bf2181f05f6446e2d6999a37d723800462762430
Author: Nico Weber <thakis@chromium.org>
Date: Mon Mar 07 23:08:14 2016

Fix clang/win build after https://codereview.chromium.org/1685053002

It complains about unused stuff on Windows.

BUG=82385
R=khushalsagar@chromium.org
TBR=khushalsagar@chromium.org

Review URL: https://codereview.chromium.org/1774713002 .

Cr-Commit-Position: refs/heads/master@{#379678}

[modify] https://crrev.com/bf2181f05f6446e2d6999a37d723800462762430/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Project Member

Comment 659 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331970e5e418bbf29882462c9ebb867c673479bb

commit 331970e5e418bbf29882462c9ebb867c673479bb
Author: hans <hans@chromium.org>
Date: Wed Mar 16 13:14:50 2016

jumplist_win.h: Speculative Clang style plugin fix

The build was failing with:

..\..\chrome/browser/jumplist_win.h(61,3):
error: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
  struct JumpListData {
  ^

BUG=82385
TBR=tzik

Review URL: https://codereview.chromium.org/1811483002

Cr-Commit-Position: refs/heads/master@{#381441}

[modify] https://crrev.com/331970e5e418bbf29882462c9ebb867c673479bb/chrome/browser/jumplist_win.cc
[modify] https://crrev.com/331970e5e418bbf29882462c9ebb867c673479bb/chrome/browser/jumplist_win.h

Project Member

Comment 660 by bugdroid1@chromium.org, Mar 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8

commit 13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8
Author: Nico Weber <thakis@chromium.org>
Date: Sat Mar 19 13:19:06 2016

Fix Chromium style plugin warning after https://codereview.chromium.org/1815063002

..\..\content/common/gpu/media/dxva_video_decode_accelerator_win.h(445,52) :
      error: [chromium-style] WeakPtrFactory members which refer to their outer
             class must be the last member in the outer class definition.
  base::WeakPtrFactory<DXVAVideoDecodeAccelerator> weak_this_factory_;
                                                   ^

BUG=82385,594266
TBR=ananta

Review URL: https://codereview.chromium.org/1818533004 .

Cr-Commit-Position: refs/heads/master@{#382196}

[modify] https://crrev.com/13b3ac887d5011ff3b3c39d0e44ca9aed1740ce8/content/common/gpu/media/dxva_video_decode_accelerator_win.h

Blockedon: 596366
Blockedon: 597549
Project Member

Comment 663 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035459168ac247f089c25d5f5c3c1f36814bb1f5

commit 035459168ac247f089c25d5f5c3c1f36814bb1f5
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Mar 25 16:23:26 2016

process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro 'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh

Review URL: https://codereview.chromium.org/1833863004 .

Cr-Commit-Position: refs/heads/master@{#383286}

[modify] https://crrev.com/035459168ac247f089c25d5f5c3c1f36814bb1f5/sandbox/win/src/process_policy_test.cc

Blockedon: 598316
Blockedon: 598344
Blockedon: 598767
Blockedon: 598772
Blockedon: 598761
Blockedon: 598849
Blockedon: 598943
Blockedon: 600157
Blockedon: 600775
Project Member

Comment 673 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ee909f86bc7b5ec979b062c0024adab7168d43

commit 55ee909f86bc7b5ec979b062c0024adab7168d43
Author: hans <hans@chromium.org>
Date: Thu Apr 07 17:56:46 2016

Don't try to dllexport an enum

Fixes the following clang warning:

..\..\content/public/common/platform_notification_data.h(21,6):
error: 'dllexport' attribute only applies to variables, functions and classes
[-Werror,-Wignored-attributes]
enum CONTENT_EXPORT PlatformNotificationActionType {
     ^
..\..\content/common/content_export.h(12,35):
note: expanded from macro 'CONTENT_EXPORT'
                                  ^

BUG=82385
TBR=nsatragno

Review URL: https://codereview.chromium.org/1869823002

Cr-Commit-Position: refs/heads/master@{#385805}

[modify] https://crrev.com/55ee909f86bc7b5ec979b062c0024adab7168d43/content/public/common/platform_notification_data.h

Blockedon: 602265
Blockedon: 598807
Blockedon: 603935
Blockedon: 604034
Blockedon: 404525
Blockedon: 605570
Blockedon: 606810
Blockedon: 608705
Blockedon: 607197
Blockedon: 608901
Blockedon: 610367

Comment 685 by cpu@chromium.org, May 18 2016

Cc: -cpu@chromium.org
Project Member

Comment 686 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c18298fb5cb303081a9588690eec1685f0f79c

commit 66c18298fb5cb303081a9588690eec1685f0f79c
Author: thakis <thakis@chromium.org>
Date: Thu May 26 15:45:10 2016

Fix -Wwritable-strings warnings in kasko code.

Should fix 32-bit clang/win builds after
https://codereview.chromium.org/405123002/

BUG=82385
TBR=hans

Review-Url: https://codereview.chromium.org/2018543002
Cr-Commit-Position: refs/heads/master@{#396187}

[modify] https://crrev.com/66c18298fb5cb303081a9588690eec1685f0f79c/chrome/chrome_watcher/system_load_estimator.cc

Blockedon: 615050
Blockedon: 615437
Blockedon: 616152
Project Member

Comment 690 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36b726bc7c984f2fe151c86f4221c27ecc67b99

commit d36b726bc7c984f2fe151c86f4221c27ecc67b99
Author: thakis <thakis@chromium.org>
Date: Fri Jun 03 21:30:01 2016

asan/win: Unbreak build after https://codereview.chromium.org/2008553007/

..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(20,11):
  error: unused variable 'kIterations' [-Werror,-Wunused-const-variable]
const int kIterations = 20;
          ^
..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(21,11):
  error: unused variable 'kSizeBig' [-Werror,-Wunused-const-variable]
const int kSizeBig = 200 * 1024 * 1024 / sizeof(int);  // 200MB
          ^

BUG=82385
TBR=huangs

Review-Url: https://codereview.chromium.org/2036393002
Cr-Commit-Position: refs/heads/master@{#397810}

[modify] https://crrev.com/d36b726bc7c984f2fe151c86f4221c27ecc67b99/courgette/third_party/bsdiff/paged_array_unittest.cc

Blockedon: 618038
Blockedon: -618038
Blockedon: 618511
Blockedon: 621087
Components: Infra>Platform>Buildbot
Components: -Infra
Blockedon: 622339
Blockedon: 622715
Blockedon: -622715

Comment 700 by h...@chromium.org, Jun 23 2016

Blockedon: 622923
Blockedon: 623099
Blockedon: 623209
Blockedon: 621999
Blockedon: 624523
Blockedon: 625175
Blockedon: 626336
Blockedon: 626477
Blockedon: 618440
Blockedon: 629141
Blockedon: 633277
Project Member

Comment 711 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/478bb211feab78414d71bc3f8774ec2ed10603e0

commit 478bb211feab78414d71bc3f8774ec2ed10603e0
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 02 11:10:18 2016

win: Remove unused function after https://codereview.chromium.org/2143893002

Fixes a Wunused-function build error in official win builds with clang.

BUG=600915,82385
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/2203623003 .

Cr-Commit-Position: refs/heads/master@{#409171}

[modify] https://crrev.com/478bb211feab78414d71bc3f8774ec2ed10603e0/chrome/installer/setup/app_launcher_installer.cc

Blockedon: 633629
Blockedon: 636111
Project Member

Comment 714 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a12428ef8305fdef30afb91bac6d8c616ed366

commit e5a12428ef8305fdef30afb91bac6d8c616ed366
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Aug 17 16:16:01 2016

allocator_shim_unittest.cc: Fix unused variable

Clang warns about this.

BUG=82385
R=rnk@chromium.org
TBR=primiano

Review URL: https://codereview.chromium.org/2258503002 .

Cr-Commit-Position: refs/heads/master@{#412551}

[modify] https://crrev.com/e5a12428ef8305fdef30afb91bac6d8c616ed366/base/allocator/allocator_shim_unittest.cc

Blockedon: 637456
Blockedon: 639853
Blockedon: 627273

Comment 718 by h...@chromium.org, Aug 22 2016

Blockedon: 640000

Comment 719 by r...@chromium.org, Aug 25 2016

Cc: amccarth@google.com
Blockedon: 642027
Blockedon: 642351
Blockedon: 644768
Blockedon: 644841
Blockedon: 645544
Project Member

Comment 725 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2294ed307041c83eb7858ac65d8fecca483d04

commit 3a2294ed307041c83eb7858ac65d8fecca483d04
Author: thakis <thakis@chromium.org>
Date: Mon Sep 12 22:38:49 2016

clang docs: Be a bit more confident about debug info on Windows.

BUG=82385

Review-Url: https://codereview.chromium.org/2336793002
Cr-Commit-Position: refs/heads/master@{#418081}

[modify] https://crrev.com/3a2294ed307041c83eb7858ac65d8fecca483d04/docs/clang.md

Cc: -pkasting@chromium.org
Blockedon: 646451
Blockedon: 659219
Blockedon: 659765
Blockedon: 617318
Blockedon: 666152
Blockedon: 667891
Blockedon: 668203
Blockedon: 668207
Blockedon: 668212
Blockedon: 666994
Blockedon: 668748
Project Member

Comment 738 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ab563f0339d827c3b167e506fb0d56b42c11d450

commit ab563f0339d827c3b167e506fb0d56b42c11d450
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Dec 01 18:30:07 2016

chromium.perf.fyi: Set up a bot to compare Win Clang Perf results against.

The new bot uses the MSVC build produced by Win Builder FYI, and runs
the benchmarks on the same machine as Win Clang Perf. This should give
us something to compare the Win Clang Perf numbers against.

BUG=82385

Change-Id: Idcef394083c80bfa9726742f1cb22a00b2e393da
Reviewed-on: https://chromium-review.googlesource.com/414622
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Mike Stipicevic <stip@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>

[modify] https://crrev.com/ab563f0339d827c3b167e506fb0d56b42c11d450/masters/master.chromium.perf.fyi/master.cfg
[modify] https://crrev.com/ab563f0339d827c3b167e506fb0d56b42c11d450/masters/master.chromium.perf.fyi/slaves.cfg
[modify] https://crrev.com/ab563f0339d827c3b167e506fb0d56b42c11d450/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
[modify] https://crrev.com/ab563f0339d827c3b167e506fb0d56b42c11d450/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Builder_FYI.json
[add] https://crrev.com/ab563f0339d827c3b167e506fb0d56b42c11d450/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Perf_Ref.json

Project Member

Comment 739 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/30b4f948d7522cd89b45f07f015b5bde6e78547f

commit 30b4f948d7522cd89b45f07f015b5bde6e78547f
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Dec 01 21:57:16 2016

Blockedon: 671663
Blockedon: 672115

Comment 742 by h...@chromium.org, Dec 16 2016

Blockedon: 675018
I've been looking at Chrome binary sizes and making fixes to reduce them in the context of VC++.  Some of the tooling might be applicable to investigating the size of the binaries produced by clang-cl.

I did local non-official x86 builds of chrome:

is_component_build = false
is_debug = false
target_cpu = "x86"

with and without is_clang = true. The VC++ binary sizes are similar to the official build sizes, but the clang-cl binaries are larger. The size increase is mostly from the code segment - about 5.6 MB in chrome.dll and 7.6 MB in chrome_child.dll.

I used the SymbolSort -diff option to compare the PDBs and it found lots of claimed differences. Some of them may be due to different symbol visibility. For instance, it claims that the kPreloadedHSTSData array is present in clang-cl builds but not VC++ builds and I'm not sure that makes sense.

It claims that this function generates about three times as much code in clang-cl builds, and that seems real:

       22794         code  private: void __thiscall v8::internal::Genesis::InitializeGlobal(class v8::internal::Handle<class v8::internal::JSGlobalObject>,class v8::internal::Handle<class v8::internal::JSFunction>,enum v8::internal::GlobalContextType)

       66384         code  private: void __thiscall v8::internal::Genesis::InitializeGlobal(class v8::internal::Handle<class v8::internal::JSGlobalObject>,class v8::internal::Handle<class v8::internal::JSFunction>,enum v8::internal::GlobalContextType)

The SkColorSpaceXform_XYZ functions seem to generate much more code in clang-cl than in VC++.

There are also claims that the clang-cl binaries have many more duplicate globals, such as 4,550 copies of atomic_histogram_pointer. I'm not sure if these reports are real are spurious - I think VC++ sometimes makes these symbols invisible even to the PDB.

I could share more results but it is probably more useful to just share a link to the crude documentation I've written which includes Python scripts for high-level comparison of binaries and links to the SymbolSort repo.

I'm happy to help with the tools or analysis.

bruce: one of the blockers of this bug is about binary size (see blocker list on the left). Please post that there. (I think it's issue 462957)
Blockedon: 681800

Comment 746 Deleted

Blockedon: 682500

Comment 748 by h...@chromium.org, Jan 19 2017

Blockedon: 682754
Blockedon: 680947
Project Member

Comment 750 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5888b683fb18abfbc34fc3e75ddbb4f89b511484

commit 5888b683fb18abfbc34fc3e75ddbb4f89b511484
Author: thakis <thakis@chromium.org>
Date: Mon Jan 23 23:10:16 2017

win: Register synthetic field trial for clang builds.

That way, we'll be able to use the Finch UI to compare clang and non-clang
builds.

BUG=82385

Review-Url: https://codereview.chromium.org/2645323004
Cr-Commit-Position: refs/heads/master@{#445533}

[modify] https://crrev.com/5888b683fb18abfbc34fc3e75ddbb4f89b511484/chrome/browser/chrome_browser_main.cc

Blockedon: 690271
Blockedon: 691286
Blockedon: 691714
Blockedon: 692255
Blockedon: 692561
Blockedon: 692564
Blockedon: 693709
Blockedon: 693713
Blockedon: 693717
Blockedon: 693718
Project Member

Comment 761 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c2826bfce0d245221aab0183a0e9f3f883a7f4

commit 43c2826bfce0d245221aab0183a0e9f3f883a7f4
Author: thakis <thakis@chromium.org>
Date: Tue Feb 21 20:10:40 2017

win: Unconditionally download clang during runhooks

This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:

1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
   on 64-bit Windows due to cl not supporting inline assembly.
   clang-cl does, and building libyuv with clang-cl speeds up
   some libyuv conversion functions to take 0.4ms instead of 2ms
   per frame, so we want to try and build just libyuv with clang
   even in MSVC builds.

BUG=692600,82385

Review-Url: https://codereview.chromium.org/2702113005
Cr-Commit-Position: refs/heads/master@{#451827}

[modify] https://crrev.com/43c2826bfce0d245221aab0183a0e9f3f883a7f4/tools/clang/scripts/update.py

Blockedon: 695101
Blockedon: 695584
Blockedon: 698841
Blockedon: 698848
Blockedon: 694670
Blockedon: 700381
Blockedon: 703383
Blockedon: 703765
Blockedon: 706552
Blockedon: 708769
Blockedon: 714609
Project Member

Comment 773 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aabe7f1511ffb880612b9ec8e43fe3f7950e14a

commit 5aabe7f1511ffb880612b9ec8e43fe3f7950e14a
Author: thakis <thakis@chromium.org>
Date: Tue Apr 25 21:48:12 2017

win: /PROFILE works fine with clang.

BUG=82385

Review-Url: https://codereview.chromium.org/2838673004
Cr-Commit-Position: refs/heads/master@{#467126}

[modify] https://crrev.com/5aabe7f1511ffb880612b9ec8e43fe3f7950e14a/build/config/win/BUILD.gn

Blockedon: 715315
Blockedon: 689666
Blockedon: 716193
Blockedon: 717207
Blockedon: 722880

Comment 779 by h...@chromium.org, May 26 2017

Blockedon: 726896
Blockedon: 727193
Project Member

Comment 781 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d560ed865c053d87594aca8a72637593117d5d1b

commit d560ed865c053d87594aca8a72637593117d5d1b
Author: thakis <thakis@chromium.org>
Date: Tue May 30 01:04:54 2017

win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385

Review-Url: https://codereview.chromium.org/2870543003
Cr-Commit-Position: refs/heads/master@{#475401}

[modify] https://crrev.com/d560ed865c053d87594aca8a72637593117d5d1b/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d560ed865c053d87594aca8a72637593117d5d1b/tools/mb/mb_config.pyl

Blockedon: 727437
Blockedon: 727447
Blockedon: 727458
Blockedon: 727463
Blockedon: 727488
Blockedon: 727490
Project Member

Comment 788 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ce70bc4ae8d3a4c7431f875af32d978fb97965

commit 99ce70bc4ae8d3a4c7431f875af32d978fb97965
Author: kjellander <kjellander@chromium.org>
Date: Tue May 30 07:01:22 2017

Revert of win: Set is_clang=true by default. (patchset #6 id:100001 of https://codereview.chromium.org/2870543003/ )

Reason for revert:
Breaks many tests:
goma errors https://bugs.chromium.org/p/chromium/issues/detail?id=727488
webkit_tests is https://bugs.chromium.org/p/chromium/issues/detail?id=727463
(most of) win7 tests is https://bugs.chromium.org/p/chromium/issues/detail?id=727458

Original issue's description:
> win: Set is_clang=true by default.
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this in 5 hours if it's not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
>   info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
>   on windows links will be slow. If this affects you, please star
>   https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690,82385
>
> Review-Url: https://codereview.chromium.org/2870543003
> Cr-Commit-Position: refs/heads/master@{#475401}
> Committed: https://chromium.googlesource.com/chromium/src/+/d560ed865c053d87594aca8a72637593117d5d1b

TBR=hans@chromium.org,brettw@chromium.org,brucedawson@chromium.org,jam@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=709690,82385

Review-Url: https://codereview.chromium.org/2907363002
Cr-Commit-Position: refs/heads/master@{#475447}

[modify] https://crrev.com/99ce70bc4ae8d3a4c7431f875af32d978fb97965/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/99ce70bc4ae8d3a4c7431f875af32d978fb97965/tools/mb/mb_config.pyl

Comment 789 by h...@chromium.org, May 31 2017

Blockedon: 728324
Project Member

Comment 790 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d553d8e2aaf62876c4f810b973e248d3d31f0d11

commit d553d8e2aaf62876c4f810b973e248d3d31f0d11
Author: thakis <thakis@chromium.org>
Date: Thu Jun 01 00:44:29 2017

win: Explicitly disable symbols on bots using goma.

With MSVC, goma implicitly disables symbols in compiler.gni. With clang,
that isn't the case, so when we enable clang by default, it currently
also implicitly enables debug info on all bots using goma. Explicitly
turn off symbols on these bots. With MSVC, that's no behavior change,
and it makes sure symbols stay off when we enable clang.

BUG=82385,727488

Review-Url: https://codereview.chromium.org/2914803003
Cr-Commit-Position: refs/heads/master@{#476116}

[modify] https://crrev.com/d553d8e2aaf62876c4f810b973e248d3d31f0d11/tools/mb/mb_config.pyl

Project Member

Comment 791 by bugdroid1@chromium.org, Jun 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8476c55fd44915447233200c063fcd426dfe9807

commit 8476c55fd44915447233200c063fcd426dfe9807
Author: hans <hans@chromium.org>
Date: Sat Jun 03 03:58:11 2017

Re-commit "win: Set is_clang=true by default" over the weekend.

This relands https://codereview.chromium.org/2870543003

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this on Sunday afternoon if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690, 82385

Review-Url: https://codereview.chromium.org/2916933002
Cr-Commit-Position: refs/heads/master@{#476884}

[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/chrome/browser/prerender/prerender_browsertest.cc
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/animations/skew-notsequential-compositor-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/3d-corners-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/overflow/mask-with-filter-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/overflow/tiled-mask-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/perpendicular-layer-sorting-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/float/008-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/color-matching/image-color-matching-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-fixed-scrolling-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-opacity-overlay-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/layers-inside-overflow-scroll-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-added-filters-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-removed-filters-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/mask-with-filter-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/overflow-compositing-descendant-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scaled-mask-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scroll-ancestor-update-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/animation-inside-reflection-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/load-video-in-reflection-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/nested-reflection-mask-change-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/self-painting-layers-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/video-frame-size-change-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-group-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/pseudo/pseudo_elements_in_selectors-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-row-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-cell-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit
Blockedon: 729334
Project Member

Comment 793 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba2ff9ad0d643a443575c839e56ae9edf7106643

commit ba2ff9ad0d643a443575c839e56ae9edf7106643
Author: hans <hans@chromium.org>
Date: Mon Jun 05 02:02:06 2017

Revert of "win: Set is_clang=true by default over the weekend."

Reason for revert:
The weekend is over; time to end the experiment.

Original description:

> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
>   info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
>   on windows links will be slow. If this affects you, please star
>   https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}

BUG=709690, 82385
TBR=thakis,brettw

Review-Url: https://codereview.chromium.org/2919313002
Cr-Commit-Position: refs/heads/master@{#476921}

[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/chrome/browser/prerender/prerender_browsertest.cc
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/3d-corners-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/flat-with-transformed-child-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/vertical-scroll-composited-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/tiled-mask-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-image-layers-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-simple-video-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/float/008-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/document-flipped-blocks-writing-mode-scroll-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/repaint-in-scrolled-view-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/color-matching/image-color-matching-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-fixed-scrolling-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-opacity-overlay-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/layers-inside-overflow-scroll-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-added-filters-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-removed-filters-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/overflow-compositing-descendant-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scaled-mask-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scroll-ancestor-update-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/animation-inside-reflection-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/load-video-in-reflection-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/nested-reflection-mask-change-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/self-painting-layers-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/video-frame-size-change-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-group-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-filter-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/pseudo/pseudo_elements_in_selectors-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-row-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-cell-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/empty-cells-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests
Blockedon: 746971
Blockedon: v8:6626
Project Member

Comment 796 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87972c4b825cd655ede08778171b75a956ac515

commit b87972c4b825cd655ede08778171b75a956ac515
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 24 12:48:01 2017

clang packaging/win: Stop copying sanitizer headers to include_sanitizer directory.

Back when we were using /fallback on the asan bots, we had to add this
to the include_dir search path so that the fallback cl.exe compiler would find
asan headers as well, as it doesn't know about clang's built-in headers -- and
we couldn't add the path to clang's builtin headers as include_dir since that
would've also overriden things link stddef.h -- so we made a copy of the
builtin include dir that contained only the sanitizer directory as subdirectory.

We haven't used /fallback in years, this is no longer needed.

Effectively reverts https://codereview.chromium.org/281413006

Bug: 82385,345874
Change-Id: I9a56e17682a9a4a62815d22ad8fa67e8398b21fb
Reviewed-on: https://chromium-review.googlesource.com/582567
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488956}
[modify] https://crrev.com/b87972c4b825cd655ede08778171b75a956ac515/tools/clang/scripts/package.py
[modify] https://crrev.com/b87972c4b825cd655ede08778171b75a956ac515/tools/clang/scripts/update.py

Blockedon: 749768
Blockedon: -749768
Project Member

Comment 799 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2c91228a51bdf37ae3b2e501fb53c0528f1629c

commit d2c91228a51bdf37ae3b2e501fb53c0528f1629c
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Jul 28 20:11:05 2017

win: Set is_clang=true by default

A notification will be sent to chromium-dev if this sticks.

Some blink baselines shift due to different rounding behaviour. In the
majority of cases, this means the Windows and Mac/Linux baselines now
become identical.

This also switches win_clang bots to use MSVC as compiler, to make sure
things stay compilable with MSVC.

Known problems:
* Build times without goma are slower (but you can do goma builds with
  debug info now, which are faster).
* Incremental linking of webcore.dll doesn't work (see crbug.com/717207
  and crbug.com/560475)

BUG=82385,709690

Change-Id: I67421a5aee2259cf98b93d34d69a3314dbd98304
Reviewed-on: https://chromium-review.googlesource.com/588077
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490494}
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/chrome/browser/prerender/prerender_browsertest.cc
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/animations/skew-notsequential-compositor-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/3d-corners-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/overflow/mask-with-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/overflow/tiled-mask-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/perpendicular-layer-sorting-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/effect-blur-hw-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/fast/media/mq-color-gamut-picture-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/images/color-profile-layer-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/3d-corners-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-large-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/flat-with-transformed-child-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/vertical-scroll-composited-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/tiled-mask-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-reflection-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-image-layers-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-simple-video-layer-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-gradient-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/media/mq-color-gamut-picture-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/images/sprite-no-bleed-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/document-flipped-blocks-writing-mode-scroll-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/repaint-in-scrolled-view-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/transformed-text-fill-pattern-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-group-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-layer-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/png-suite/test-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/sprite-no-bleed-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-rotate-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-fade-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-object-fit-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-svg-resource-url-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/png-suite/test-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossless-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-alpha-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng/fast/block/float/021-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng/fast/block/margin-collapse/104-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr
Blockedon: 750446
Blockedon: 750447
Blockedon: -727437
Blockedon: -726896
Blockedon: 751220
Blockedon: 751225
Blockedon: 750923
Blockedon: 750703
Blockedon: 751634
Blockedon: 752057
Blockedon: 752168
Blockedon: 752872
Blockedon: 754277
Blockedon: 753169
Blockedon: 755611
Blockedon: 756555
Blockedon: 755863
Blockedon: 757042
Blockedon: 757114
Project Member

Comment 819 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6

commit 7cd2f6bd73c6a9c6200704e995b18ebb3168ead6
Author: Nico Weber <thakis@chromium.org>
Date: Sat Aug 19 04:23:54 2017

win: Turn off clang-by-default again for now.

Debug info quality isn't quite yet where we want it (which also affects
minidump quality).

Reverts https://chromium-review.googlesource.com/588077 (with fresh
rebaselines).

Bug: 82385,709690
Change-Id: I00d774fd5d4bcf5ffced1832ee31aae84942c69e
Reviewed-on: https://chromium-review.googlesource.com/621748
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495802}
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-units-02-b-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/tools/mb/mb_config.pyl

Cc: mbonadei@chromium.org kjellander@chromium.org ehmaldonado@chromium.org
Adding WebRTC folks so we can stay on top of this next time the flip is being made, as we were flying without MSVC coverage for a while, causing a compile regression on MSVC to sneak in.
Blockedon: 761859
Blockedon: 767451
Blockedon: 772002
Blockedon: 772003
Blockedon: 772117
Project Member

Comment 826 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75ed5bde854c3709365a2ce885c1a448d177b50

commit d75ed5bde854c3709365a2ce885c1a448d177b50
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Tue Oct 10 23:39:31 2017

Properly check LLVM_FORCE_HEAD_REVISION

LLVM_FORCE_HEAD_REVISION is supposed to trigger building the latest
version of clang-cl when it is set to 1, but it was actually triggering
this when set to anything, including zero. Change the logic so that it
only triggers when set to non-zero. Setting to non-numeric will trigger
an exception.

Bug: 82385
Change-Id: Ib4ff79b1cfc61ea97545fa26f6d1f3f20086fc1f
Reviewed-on: https://chromium-review.googlesource.com/707674
Reviewed-by: smut <smut@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507823}
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/ios/build/bots/chromium.fyi/ClangToTiOS.json
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/tools/clang/scripts/package.py
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/tools/clang/scripts/update.py

Project Member

Comment 827 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9121e14af41cfd582f3925b48832428a9c553161

commit 9121e14af41cfd582f3925b48832428a9c553161
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Oct 11 01:40:25 2017

Fix check for LLVM_FORCE_HEAD_REVISION after it was "fixed".

The bots actually use "YES", not "1", and so by trying to
"correctly" enforce it, we actually broke it in r507823 :(.

TBR=brucedawson@chromium.org
TBR=smut@google.com
TBR=thakis@chromium.org
NOTRY=true
BUG=82385, 765859

Change-Id: I4e21cbfe0403bfccbafd08b65a1392093cafc360
Reviewed-on: https://chromium-review.googlesource.com/711219
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507852}
[modify] https://crrev.com/9121e14af41cfd582f3925b48832428a9c553161/tools/clang/scripts/update.py

Blockedon: 774674
Cc: tikuta@chromium.org
Blockedon: 709690
Project Member

Comment 831 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22525134c75ca2a005997a717f6887a23af86210

commit 22525134c75ca2a005997a717f6887a23af86210
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Oct 23 17:10:25 2017

win: Re-enable Clang by default

Since the previous attempt there have been significant improvements in
debug info quality (both for debug builds and optimized builds which
affect minidumps) and link time.

Bug: 82385,709690
Change-Id: I0fef496d948855b38ce5ab93f66187798ac14b58
Reviewed-on: https://chromium-review.googlesource.com/732997
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510824}
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/build/config/BUILDCONFIG.gn
[delete] https://crrev.com/c5cbe85f310704b191dd6b6ad61e75c45c337fee/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/tools/mb/mb_config.pyl

Project Member

Comment 832 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22b22f21e78ef21e6b9622f5104a364c551750c7

commit 22b22f21e78ef21e6b9622f5104a364c551750c7
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Oct 23 17:56:51 2017

mb: Make WinClang64 (dbg) and win_clang non-Clang bots

This should have been part of #510824.

Bug: 82385,709690
Change-Id: I044d72256361991ce939bd6b840ff95d6d4754e0
Reviewed-on: https://chromium-review.googlesource.com/733852
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510840}
[modify] https://crrev.com/22b22f21e78ef21e6b9622f5104a364c551750c7/tools/mb/mb_config.pyl

Blockedon: 777579
Blockedon: 777642
Blockedon: 777924
Blockedon: 777943
Blockedon: 775174
Blockedon: 780056
Blockedon: 780124
Blockedon: 782027
Blocking: 792131
Blockedon: 805894
Project Member

Comment 843 by bugdroid1@chromium.org, Mar 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07848768b864df7a5ffa4120541cd5862a76491

commit e07848768b864df7a5ffa4120541cd5862a76491
Author: Nico Weber <thakis@chromium.org>
Date: Wed Mar 07 16:09:02 2018

win: Remove "Compiler:" line from about:version; add "Linker:" line instead.

Shipping Chrome/Wins are now always built with clang, so the Compiler:
line is no longer needed. This part reverts
https://codereview.chromium.org/1404063002 (and some follow-ups).

We do want to switch the linker eventually, so add a "Linker:" line instead.

Bug: 82385,530785,792131
Change-Id: I0ecee267e468e04ee10590e1396df8c49110e595
Reviewed-on: https://chromium-review.googlesource.com/952486
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541448}
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/resources/about_version.html
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/version_ui_constants.cc
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/version_ui_constants.h

thakis, do you think we should close this bug now?
Is there data on how the NewTabPage metric was improved due to the recent work? I recall it regressed by 5% when we made the clang switch originally.
Status: Fixed
> thakis, do you think we should close this bug now?

It was deployed, so I think we should :-)

> Is there data on how the NewTabPage metric was improved due to the recent work? I recall it regressed by 5% when we made the clang switch originally.

There hasn't been recent work targeting NewTagPage.LoadTime. The recent patches to enable order files for lld was just to not regress when we switch linkers.

The work done before the Clang switch brought the metric from a slightly more than 5% regression to slightly less. I don't know how the metric has moved since then, but I'd expect it to improve when we start using LTO and PGO.

(Ideally it would be nice if the NTP could be made faster in itself. IIRC the median load time in the wild is something like 4000 ms which is pretty sad.)
> (Ideally it would be nice if the NTP could be made faster in itself. IIRC the median load time in the wild is something like 4000 ms which is pretty sad.)

(Seems I remembered incorrectly: the median is more like 800 ms; 75% and 90%-ile are multiple seconds though.)
asvitkine: see issue 728324 for NewTabPage metric improvement work; it happened a while ago though. We did mitigate the 5% regression iirc.
Awesome, thanks!
Blockedon: -615050
Showing comments 351 - 850 of 850 Older

Sign in to add a comment