New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 82385 link

Starred by 49 users

Issue metadata

Status: Fixed
Owner:
ooo
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocked on: View detail
issue 462957
issue 598772
issue 617318
issue 623209
issue 636111
issue 659765
issue 666152
issue 672115
issue 700381
issue 703383
issue 703765
issue 752872
issue 753169
issue 757114
issue 767451
issue 772003
issue 772117
issue 774674
issue 782027
issue angleproject:736
issue 342069
issue 343960
issue 363676
issue 377008
issue 390990
issue 391347
issue 395405
issue 395843
issue 397585
issue 403594
issue 404525
issue 406957
issue 408313
issue 409105
issue 409399
issue 412902
issue 413266
issue 413478
issue 413727
issue 416269
issue 416747
issue 420328
issue 429498
issue 429752
issue 430101
issue 437916
issue 438382
issue 439761
issue 441052
issue 441053
issue 444904
issue 445406
issue 446368
issue 446374
issue 448935
issue 451078
issue 451290
issue 451454
issue 452694
issue 453691
issue 454118
issue 454590
issue 455488
issue 455966
issue 457003
issue 457078
issue 458266
issue 458545
issue 459797
issue 460381
issue 463906
issue 463926
issue 465015
issue 466627
issue 466752
issue 467287
issue 467925
issue 467927
issue 467928
issue 467929
issue 469813
issue 470689
issue 471868
issue 473978
issue 475643
issue 475768
issue 476316
issue 476317
issue 477476
issue 477986
issue 477988
issue 477994
issue 478419
issue 479328
issue 480015
issue 480091
issue 480546
issue 481029
issue 482292
issue 482294
issue 482703
issue 483065
issue 483367
issue 484903
issue 487346
issue 488156
issue 488634
issue 491209
issue 492283
issue 494442
issue 495396
issue 495773
issue 496928
issue 496975
issue 497826
issue 498033
issue 498276
issue 498544
issue 499336
issue 499673
issue 500934
issue 501367
issue 503684
issue 503687
issue 504017
issue 504657
issue 505888
issue 505916
issue 506038
issue 506446
issue 506453
issue 507826
issue 508948
issue 508955
issue 509161
issue 509256
issue 510555
issue 511837
issue 514512
issue 515604
issue 518191
issue 518204
issue 520982
issue 520986
issue 521298
issue 521652
issue 521788
issue 522165
issue 522804
issue 524308
issue 524604
issue 525131
issue 525897
issue 526741
issue 530785
issue 531802
issue 533183
issue 534665
issue 536726
issue 536963
issue 540897
issue 543182
issue 544127
issue 547142
issue 548295
issue 548348
issue 549765
issue 552241
issue 552909
issue 556735
issue 557968
issue 560836
issue 560972
issue 562308
issue 564691
issue 565700
issue 566751
issue 567205
issue 567877
issue 568610
issue 568781
issue 569340
issue 569633
issue 569964
issue 570775
issue 571497
issue 572237
issue 574490
issue 575700
issue 576773
issue 576774
issue 576842
issue 577620
issue 580241
issue 581845
issue 582570
issue 583674
issue 583676
issue 586243
issue 586511
issue 586525
issue 586590
issue 586714
issue 587530
issue 587835
issue 587843
issue 588518
issue 589977
issue 590086
issue 590221
issue 591437
issue 592745
issue 594360
issue 594361
issue 595050
issue 595702
issue 596201
issue 596366
issue 597549
issue 598316
issue 598344
issue 598761
issue 598767
issue 598807
issue 598849
issue 598943
issue 600157
issue 600775
issue 602265
issue 603935
issue 604034
issue 605570
issue 606810
issue 607197
issue 608705
issue 608901
issue 610367
issue 615437
issue 616152
issue 618440
issue 618511
issue 621087
issue 621999
issue 622339
issue 622923
issue 623099
issue 624523
issue 625175
issue 626336
issue 626477
issue 627273
issue 629141
issue 633277
issue 633629
issue 637456
issue 639853
issue 640000
issue 642027
issue 642351
issue 644768
issue 644841
issue 645544
issue 646451
issue 659219
issue 666994
issue 667891
issue 668203
issue 668207
issue 668212
issue 668748
issue 671663
issue 675018
issue 680947
issue 681800
issue 682500
issue 682754
issue 689666
issue 690271
issue 691286
issue 691714
issue 692255
issue 692561
issue 692564
issue 693709
issue 693713
issue 693717
issue 693718
issue 694670
issue 695101
issue 695584
issue 698841
issue 698848
issue 706552
issue 708769
issue 709690
issue 714609
issue 715315
issue 716193
issue 717207
issue 722880
issue 727193
issue 727447
issue 727458
issue 727463
issue 727488
issue 727490
issue 728324
issue 729334
issue 746971
issue v8:6626
issue 750446
issue 750447
issue 750703
issue 750923
issue 751220
issue 751225
issue 751634
issue 752057
issue 752168
issue 754277
issue 755611
issue 755863
issue 756555
issue 757042
issue 761859
issue 772002
issue 775174
issue 777579
issue 777642
issue 777924
issue 777943
issue 780056
issue 780124
issue 805894

Blocking:
issue 429328
issue 109558
issue 109559
issue 345874
issue 792131



Sign in to add a comment

Deploy Clang on windows

Project Member Reported by thakis@chromium.org, May 12 2011

Issue description

clang's -fms-extensions support has improved dramatically. We should look into how viable building chrome on windows is with clang.
 
Showing comments 751 - 850 of 850 Older
Blockedon: 690271
Blockedon: 691286
Blockedon: 691714
Blockedon: 692255
Blockedon: 692561
Blockedon: 692564
Blockedon: 693709
Blockedon: 693713
Blockedon: 693717
Blockedon: 693718
Project Member

Comment 761 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c2826bfce0d245221aab0183a0e9f3f883a7f4

commit 43c2826bfce0d245221aab0183a0e9f3f883a7f4
Author: thakis <thakis@chromium.org>
Date: Tue Feb 21 20:10:40 2017

win: Unconditionally download clang during runhooks

This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:

1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
   on 64-bit Windows due to cl not supporting inline assembly.
   clang-cl does, and building libyuv with clang-cl speeds up
   some libyuv conversion functions to take 0.4ms instead of 2ms
   per frame, so we want to try and build just libyuv with clang
   even in MSVC builds.

BUG=692600, 82385 

Review-Url: https://codereview.chromium.org/2702113005
Cr-Commit-Position: refs/heads/master@{#451827}

[modify] https://crrev.com/43c2826bfce0d245221aab0183a0e9f3f883a7f4/tools/clang/scripts/update.py

Blockedon: 695101
Blockedon: 695584
Blockedon: 698841
Blockedon: 698848
Blockedon: 694670
Blockedon: 700381
Blockedon: 703383
Blockedon: 703765
Blockedon: 706552
Blockedon: 708769
Blockedon: 714609
Project Member

Comment 773 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aabe7f1511ffb880612b9ec8e43fe3f7950e14a

commit 5aabe7f1511ffb880612b9ec8e43fe3f7950e14a
Author: thakis <thakis@chromium.org>
Date: Tue Apr 25 21:48:12 2017

win: /PROFILE works fine with clang.

BUG= 82385 

Review-Url: https://codereview.chromium.org/2838673004
Cr-Commit-Position: refs/heads/master@{#467126}

[modify] https://crrev.com/5aabe7f1511ffb880612b9ec8e43fe3f7950e14a/build/config/win/BUILD.gn

Blockedon: 715315
Blockedon: 689666
Blockedon: 716193
Blockedon: 717207
Blockedon: 722880

Comment 779 by h...@chromium.org, May 26 2017

Blockedon: 726896
Blockedon: 727193
Project Member

Comment 781 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d560ed865c053d87594aca8a72637593117d5d1b

commit d560ed865c053d87594aca8a72637593117d5d1b
Author: thakis <thakis@chromium.org>
Date: Tue May 30 01:04:54 2017

win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
   https://crbug.com/717207  and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690, 82385 

Review-Url: https://codereview.chromium.org/2870543003
Cr-Commit-Position: refs/heads/master@{#475401}

[modify] https://crrev.com/d560ed865c053d87594aca8a72637593117d5d1b/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d560ed865c053d87594aca8a72637593117d5d1b/tools/mb/mb_config.pyl

Blockedon: 727437
Blockedon: 727447
Blockedon: 727458
Blockedon: 727463
Blockedon: 727488
Blockedon: 727490
Project Member

Comment 788 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ce70bc4ae8d3a4c7431f875af32d978fb97965

commit 99ce70bc4ae8d3a4c7431f875af32d978fb97965
Author: kjellander <kjellander@chromium.org>
Date: Tue May 30 07:01:22 2017

Revert of win: Set is_clang=true by default. (patchset #6 id:100001 of https://codereview.chromium.org/2870543003/ )

Reason for revert:
Breaks many tests:
goma errors https://bugs.chromium.org/p/chromium/issues/detail?id=727488
webkit_tests is https://bugs.chromium.org/p/chromium/issues/detail?id=727463
(most of) win7 tests is https://bugs.chromium.org/p/chromium/issues/detail?id=727458

Original issue's description:
> win: Set is_clang=true by default.
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this in 5 hours if it's not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
>   info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
>   on windows links will be slow. If this affects you, please star
>    https://crbug.com/717207  and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385 
>
> Review-Url: https://codereview.chromium.org/2870543003
> Cr-Commit-Position: refs/heads/master@{#475401}
> Committed: https://chromium.googlesource.com/chromium/src/+/d560ed865c053d87594aca8a72637593117d5d1b

TBR=hans@chromium.org,brettw@chromium.org,brucedawson@chromium.org,jam@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=709690, 82385 

Review-Url: https://codereview.chromium.org/2907363002
Cr-Commit-Position: refs/heads/master@{#475447}

[modify] https://crrev.com/99ce70bc4ae8d3a4c7431f875af32d978fb97965/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/99ce70bc4ae8d3a4c7431f875af32d978fb97965/tools/mb/mb_config.pyl

Comment 789 by h...@chromium.org, May 31 2017

Blockedon: 728324
Project Member

Comment 790 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d553d8e2aaf62876c4f810b973e248d3d31f0d11

commit d553d8e2aaf62876c4f810b973e248d3d31f0d11
Author: thakis <thakis@chromium.org>
Date: Thu Jun 01 00:44:29 2017

win: Explicitly disable symbols on bots using goma.

With MSVC, goma implicitly disables symbols in compiler.gni. With clang,
that isn't the case, so when we enable clang by default, it currently
also implicitly enables debug info on all bots using goma. Explicitly
turn off symbols on these bots. With MSVC, that's no behavior change,
and it makes sure symbols stay off when we enable clang.

BUG= 82385 , 727488 

Review-Url: https://codereview.chromium.org/2914803003
Cr-Commit-Position: refs/heads/master@{#476116}

[modify] https://crrev.com/d553d8e2aaf62876c4f810b973e248d3d31f0d11/tools/mb/mb_config.pyl

Project Member

Comment 791 by bugdroid1@chromium.org, Jun 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8476c55fd44915447233200c063fcd426dfe9807

commit 8476c55fd44915447233200c063fcd426dfe9807
Author: hans <hans@chromium.org>
Date: Sat Jun 03 03:58:11 2017

Re-commit "win: Set is_clang=true by default" over the weekend.

This relands https://codereview.chromium.org/2870543003

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this on Sunday afternoon if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
   https://crbug.com/717207  and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,  82385 

Review-Url: https://codereview.chromium.org/2916933002
Cr-Commit-Position: refs/heads/master@{#476884}

[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/chrome/browser/prerender/prerender_browsertest.cc
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/animations/skew-notsequential-compositor-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/3d-corners-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/overflow/mask-with-filter-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/overflow/tiled-mask-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/perpendicular-layer-sorting-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.png
[rename] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/float/008-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/color-matching/image-color-matching-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-fixed-scrolling-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-opacity-overlay-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/layers-inside-overflow-scroll-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-added-filters-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-removed-filters-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/mask-with-filter-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/overflow-compositing-descendant-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scaled-mask-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scroll-ancestor-update-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/animation-inside-reflection-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/load-video-in-reflection-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/nested-reflection-mask-change-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/self-painting-layers-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/video-frame-size-change-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-group-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[delete] https://crrev.com/7486e37f46e1960620a8ea832cdbad356ae84916/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/pseudo/pseudo_elements_in_selectors-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-row-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-cell-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-expected.png
[add] https://crrev.com/8476c55fd44915447233200c063fcd426dfe9807/third_party/WebKit
Blockedon: 729334
Project Member

Comment 793 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba2ff9ad0d643a443575c839e56ae9edf7106643

commit ba2ff9ad0d643a443575c839e56ae9edf7106643
Author: hans <hans@chromium.org>
Date: Mon Jun 05 02:02:06 2017

Revert of "win: Set is_clang=true by default over the weekend."

Reason for revert:
The weekend is over; time to end the experiment.

Original description:

> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
>   info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
>   on windows links will be slow. If this affects you, please star
>    https://crbug.com/717207  and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690,  82385 
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}

BUG=709690,  82385 
TBR=thakis,brettw

Review-Url: https://codereview.chromium.org/2919313002
Cr-Commit-Position: refs/heads/master@{#476921}

[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/chrome/browser/prerender/prerender_browsertest.cc
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/3d-corners-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/flat-with-transformed-child-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/vertical-scroll-composited-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/tiled-mask-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-image-layers-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-simple-video-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/float/008-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/document-flipped-blocks-writing-mode-scroll-expected.png
[rename] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/repaint-in-scrolled-view-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/color-matching/image-color-matching-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-fixed-scrolling-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/video-opacity-overlay-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/layers-inside-overflow-scroll-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-added-filters-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/masks/mask-with-removed-filters-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/overflow-compositing-descendant-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scaled-mask-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/scroll-ancestor-update-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/animation-inside-reflection-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/load-video-in-reflection-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/reflections/nested-reflection-mask-change-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/self-painting-layers-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/video-frame-size-change-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-group-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-layer-filter-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[add] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/pseudo/pseudo_elements_in_selectors-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_position-table-row-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-cell-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-column-group-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[delete] https://crrev.com/4fc92db39612f3016983a68394d225ac0cbecb6b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/empty-cells-expected.png
[copy] https://crrev.com/ba2ff9ad0d643a443575c839e56ae9edf7106643/third_party/WebKit/LayoutTests
Blockedon: 746971
Blockedon: v8:6626
Project Member

Comment 796 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87972c4b825cd655ede08778171b75a956ac515

commit b87972c4b825cd655ede08778171b75a956ac515
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 24 12:48:01 2017

clang packaging/win: Stop copying sanitizer headers to include_sanitizer directory.

Back when we were using /fallback on the asan bots, we had to add this
to the include_dir search path so that the fallback cl.exe compiler would find
asan headers as well, as it doesn't know about clang's built-in headers -- and
we couldn't add the path to clang's builtin headers as include_dir since that
would've also overriden things link stddef.h -- so we made a copy of the
builtin include dir that contained only the sanitizer directory as subdirectory.

We haven't used /fallback in years, this is no longer needed.

Effectively reverts https://codereview.chromium.org/281413006

Bug:  82385 , 345874 
Change-Id: I9a56e17682a9a4a62815d22ad8fa67e8398b21fb
Reviewed-on: https://chromium-review.googlesource.com/582567
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488956}
[modify] https://crrev.com/b87972c4b825cd655ede08778171b75a956ac515/tools/clang/scripts/package.py
[modify] https://crrev.com/b87972c4b825cd655ede08778171b75a956ac515/tools/clang/scripts/update.py

Blockedon: 749768
Blockedon: -749768
Project Member

Comment 799 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2c91228a51bdf37ae3b2e501fb53c0528f1629c

commit d2c91228a51bdf37ae3b2e501fb53c0528f1629c
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Jul 28 20:11:05 2017

win: Set is_clang=true by default

A notification will be sent to chromium-dev if this sticks.

Some blink baselines shift due to different rounding behaviour. In the
majority of cases, this means the Windows and Mac/Linux baselines now
become identical.

This also switches win_clang bots to use MSVC as compiler, to make sure
things stay compilable with MSVC.

Known problems:
* Build times without goma are slower (but you can do goma builds with
  debug info now, which are faster).
* Incremental linking of webcore.dll doesn't work (see  crbug.com/717207 
  and  crbug.com/560475 )

BUG= 82385 ,709690

Change-Id: I67421a5aee2259cf98b93d34d69a3314dbd98304
Reviewed-on: https://chromium-review.googlesource.com/588077
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490494}
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/chrome/browser/prerender/prerender_browsertest.cc
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/animations/skew-notsequential-compositor-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/3d-corners-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/culling/filter-occlusion-blur-large-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/lots-of-img-layers-with-opacity-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/overflow/mask-with-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/overflow/tiled-mask-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/perpendicular-layer-sorting-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/compositing/video/video-reflection-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/effect-blur-hw-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-change-repaint-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/fast/media/mq-color-gamut-picture-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/images/color-profile-layer-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.png
[rename] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/animations/skew-notsequential-compositor-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/3d-corners-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/culling/filter-occlusion-blur-large-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/flat-with-transformed-child-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/vertical-scroll-composited-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/mask-with-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/tiled-mask-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/perpendicular-layer-sorting-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-reflection-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-image-layers-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/compositing/visibility/visibility-simple-video-layer-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-blur-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-combined-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-drop-shadow-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-composited-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-change-repaint-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-composited-fallback-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-gradient-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-luminance-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-round-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-border-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-lr/002-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/block/positioning/vertical-rl/002-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/fast/media/mq-color-gamut-picture-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/images/sprite-no-bleed-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/color-profile-video-seek-object-fit-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/video-canvas-alpha-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/media/video-remove-insert-repaints-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/document-flipped-blocks-writing-mode-scroll-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/repaint-in-scrolled-view-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/custom/object-sizing-no-width-height-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/transformed-text-fill-pattern-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug137388-2-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-group-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-layer-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-layer-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/png-suite/test-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/sprite-no-bleed-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-rotate-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-fade-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-object-fit-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-svg-resource-url-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/exif-orientation-height-image-document-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-yuv-progressive-image-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/png-suite/test-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/rgb-png-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossless-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-alpha-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/ycbcr-with-cmyk-color-profile-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-drawImage-video-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png
[delete] https://crrev.com/6b77de397205be39a04132ce7895b8e9121efd74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng/fast/block/float/021-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng/fast/block/margin-collapse/104-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/023-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/040-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-cell-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-column-group-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_border-table-row-group-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-hide-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr_layers-show-collapsed-border-expected.png
[add] https://crrev.com/d2c91228a51bdf37ae3b2e501fb53c0528f1629c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/backgr
Blockedon: 750446
Blockedon: 750447
Blockedon: -727437
Blockedon: -726896
Blockedon: 751220
Blockedon: 751225
Blockedon: 750923
Blockedon: 750703
Blockedon: 751634
Blockedon: 752057
Blockedon: 752168
Blockedon: 752872
Blockedon: 754277
Blockedon: 753169
Blockedon: 755611
Blockedon: 756555
Blockedon: 755863
Blockedon: 757042
Blockedon: 757114
Project Member

Comment 819 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6

commit 7cd2f6bd73c6a9c6200704e995b18ebb3168ead6
Author: Nico Weber <thakis@chromium.org>
Date: Sat Aug 19 04:23:54 2017

win: Turn off clang-by-default again for now.

Debug info quality isn't quite yet where we want it (which also affects
minidump quality).

Reverts https://chromium-review.googlesource.com/588077 (with fresh
rebaselines).

Bug:  82385 ,709690
Change-Id: I00d774fd5d4bcf5ffced1832ee31aae84942c69e
Reviewed-on: https://chromium-review.googlesource.com/621748
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495802}
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-units-02-b-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/7cd2f6bd73c6a9c6200704e995b18ebb3168ead6/tools/mb/mb_config.pyl

Cc: mbonadei@chromium.org kjellander@chromium.org ehmaldonado@chromium.org
Adding WebRTC folks so we can stay on top of this next time the flip is being made, as we were flying without MSVC coverage for a while, causing a compile regression on MSVC to sneak in.
Blockedon: 761859
Blockedon: 767451
Blockedon: 772002
Blockedon: 772003
Blockedon: 772117
Project Member

Comment 826 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75ed5bde854c3709365a2ce885c1a448d177b50

commit d75ed5bde854c3709365a2ce885c1a448d177b50
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Tue Oct 10 23:39:31 2017

Properly check LLVM_FORCE_HEAD_REVISION

LLVM_FORCE_HEAD_REVISION is supposed to trigger building the latest
version of clang-cl when it is set to 1, but it was actually triggering
this when set to anything, including zero. Change the logic so that it
only triggers when set to non-zero. Setting to non-numeric will trigger
an exception.

Bug:  82385 
Change-Id: Ib4ff79b1cfc61ea97545fa26f6d1f3f20086fc1f
Reviewed-on: https://chromium-review.googlesource.com/707674
Reviewed-by: smut <smut@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507823}
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/ios/build/bots/chromium.fyi/ClangToTiOS.json
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/tools/clang/scripts/package.py
[modify] https://crrev.com/d75ed5bde854c3709365a2ce885c1a448d177b50/tools/clang/scripts/update.py

Project Member

Comment 827 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9121e14af41cfd582f3925b48832428a9c553161

commit 9121e14af41cfd582f3925b48832428a9c553161
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Oct 11 01:40:25 2017

Fix check for LLVM_FORCE_HEAD_REVISION after it was "fixed".

The bots actually use "YES", not "1", and so by trying to
"correctly" enforce it, we actually broke it in r507823 :(.

TBR=brucedawson@chromium.org
TBR=smut@google.com
TBR=thakis@chromium.org
NOTRY=true
BUG= 82385 , 765859

Change-Id: I4e21cbfe0403bfccbafd08b65a1392093cafc360
Reviewed-on: https://chromium-review.googlesource.com/711219
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507852}
[modify] https://crrev.com/9121e14af41cfd582f3925b48832428a9c553161/tools/clang/scripts/update.py

Blockedon: 774674
Cc: tikuta@chromium.org
Blockedon: 709690
Project Member

Comment 831 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22525134c75ca2a005997a717f6887a23af86210

commit 22525134c75ca2a005997a717f6887a23af86210
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Oct 23 17:10:25 2017

win: Re-enable Clang by default

Since the previous attempt there have been significant improvements in
debug info quality (both for debug builds and optimized builds which
affect minidumps) and link time.

Bug:  82385 ,709690
Change-Id: I0fef496d948855b38ce5ab93f66187798ac14b58
Reviewed-on: https://chromium-review.googlesource.com/732997
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510824}
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/build/config/BUILDCONFIG.gn
[delete] https://crrev.com/c5cbe85f310704b191dd6b6ad61e75c45c337fee/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/border-collapsing/001-expected.png
[modify] https://crrev.com/22525134c75ca2a005997a717f6887a23af86210/tools/mb/mb_config.pyl

Project Member

Comment 832 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22b22f21e78ef21e6b9622f5104a364c551750c7

commit 22b22f21e78ef21e6b9622f5104a364c551750c7
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Oct 23 17:56:51 2017

mb: Make WinClang64 (dbg) and win_clang non-Clang bots

This should have been part of #510824.

Bug:  82385 ,709690
Change-Id: I044d72256361991ce939bd6b840ff95d6d4754e0
Reviewed-on: https://chromium-review.googlesource.com/733852
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510840}
[modify] https://crrev.com/22b22f21e78ef21e6b9622f5104a364c551750c7/tools/mb/mb_config.pyl

Blockedon: 777579
Blockedon: 777642
Blockedon: 777924
Blockedon: 777943
Blockedon: 775174
Blockedon: 780056
Blockedon: 780124

Comment 840 by h...@chromium.org, Nov 16 2017

Blockedon: 782027
Blocking: 792131
Blockedon: 805894
Project Member

Comment 843 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07848768b864df7a5ffa4120541cd5862a76491

commit e07848768b864df7a5ffa4120541cd5862a76491
Author: Nico Weber <thakis@chromium.org>
Date: Wed Mar 07 16:09:02 2018

win: Remove "Compiler:" line from about:version; add "Linker:" line instead.

Shipping Chrome/Wins are now always built with clang, so the Compiler:
line is no longer needed. This part reverts
https://codereview.chromium.org/1404063002 (and some follow-ups).

We do want to switch the linker eventually, so add a "Linker:" line instead.

Bug:  82385 , 530785 , 792131 
Change-Id: I0ecee267e468e04ee10590e1396df8c49110e595
Reviewed-on: https://chromium-review.googlesource.com/952486
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541448}
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/resources/about_version.html
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/version_ui_constants.cc
[modify] https://crrev.com/e07848768b864df7a5ffa4120541cd5862a76491/components/version_ui/version_ui_constants.h

thakis, do you think we should close this bug now?
Is there data on how the NewTabPage metric was improved due to the recent work? I recall it regressed by 5% when we made the clang switch originally.

Comment 846 by h...@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)
> thakis, do you think we should close this bug now?

It was deployed, so I think we should :-)

> Is there data on how the NewTabPage metric was improved due to the recent work? I recall it regressed by 5% when we made the clang switch originally.

There hasn't been recent work targeting NewTagPage.LoadTime. The recent patches to enable order files for lld was just to not regress when we switch linkers.

The work done before the Clang switch brought the metric from a slightly more than 5% regression to slightly less. I don't know how the metric has moved since then, but I'd expect it to improve when we start using LTO and PGO.

(Ideally it would be nice if the NTP could be made faster in itself. IIRC the median load time in the wild is something like 4000 ms which is pretty sad.)

Comment 847 by h...@chromium.org, Mar 21 2018

> (Ideally it would be nice if the NTP could be made faster in itself. IIRC the median load time in the wild is something like 4000 ms which is pretty sad.)

(Seems I remembered incorrectly: the median is more like 800 ms; 75% and 90%-ile are multiple seconds though.)
asvitkine: see  issue 728324  for NewTabPage metric improvement work; it happened a while ago though. We did mitigate the 5% regression iirc.
Awesome, thanks!
Blockedon: -615050
Showing comments 751 - 850 of 850 Older

Sign in to add a comment