New tab grid mistakenly opens incognito tabs |
||||||||||
Issue descriptionChrome Dev build 67.0.3376.0 What steps will reproduce the problem? (1) Turn on flag for new tab grid (2) Go to tab grid (3) Switch to incognito mode and open a tab. Use it a bit. (4) Go to tab switcher and go to regular (non-incognito) tabs (5) Hit + to open a new tab Observed result: Sometimes this new tab opens as an incognito tab Expected result: New tab should not be incognito since it wasn't opened from the incognito tab grid
,
Mar 20 2018
,
Mar 20 2018
The same new tab button is used for both regular and incognito, depending on the context. The context change is determined after the scroll has fully completed. If you tap the button during the page scroll, the behavior will still be tied to the previous page. This is considered part of the user story S-Open-New-Tab, which is planned for Q2. If we need to do a priority shift for the user study, please let me know. Otherwise, I will consider this part of crbug.com/804584 , which will be fixed in Q2. I'm assigning this back to ghendel@ to assess priority of fix.
,
Mar 20 2018
I decided to make a quick fix for this today.
,
Mar 20 2018
CL in-flight.
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6672f6a2ef29fecf51f07f292b7bab8a30a86f2e commit 6672f6a2ef29fecf51f07f292b7bab8a30a86f2e Author: edchin <edchin@chromium.org> Date: Thu Mar 22 13:58:04 2018 [ios] Make new tab button change appearance during page scroll Previously, the new tab button would not change until after the page scroll completed the animation. In that case, the user is able to tap on the button during the animation, which potentially resulted in the wrong type of tab being created. This CL ensures that the new tab button, as well as all other visual appearances dependent on the current page gets updated during the scroll, so it is accurate as possible. Bug: 823842 , 804580 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I541a2811929b4e0835649c64e76260f4e11962da Reviewed-on: https://chromium-review.googlesource.com/972435 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545058} [modify] https://crrev.com/6672f6a2ef29fecf51f07f292b7bab8a30a86f2e/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 22 2018
Fixed!
,
Apr 10 2018
Verified on 67.0.3393.0 Canary on iPad Pro 11.2.6, iPad Pro 10.3.3, iPhoneX iOs 11.2.6
,
Apr 26 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ghendel@google.com
, Mar 20 2018