New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823826 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

InputDeviceInfo.getCapabilities() should return null when the device has no permission

Project Member Reported by guidou@chromium.org, Mar 20 2018

Issue description

For audio devices we are currently returning  the echoCancellation capabilties.
 

Comment 1 by guidou@chromium.org, Mar 20 2018

Components: Blink>MediaStream
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce0b74f2ae908ac8920e6b6753498ee31acc1f7

commit bce0b74f2ae908ac8920e6b6753498ee31acc1f7
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Mar 21 11:32:23 2018

Return empty capabilities for devices without permission.

This fixes the issue for audio devices which always report the same
echoCancellation capabilities without permission checks.


Bug:  823826 
Change-Id: I2ac336760a843d1ff11f25a1a40fe22a57f356a2
Reviewed-on: https://chromium-review.googlesource.com/971482
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#544667}
[modify] https://crrev.com/bce0b74f2ae908ac8920e6b6753498ee31acc1f7/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.cpp

Comment 3 by guidou@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment