New issue
Advanced search Search tips

Issue 823824 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Apr 2018
Cc:
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 463348



Sign in to add a comment

Table border glitched half-way (deterministic)

Reported by timotij...@gmail.com, Mar 20 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3376.1 Safari/537.36

Example URL:
https://www.mediawiki.org/wiki/Requests_for_comment/IPv6_contributions_and_talk_pages

Steps to reproduce the problem:
1. View https://www.mediawiki.org/wiki/Requests_for_comment/IPv6_contributions_and_talk_pages, or reduced/isolated test case at https://codepen.io/Krinkle/full/rdyeKV
2. Look at the bottom-border of the info table

What is the expected behavior?
It should render as a straight line

What went wrong?
Half-way it steps down a bit.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Chrome 64

Does this work in other browsers? Yes

Chrome version: 67.0.3376.1  Channel: canary
OS Version: OS X 10.13.2
Flash Version:
M64-stable-correct.png
76.3 KB View Download
M67-canary-broken.png
128 KB View Download

Comment 1 by ebra...@gnu.org, Mar 20 2018

Blocking: 463348

Comment 2 by woxxom@gmail.com, Mar 20 2018 

Bisect info: 540982 (good) - 540995 (bad)
https://chromium.googlesource.com/chromium/src/+log/6783e46f..bad9b929?pretty=fuller
Suspecting r540991 = 14350ac7143cb3ec2a216d5f14233f532b8ca87a = https://crrev.com/c/943827 by wangxianzhu@chromium.org
"[PE] Don't truncate table cell's padding"
Landed in 67.0.3363.0
Merged to 66.0.3359.19

Comment 3 by dtapu...@chromium.org, Mar 20 2018

Components: -Blink Blink>Paint

Comment 4 by dtapu...@chromium.org, Mar 20 2018

Components: Blink>Layout
Labels: OS-Linux
Able to repro on Linux

Comment 5 by schenney@chromium.org, Mar 20 2018

Components: -Blink>Layout
Labels: -Type-Bug Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 6 by wangxianzhu@chromium.org, Mar 21 2018

Components: -Blink>Paint Blink>Layout>Table
Labels: Target-66
This is still a layout bug.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80a959a1273c3f91bed6c9a1696312456f6a5b07

commit 80a959a1273c3f91bed6c9a1696312456f6a5b07
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Mar 22 20:27:00 2018

[PE] Add ToInt() for logical padding top and bottom for LayoutTableCell

This reverts the logic for logical top/bottom paddings to be the same
as before https://chromium-review.googlesource.com/619603. The logical
top/bottom paddings are truncated like what we do for other table
layouts.

We still keep subpixels for logical left/right paddings to ensure
correct logical width calculation. This is still the same as before
https://chromium-review.googlesource.com/619603.

Bug:  823824 
Change-Id: Icb617bf5771d1726f767207853f4adc8275731dc
Reviewed-on: https://chromium-review.googlesource.com/974315
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545225}
[add] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-ref.html
[add] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-vertical-rl-ref.html
[add] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-vertical-rl.html
[add] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row.html
[add] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/width-distribution/td-with-subpixel-padding-vertical-rl.html
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/linux/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/mac/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/LayoutTests/platform/win/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/80a959a1273c3f91bed6c9a1696312456f6a5b07/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Comment 8 by wangxianzhu@chromium.org, Mar 23 2018

Labels: -Pri-2 Merge-Request-66 ReleaseBlock-Stable Pri-1
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 23 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by abdulsyed@chromium.org, Mar 23 2018 

How safe is this merge? Is it well tested?

Comment 11 by wangxianzhu@chromium.org, Mar 23 2018 

It should be same. Tested with existing test cases and the reported case.

Comment 12 by abdulsyed@chromium.org, Mar 26 2018

Cc: dgro...@chromium.org
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359

drgogan@ - can you please merge this while wangziangzhu@ is OOO.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 26 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22877e279fca95b5716e7ca96c3bbf833c3648db

commit 22877e279fca95b5716e7ca96c3bbf833c3648db
Author: David Grogan <dgrogan@chromium.org>
Date: Mon Mar 26 21:37:19 2018

[PE] Add ToInt() for logical padding top and bottom for LayoutTableCell

This reverts the logic for logical top/bottom paddings to be the same
as before https://chromium-review.googlesource.com/619603. The logical
top/bottom paddings are truncated like what we do for other table
layouts.

We still keep subpixels for logical left/right paddings to ensure
correct logical width calculation. This is still the same as before
https://chromium-review.googlesource.com/619603.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 80a959a1273c3f91bed6c9a1696312456f6a5b07)

Bug:  823824 
Change-Id: Icb617bf5771d1726f767207853f4adc8275731dc
Reviewed-on: https://chromium-review.googlesource.com/974315
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545225}
Reviewed-on: https://chromium-review.googlesource.com/981293
Cr-Commit-Position: refs/branch-heads/3359@{#454}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[add] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-ref.html
[add] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-vertical-rl-ref.html
[add] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row-vertical-rl.html
[add] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/height-distribution/td-different-subpixel-padding-in-same-row.html
[add] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/external/wpt/css/css-tables/width-distribution/td-with-subpixel-padding-vertical-rl.html
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/linux/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/mac/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/LayoutTests/platform/win/transforms/bounding-rect-zoom-expected.txt
[modify] https://crrev.com/22877e279fca95b5716e7ca96c3bbf833c3648db/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Comment 14 by wangxianzhu@chromium.org, Apr 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment