New issue
Advanced search Search tips

Issue 823823 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

QUIC's NetworkConnection hangs IO loop

Project Member Reported by pauljensen@chromium.org, Mar 20 2018

Issue description

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BThreadWatcher%20IO%20hang%5D%20net%3A%3A%60anonymous%20namespace%5C%27%3A%3AGetConnectionAttributes%27

0x00007ffead2eaf3c	(chrome.dll -network_interfaces_win.cc:53 )	net::`anonymous namespace'::GetConnectionAttributes
0x00007ffeac1410b1	(chrome.dll -network_interfaces_win.cc:246 )	net::GetWifiPHYLayerProtocol()
0x00007ffeac177135	(chrome.dll -network_connection.cc:40 )	net::NetworkConnection::OnConnectionTypeChanged(net::NetworkChangeNotifier::ConnectionType)

It appears on Windows QUIC's NetworkConnection's call to get the WiFi PHY type hangs the IO thread.  It also crashes, see Issue 572724.

Can we replace NetworkConnection::connection_type() with a call to NetworkChangeNotifier::GetConnectionType()?
Can we remove the WiFi PHY fetching as it's only used for logging? or if it's necessary, could we move it to another thread?
 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 20 2018

Labels: FoundIn-67 OS-Windows Fracas
Users experienced this crash on the following builds:

Win Canary 67.0.3376.1 -  0.49 CPM, 4 reports, 4 clients (signature [ThreadWatcher IO hang] net::`anonymous namespace'::GetConnectionAttributes)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Components: Internals>Network>DataProxy
Looks like DataProxy also uses this method?  Hangs in this method are the fifth most common browser "crasher" on Canary.  Can we do it off thread and cache the result or something?
Components: Internals>Network>Connectivity
Filed  Issue 896296  to track data proxy work.
Components: -Internals>Network>DataProxy
Removing DataProxy component since  Issue 896296  tracks that work.

Sign in to add a comment