New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823812 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Wpt test dom/ranges/Range-compareBoundaryPoints.html fails on Android

Reported by rob.b...@samsung.com, Mar 20 2018

Issue description

What steps will reproduce the problem?
Load http://w3c-test.org/dom/ranges/Range-compareBoundaryPoints.html in Chrome Android

What is the expected result?
Should have 0 failures

What happens instead?
Has more than 400 failures

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ace0e3a1a09c4a0c764c8a8af9d189b4d211111

commit 8ace0e3a1a09c4a0c764c8a8af9d189b4d211111
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Mar 22 15:07:23 2018

Fix dom/ranges/Range-compareBoundaryPoints.html on ARM

The how parameter is defined as unsigned short in WebIDL. The
generated bindings end up calling ToSmallerUInt in V8BindingForCore.cpp.
The final cast in this method seems to hit an ARM specific issue [1].
To fix this static cast to int64_t before static casting to the unsigned type.

[1] http://www.embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/

Bug:  823812 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I90c733185b8325984e004224dd72176840d1794e
Reviewed-on: https://chromium-review.googlesource.com/970901
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545078}
[modify] https://crrev.com/8ace0e3a1a09c4a0c764c8a8af9d189b4d211111/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/8ace0e3a1a09c4a0c764c8a8af9d189b4d211111/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb2d2b89706e1a091d8bb634e9ab0b1ff9ae92b

commit 8cb2d2b89706e1a091d8bb634e9ab0b1ff9ae92b
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Mar 22 21:50:14 2018

Remove superflous include from r545078

Should have removed this before landing.

Bug:  823812 
Change-Id: Icfb4e9c145d2a6e3da98d4ee3b7cf7ecc62c285b
Reviewed-on: https://chromium-review.googlesource.com/975921
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545264}
[modify] https://crrev.com/8cb2d2b89706e1a091d8bb634e9ab0b1ff9ae92b/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp

Status: Fixed (was: Started)

Sign in to add a comment