New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823800 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

UI review comments for eve email opt-in

Project Member Reported by xiaoyinh@chromium.org, Mar 20 2018

Issue description

For the UI review: 
1. Adjust the spacing between "Get email updates", "Stay up to date..." and "Subscribe"
2. Tweak the background/border shadow of the message.
 
Screenshot after update the above

eve-optin.png
929 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/2bdc05cc02df4277ce2240ac2054712f2782a3e9

commit 2bdc05cc02df4277ce2240ac2054712f2782a3e9
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Mar 21 02:30:17 2018

Labels: Merge-Request-66 OS-Chrome
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 21 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 24 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/e75cb95e89f609584d6d27929989bf43440fd816

commit e75cb95e89f609584d6d27929989bf43440fd816
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Sat Mar 24 00:17:57 2018

Status: Fixed (was: Assigned)
Components: Platform>Apps>GetHelp
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 26 2018

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-66
It's been merged to M66 per comment #6.

Sign in to add a comment