New issue
Advanced search Search tips

Issue 823768 link

Starred by 2 users
Status: Verified
Owner:
xiy...@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix JS error on webui login screen and wrong kiosk launch log.

Project Member Reported by xiy...@chromium.org, Mar 20 2018 
For JS error:

922:922:0313/132103.658501:ERROR:CONSOLE(10001)] "TypeError: Cannot read property 'ignoreAccelerators' of null
    at Oobe.handleAccelerator (chrome://oobe/login.js:2186:30)
    at Function.Oobe.handleAccelerator (chrome://oobe/login.js:9590:24)
    at <anonymous>:1:12", source: chrome://oobe/login.js (10001)
[922:922:0313/132103.658558:ERROR:CONSOLE(2186)] "Uncaught TypeError: Cannot read property 'ignoreAccelerators' of null", source: chrome://oobe/login.js (2186)
[922:922:0313/132104.290478:ERROR:app_launch_controller.cc(517)] Kiosk launch failed, error=7

and the following kiosk launch error is emitted wrongly:

2018-03-13T02:18:06.505346-07:00 ERR chrome[859]: [859:859:0313/021806.505316:ERROR:kiosk_profile_loader.cc(113)] Cryptohome is mounted before launching kiosk app.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cd16e29d83727cf503b5229c39277c4423a9795

commit 6cd16e29d83727cf503b5229c39277c4423a9795
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Mar 21 16:48:55 2018

cros: Fix a JS error and wrong kiosk log

- Fix a JS error when user presses accelerator too quickly;
- Fix a wrongly emitted kiosk launch log introduced during refactoring;

Bug:  823768 
Change-Id: I432f7e1a6fc7fd62794c81aafc75ea8efcc75fd2
Reviewed-on: https://chromium-review.googlesource.com/973465
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544736}
[modify] https://crrev.com/6cd16e29d83727cf503b5229c39277c4423a9795/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/6cd16e29d83727cf503b5229c39277c4423a9795/ui/login/display_manager.js

Comment 2 by xiy...@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)

Comment 3 by kathrelk...@chromium.org, Mar 26 2018

Labels: M-67

Comment 4 by vaandres@chromium.org, Mar 30 2018

Status: Verified (was: Fixed)
Verified using Fizz on Chrome OS 10525.0.0, 67.0.3381.0
►

Sign in to add a comment