New issue
Advanced search Search tips

Issue 823735 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 823495



Sign in to add a comment

Re-enable Translate Bubble menu unit tests on Mac

Project Member Reported by lgrey@chromium.org, Mar 20 2018

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/969653 disables these due to  Issue 823495 

They should be re-enabled when that issue is resolved.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45616255b1c1a9754a445f5174be04f6b5fd9659

commit 45616255b1c1a9754a445f5174be04f6b5fd9659
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Mar 20 16:32:00 2018

Disable menu-related translate bubble tests on Mac

NSMenus on Mac block in a nested run-loop, so any tests that open a menu
and try to do things to it or sense things on it either:
- Succeed by accident because of a race condition with app activations
- Block until the menu or another window is interacted with

Disabling these until we've either been able to make NSMenus asynchronous
to match views expectations, or found a way to test this functionality a
different way.

|AlwaysTranslateLanguageMenuItem| has an additional problem: pressing a
button halfway through closes the bubble, but on non-Mac platforms, the
test can continue due to asynchronous window closing. On Mac, the window's
content view is removed as soon as closing begins. We'll probably need
to address this by breaking it up into multiple tests and creating a way
to sense the state without relying on an object owned by the closing
bubble.

Bug:  810479 , 823735 
Change-Id: I9d9d9ca49a3436b91d3cc99fb43ecef13d2e77c0
Reviewed-on: https://chromium-review.googlesource.com/969653
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544400}
[modify] https://crrev.com/45616255b1c1a9754a445f5174be04f6b5fd9659/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Comment 2 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews

Comment 3 by lgrey@chromium.org, Apr 16 2018

Labels: Sprint-1
Labels: M-68 Target-68
Status: Assigned (was: Available)
This might have been fixed (or largely fixed) by <https://chromium-review.googlesource.com/c/chromium/src/+/998016> since all MacViews menus are now Views menus.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb4f38aebe493e438b40761997f95dc6807d6cb

commit cfb4f38aebe493e438b40761997f95dc6807d6cb
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Apr 23 16:04:00 2018

MacViews: Reenable translate bubble unit tests

Bug:  823735 
Change-Id: I4eda04eed9f78d89ba585f18812c9c59c5910aad
Reviewed-on: https://chromium-review.googlesource.com/1023011
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552716}
[modify] https://crrev.com/cfb4f38aebe493e438b40761997f95dc6807d6cb/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Comment 6 by lgrey@google.com, Apr 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment