Site settings button doesn't work in Guest mode |
||||
Issue descriptionChrome Version: 67 What steps will reproduce the problem? (1) Open guest mode (2) Open page info bubble (3) Click "Site settings" What is the expected result? It should be possible to change content settings by clicking on "Site settings" in the page info bubble. What happens instead? Settings are opened but they redirect to chrome://settings/.
,
Aug 7
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f55d1c53e1c17e61ff00974cd2d63484d3de45fa commit f55d1c53e1c17e61ff00974cd2d63484d3de45fa Author: Kamila <hkamila@google.com> Date: Fri Aug 24 09:21:40 2018 Not showing Site settings button for Guest mode In Guest mode, Site Settings link found in the Page info bubble, leads to chrome://settings/, not to the site content settings, as the content settings are not visible. Changes: -Removed the Site Settings button from guest mode. Note: Enabling just the Site Settings would require a complicated refactoring of privacy section. Bug: 823703 Change-Id: Ie3f6ecb3c7b11eeb7652808eefb8608222525830 Reviewed-on: https://chromium-review.googlesource.com/1185097 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585773} [modify] https://crrev.com/f55d1c53e1c17e61ff00974cd2d63484d3de45fa/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
,
Aug 24
,
Aug 27
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 17.10 using Chrome version #70.0.3534.0 as per the comment #3. Attaching screen shot for reference. Observed that the site settings button is removed from guest mode. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by raymes@chromium.org
, Mar 21 2018