New issue
Advanced search Search tips

Issue 823695 link

Starred by 0 users
Status: WontFix
Owner: ----
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

[Android password settings] Measure the use of progress bar delay in password exporting

Project Member Reported by vabr@chromium.org, Mar 20 2018 
This bug tracks adding metrics for the usage of some complicated logic in displaying progress bar during exporting passwords from Chrome on Android. It also keeps track of the clean-up. The logic itself was added in  issue 817370 .

Schedule:
M67 trunk -- land the metrics
M69 stable -- check the metrics
M71 trunk -- remove either the metrics or the delaying logic, depending on whether the metrics show that the delaying is used or not
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13541576c9449333cd478d293bf92fa9c5dbe5d7

commit 13541576c9449333cd478d293bf92fa9c5dbe5d7
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Mar 21 17:30:45 2018

Measure the use of progress bar when exporting passwords

On Android, when the user exports passwords from Chrome's settings, a
progress bar might be shown if the action takes too long. Once shown,
it is also kept up for at least one second.

The delaying logic in particular is rather complicated, and it is not
clear how often it is used. Therefore this CL adds UMA to measure its
use.

Bug:  823695 
Change-Id: I074a123cbca0187b9c8da4ef9577a768aa9e3cbb
Reviewed-on: https://chromium-review.googlesource.com/970343
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544755}
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/DialogManager.java
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SingleThreadBarrierClosure.java
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/chrome/android/junit/src/org/chromium/chrome/browser/preferences/password/DialogManagerTest.java
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/13541576c9449333cd478d293bf92fa9c5dbe5d7/tools/metrics/histograms/histograms.xml

Comment 2 by vabr@chromium.org, Mar 21 2018

Cc: vabr@chromium.org
NextAction: 2018-09-12
Owner: ----
Status: Available (was: Started)
Setting an alarm clock to check the metrics at some approximation of the schedule above. Leaving this as Available to avoid blocking it, but happy to pick this up again once the alarm fires.

Comment 3 by vabr@chromium.org, Sep 11

NextAction: ----
Hmm, so far all the cases reported through PasswordManager.Android.ExportPasswordsProgressBarUsage show that the progress bar was not shown at all. However, the overall count of the reports is very low. I will seek additional guidance with our PM.

Comment 4 by vabr@chromium.org, Sep 11

Status: WontFix (was: Available)
We concluded that removing the delaying logic makes sense.
I will file a new bug describing what exactly should go and marking it as a good first bug.
In parallel, I will reach out to twellington@ to discuss whether the dealying logic could be useful for progress bars across Chrome instead.

Comment 5 by vabr@chromium.org, Oct 8 

The bug promised in #4 here is bug 893103.

Comment 6 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment