New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary movement of toggle button while enabling it at ubertray/network section

Project Member Reported by rkalavakuntla@chromium.org, Mar 20 2018

Issue description

Chrome Version:66.0.3359.43/10452.19.0 dev channel Daisy,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Login to the device
(2)Connect to the mobile dongles network.
(3)From the ubertray try to toggle the mobile data connection and observe the toggle button while enabling

Actual: while enabling the toggle moves and then it enables
Expected: No such weird movement should be seen

This is a Regression issue as same is working fine in M-63

Note:Issue is also seen in M-64 stable and M-65 beta

Attached the screencast for reference..




 
Actual movements.mp4
3.6 MB View Download
Expected.mp4
4.6 MB View Download
Components: UI>Shell>StatusArea
Components: -UI

Comment 3 by mukai@chromium.org, Mar 23 2018

Owner: mukai@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af34e503c321c62c9238816784c223d6caae5255

commit af34e503c321c62c9238816784c223d6caae5255
Author: Jun Mukai <mukai@chromium.org>
Date: Sat Mar 24 00:49:06 2018

Remove trick of padding for subtitled network title view

It seems this causes repositions of the toggle buttons when
subtitles are set / cleared.

Bug:  823656 
Change-Id: Id987bd7f6291d4debdfb17d7fac34daedbe21117
Reviewed-on: https://chromium-review.googlesource.com/978889
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545653}
[modify] https://crrev.com/af34e503c321c62c9238816784c223d6caae5255/ash/system/network/network_list.cc

Comment 5 by mukai@chromium.org, Mar 26 2018

Status: Fixed (was: Started)

Sign in to add a comment