New issue
Advanced search Search tips

Issue 823655 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 824471
issue 824493
issue 825748

Blocking:
issue 505314
issue 725748



Sign in to add a comment

Roll Clang again

Project Member Reported by h...@chromium.org, Mar 20 2018

Issue description

Tracking bug for the next Clang roll.
Previous roll was  https://crbug.com/817298 


 

Comment 1 by h...@chromium.org, Mar 20 2018

Blocking: 505314
r327959 for  Issue 505314 

Comment 2 by h...@chromium.org, Mar 20 2018

Blocking: 725748
r328002 for natvis support in lld

Comment 3 by h...@chromium.org, Mar 20 2018

Owner: r...@chromium.org
Status: Assigned (was: Available)

Comment 4 by r...@chromium.org, Mar 21 2018

Blockedon: 824471

Comment 5 by r...@chromium.org, Mar 21 2018

Sanjay Patel committed r328119, which caused instcombine to assert in some cases. I went ahead and reverted it.

Comment 6 by r...@chromium.org, Mar 21 2018

Blockedon: 824493

Comment 7 by h...@chromium.org, Mar 26 2018

Blockedon: 825748

Comment 8 by r...@chromium.org, Mar 26 2018

I think it's my turn, so I started a roll at r328575: https://chromium-review.googlesource.com/c/chromium/src/+/981314

This should have LLD /natvis support, the new pragma warning split, and a fix for infinite loops on generic lambdas with delayed template parsing (no crbug for that).

I'll have to go update the gn to deal with -Wno-ignored-pragma-optimize.

Comment 9 by r...@chromium.org, Mar 26 2018

Blockedon: 825028
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b87e595bffe9c67d7fd55feeb0c0d3a34b63bfa

commit 9b87e595bffe9c67d7fd55feeb0c0d3a34b63bfa
Author: Reid Kleckner <rnk@google.com>
Date: Tue Mar 27 11:33:45 2018

Roll clang 327688:328575.

Bug:  823655 
Change-Id: If6dfa9d775d3be37b72b4cf5f2fd9db89763819a
Reviewed-on: https://chromium-review.googlesource.com/981314
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546080}
[modify] https://crrev.com/9b87e595bffe9c67d7fd55feeb0c0d3a34b63bfa/build/config/compiler/BUILD.gn
[modify] https://crrev.com/9b87e595bffe9c67d7fd55feeb0c0d3a34b63bfa/tools/clang/scripts/update.py

Comment 11 by r...@chromium.org, Mar 27 2018

We never resolved the Android ASan DomDistillerJsTest test failures. It looks like we don't have trybots for that configuration to use in the roll. If we have them on the clang waterfall, maybe we should add that configuration to the list of configs to test when rolling clang?

Comment 12 by r...@chromium.org, Mar 27 2018

Blockedon: -825028

Comment 13 by h...@chromium.org, Mar 28 2018

Status: Fixed (was: Assigned)
This appears to be sticking. Tracking bug for the next roll:  https://crbug.com/826683 

Sign in to add a comment