New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823654 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in content::RenderFrameMetadataObserverImpl::OnRenderFrameSubmission

Project Member Reported by ClusterFuzz, Mar 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5728908683771904

Fuzzer: ksakamoto_woff2_fuzzer
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::RenderFrameMetadataObserverImpl::OnRenderFrameSubmission
  cc::LayerTreeHostImpl::DrawLayers
  cc::ProxyImpl::DrawInternal
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=544160:544179

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5728908683771904

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 20 2018

Labels: Fuzz-Blocker M-67 ReleaseBlock-Beta
This crash occurs very frequently on linux platform and is likely preventing the fuzzer ksakamoto_woff2_fuzzer from making much progress. Fixing this will allow more bugs to be found.

Marking this bug as a blocker for next Beta release.

If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.

Comment 2 by glider@chromium.org, Mar 20 2018

Cc: tsepez@chromium.org fsam...@chromium.org
Owner: yiyix@chromium.org
Status: Assigned (was: Untriaged)
This is also reproducible on buildbots, see e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/8633 (MSan report in https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F8633%2F%2B%2Frecipes%2Fsteps%2Fextensions_browsertests%2F0%2Flogs%2FWebViewAPITest.ReloadEmbedder%2F0)

The problem has been caused by https://chromium-review.googlesource.com/c/chromium/src/+/952303, which I'm now reverting.
Most likely |root_background_color| isn't always being properly initialized.

Comment 3 by glider@chromium.org, Mar 20 2018

Cc: jonr...@chromium.org
BTW should be ok to remove Restrict-View-SecurityTeam (or change to Google)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 20 2018

Labels: Pri-1

Comment 6 by yiyix@chromium.org, Mar 20 2018

https://chromium-review.googlesource.com/c/chromium/src/+/971541

It's landed again. 

Thank you for debugging and reverting it.
Project Member

Comment 7 by ClusterFuzz, Mar 21 2018

ClusterFuzz has detected this issue as fixed in range 544332:544333.

Detailed report: https://clusterfuzz.com/testcase?key=5728908683771904

Fuzzer: ksakamoto_woff2_fuzzer
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::RenderFrameMetadataObserverImpl::OnRenderFrameSubmission
  cc::LayerTreeHostImpl::DrawLayers
  cc::ProxyImpl::DrawInternal
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=544160:544179
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=544332:544333

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5728908683771904

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 21 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5728908683771904 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 21 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Cc: tiansong@google.com
Labels: -ReleaseBlock-Beta
Components: Internals>Compositing
Adding label for posterity.
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 27 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment