New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocking:
issue 792441
issue 647200


Participants' hotlists:
Audio-Service


Sign in to add a comment

The browser needs to be notified of device changes by the audio service

Project Member Reported by maxmorin@chromium.org, Mar 20 2018

Issue description

Currently, the MediaDevicesManager and WebrtcAudioPrivateEventService are notified of device changes through the SystemMonitor [1]. The notifications are produced by various classes depending on the platform [2-5]. We need to figure out how these notifications are supposed to work with the audio service, especially out of process.

Guido: Could you have a look at this?

[1] https://cs.chromium.org/chromium/src/base/system_monitor/system_monitor.h?type=cs&sq=package:chromium&l=36
[2] https://cs.chromium.org/chromium/src/media/device_monitors/device_monitor_mac.mm
[3] https://cs.chromium.org/chromium/src/media/audio/win/audio_device_listener_win.cc
[4] https://cs.chromium.org/chromium/src/chromeos/audio/cras_audio_handler.cc
[5] https://cs.chromium.org/chromium/src/media/device_monitors/device_monitor_udev.cc
 

Comment 1 by olka@chromium.org, Mar 20 2018

Blocking: 792441
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Also, intersecting with https://chromium-review.googlesource.com/c/chromium/src/+/873351, we might only want to monitor device changes if a renderer is listening for updates (or has recently enumerated devices), and drop the cache otherwise. May be worth checking how the video capture service handles this.
Labels: -Type-Bug Type-Feature

Comment 4 by olka@chromium.org, Apr 19 2018

Blocking: 647200
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5

commit d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu May 10 17:09:57 2018

Add device monitoring to the audio service.

Bug:  823640 
Change-Id: Iede7cc3d9a7b7f39b89810914dcda1cb61379cdc
Reviewed-on: https://chromium-review.googlesource.com/1041865
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557563}
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/content/browser/renderer_host/media/media_devices_manager.h
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/BUILD.gn
[add] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/device_notifier.cc
[add] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/device_notifier.h
[add] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/device_notifier_unittest.cc
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/manifest.json
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/public/mojom/BUILD.gn
[add] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/public/mojom/device_notifications.mojom
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/service.cc
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/service.h
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/service_factory.cc
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/test/in_process_service_test.cc
[modify] https://crrev.com/d4af62ded717ec9fe2bb54d9d05439d4dfeff0b5/services/audio/test/service_lifetime_connector_test.cc

Comment 6 by guidou@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment