Move orientation request protocol from mojo to remote-shell protocol
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/850d9723dfa60cfaf49b91dfa24ffa63dafed797 commit 850d9723dfa60cfaf49b91dfa24ffa63dafed797 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Mar 21 21:24:20 2018 Fold the "current" orientation logic to ash::ScreenOrientationController This is preparation to move the orientation request protocol to exo remote shell. * ash's orientation logic was originally deisnged for w3c spec, which doesn't have "current" orientation, so it was implemented in ArcAppWindowLauncherController. I'm moving this to ash so that exo can implement it without re-implementing it. It'll also make it easy to test. * This also moves the logic "apply orientation only in tablet mode" logic to ash. I believe this is correct even for html as ScreenOrientationDelegateChromeos::ScreenOrientationProviderSupported() returns true only in tablet mode. * Updated ScreenOrientationControllerTest to switch to tablet mode to match the expectation above. BUG= 735078 , 823634 TEST=Updated unit tests. See comment above. Change-Id: Id26ca7e02fd8dcb5396ab05ce61a52c635f6eb54 Reviewed-on: https://chromium-review.googlesource.com/967684 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544850} [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/ash/content/screen_orientation_delegate_chromeos.cc [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/ash/display/display_manager_unittest.cc [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/850d9723dfa60cfaf49b91dfa24ffa63dafed797/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc48908438f814a8751736e43ce84504122e938f commit dc48908438f814a8751736e43ce84504122e938f Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Mar 21 22:33:41 2018 Follow up CL for crrev.com/c/967684 TBR=afakhry@chromium.org BUG= 735078 , 823634 TEST=None Change-Id: I6351b02d21fd3d64ca0963204f22fdd97910dc4b Reviewed-on: https://chromium-review.googlesource.com/974293 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544879} [modify] https://crrev.com/dc48908438f814a8751736e43ce84504122e938f/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/dc48908438f814a8751736e43ce84504122e938f/ash/display/screen_orientation_controller_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/842a1a863dac195c64e7bf999b9a1831efb5a509 commit 842a1a863dac195c64e7bf999b9a1831efb5a509 Author: Garfield Tan <xutan@chromium.org> Date: Fri Apr 06 16:50:58 2018 Deprecate orientation lock related mojom. BUG= 823634 BUG=b/74621390 TEST=Chrome builds. Change-Id: Id33704db9ed01b91791e111093da64ae406aeec3 Reviewed-on: https://chromium-review.googlesource.com/997024 Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548817} [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/chromeos/extensions/gfx_utils_unittest.cc [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/842a1a863dac195c64e7bf999b9a1831efb5a509/components/arc/common/app.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65805578c76c1643b75242eeaf8d1df392ec0eb7 commit 65805578c76c1643b75242eeaf8d1df392ec0eb7 Author: Garfield Tan <xutan@chromium.org> Date: Fri Apr 13 20:34:49 2018 Add wayland impl of setting orientation lock. BUG= 823634 BUG=b/74621390 TEST=Manual tests with WM test app. Exo unit tests pass. Change-Id: I0e0595fc62a50498790fd99144b547a88d1d9ba6 Reviewed-on: https://chromium-review.googlesource.com/996401 Commit-Queue: Garfield Tan <xutan@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550748} [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/components/exo/client_controlled_shell_surface.cc [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/components/exo/client_controlled_shell_surface.h [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/components/exo/client_controlled_shell_surface_unittest.cc [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/components/exo/wayland/server.cc [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/65805578c76c1643b75242eeaf8d1df392ec0eb7/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7971ff25a5f9ff73c98f8b315a85c1689defe29f commit 7971ff25a5f9ff73c98f8b315a85c1689defe29f Author: Garfield Tan <xutan@chromium.org> Date: Thu Apr 19 17:05:54 2018 Remove orientation lock implementation from launcher. This info is already passed via Wayland. BUG= 823634 BUG=b/74621390 TEST=Manual tests. Chrome unit tests passed. Change-Id: Ic789f2227ee55facf638f2dae0fddd9a1be4efb1 Reviewed-on: https://chromium-review.googlesource.com/1014637 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552056} [modify] https://crrev.com/7971ff25a5f9ff73c98f8b315a85c1689defe29f/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/7971ff25a5f9ff73c98f8b315a85c1689defe29f/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/7971ff25a5f9ff73c98f8b315a85c1689defe29f/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/7971ff25a5f9ff73c98f8b315a85c1689defe29f/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/7971ff25a5f9ff73c98f8b315a85c1689defe29f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
The feature is already in. The only work left is to remove deprecated mojom fields.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ba51b7993ca1851c6f683644c0bbc9a28645eff commit 7ba51b7993ca1851c6f683644c0bbc9a28645eff Author: Garfield Tan <xutan@chromium.org> Date: Mon May 21 23:53:15 2018 Remove deprecated orientation lock related mojom. Also remove remainant in unit tests. BUG= 823634 BUG=b/74621390 TEST=Chrome builds. Unit tests passed. Change-Id: I114a1059d29de9d85b3b679f59e55238452bd37d Reviewed-on: https://chromium-review.googlesource.com/1024711 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560414} [modify] https://crrev.com/7ba51b7993ca1851c6f683644c0bbc9a28645eff/chrome/browser/chromeos/extensions/gfx_utils_unittest.cc [modify] https://crrev.com/7ba51b7993ca1851c6f683644c0bbc9a28645eff/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/7ba51b7993ca1851c6f683644c0bbc9a28645eff/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/7ba51b7993ca1851c6f683644c0bbc9a28645eff/chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc [modify] https://crrev.com/7ba51b7993ca1851c6f683644c0bbc9a28645eff/components/arc/common/app.mojom
Comment 1 by bugdroid1@chromium.org
, Mar 21 2018