New issue
Advanced search Search tips

Issue 823600 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

termina: go back to USE=-crypto

Project Member Reported by smbar...@chromium.org, Mar 20 2018

Issue description

With https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/942502

system_api now depends on libmojo, which breaks the tatl build if USE=-crypto:

libmojo-395517-r3:       'crypto/random.h' file not found
libmojo-395517-r3: #include "crypto/random.h"

As a workaround, I've removed USE=-crypto. We should fix the build to allow USE=-crypto again. Maybe this just means ripping out our libbrillo dependency.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a10cddb9f86e6b1a798cf1c2b2f0aea3e5e9272d

commit a10cddb9f86e6b1a798cf1c2b2f0aea3e5e9272d
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Mar 20 11:16:54 2018

termina: don't set USE=-crypto

This is breaking the tatl build:
libmojo-395517-r3: 'crypto/random.h' file not found
libmojo-395517-r3: #include "crypto/random.h"

BUG= chromium:823600 
TEST=./build_packages --board=tatl --nowithautotest

Change-Id: I6c59c5dc3e481e5be28d56ca45a8776dd7977f3a
Reviewed-on: https://chromium-review.googlesource.com/970086
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/a10cddb9f86e6b1a798cf1c2b2f0aea3e5e9272d/project-termina/profiles/base/make.defaults

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/159b50c856bea08d5d7c06e721e26090ef78eda5

commit 159b50c856bea08d5d7c06e721e26090ef78eda5
Author: Chirantan Ekbote <chirantan@chromium.org>
Date: Wed Mar 21 05:21:29 2018

libbrillo: Only depend on system_api if USE=dbus

The only part of libbrillo that depends on system_api is the http proxy
and that is only built if USE=dbus is set.  Make the dependency on
system_api also conditional on USE=dbus.

BUG= chromium:823600 
TEST=`emerge-tatl libbrillo`

Change-Id: If5c5243a94db82cb6c72de661377fd9372fb7ae0
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/972439
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/159b50c856bea08d5d7c06e721e26090ef78eda5/chromeos-base/libbrillo/libbrillo-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d8a95abd21843148e677306acd3fb892e3f01579

commit d8a95abd21843148e677306acd3fb892e3f01579
Author: Stephen Barber <smbarber@chromium.org>
Date: Wed Mar 21 13:49:46 2018

Revert "termina: don't set USE=-crypto"

This reverts commit a10cddb9f86e6b1a798cf1c2b2f0aea3e5e9272d.

Reason for revert: No longer needed. libbrillo ebuild has been fixed.

Original change's description:
> termina: don't set USE=-crypto
>
> This is breaking the tatl build:
> libmojo-395517-r3: 'crypto/random.h' file not found
> libmojo-395517-r3: #include "crypto/random.h"
>
> BUG= chromium:823600 
> TEST=./build_packages --board=tatl --nowithautotest
>
> Change-Id: I6c59c5dc3e481e5be28d56ca45a8776dd7977f3a
> Reviewed-on: https://chromium-review.googlesource.com/970086
> Commit-Ready: Stephen Barber <smbarber@chromium.org>
> Tested-by: Stephen Barber <smbarber@chromium.org>
> Reviewed-by: Stephen Barber <smbarber@chromium.org>
> Reviewed-by: Zach Reizner <zachr@chromium.org>

Bug:  chromium:823600 
Change-Id: Ibec64feeae9da5ab7b6d68333ce97b1d13e4eac3
Reviewed-on: https://chromium-review.googlesource.com/972881
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d8a95abd21843148e677306acd3fb892e3f01579/project-termina/profiles/base/make.defaults

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8f71b275d87ab69362eca5e7609d2f0af4658075

commit 8f71b275d87ab69362eca5e7609d2f0af4658075
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Nov 29 00:32:50 2018

termina: Avoid pulling in libmojo via autotest

We can't build libmojo, as it depends on libchrome having USE=crypto
support. I guess most people just build with `build_packages
--nowithautotest`? Anyway, might as well fix this.

BUG= chromium:823600 
TEST=`./build_packages --board=tael` succeeds (without pulling in
     libmojo)

Change-Id: Ife11d49c46b5cb9c5ca1a1c9378a6d8302b26910
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1352378
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/8f71b275d87ab69362eca5e7609d2f0af4658075/project-termina/profiles/base/package.use

Sign in to add a comment