New issue
Advanced search Search tips

Issue 823597 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in media::MediaLog::AddLogEvent

Project Member Reported by ClusterFuzz, Mar 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6273386544889856

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  media::MediaLog::AddLogEvent
  media::LogHelper::~LogHelper
  media::FFmpegDemuxerStream::EnqueuePacket
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=544180:544183

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6273386544889856

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 20 2018

Components: Internals>Media
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 20 2018

Labels: Test-Predator-Auto-Owner
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c7916b3e214429239af483abb78efe45e925c08b (Ignore invalid MP3 packets from ffmpeg.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: wolenetz@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c3823079fe41cd1cbef1ffe2e8b24a173f5559

commit d4c3823079fe41cd1cbef1ffe2e8b24a173f5559
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Mar 20 07:27:24 2018

Fix accidental media_log to nullptr.

BUG= 823597 , 822341 , 794782 
TBR=wolenetz

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7000336c8c34dbb310bc40faa33d3e51c4e1efa3
Reviewed-on: https://chromium-review.googlesource.com/969984
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544304}
[modify] https://crrev.com/d4c3823079fe41cd1cbef1ffe2e8b24a173f5559/media/filters/ffmpeg_demuxer.cc

Project Member

Comment 6 by ClusterFuzz, Mar 20 2018

ClusterFuzz has detected this issue as fixed in range 544303:544304.

Detailed report: https://clusterfuzz.com/testcase?key=6273386544889856

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  media::MediaLog::AddLogEvent
  media::LogHelper::~LogHelper
  media::FFmpegDemuxerStream::EnqueuePacket
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=544180:544183
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=544303:544304

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6273386544889856

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Mar 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6273386544889856 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: dalecur...@chromium.org
 Issue 823622  has been merged into this issue.
 Issue 823696  has been merged into this issue.

Sign in to add a comment