New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Clients.openWindow() should open a new app window if there is an app installed.

Project Member Reported by ortuno@chromium.org, Mar 20 2018

Issue description

This allows notifications to open a new app window instead of opening a tab.
 

Comment 1 by ortuno@chromium.org, Mar 27 2018

Labels: M-67
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df4c16e4c7f08c233a472867f69bfd1489a08f90

commit df4c16e4c7f08c233a472867f69bfd1489a08f90
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Mar 28 23:14:43 2018

browser-navigator: Introduce open_in_app_if_possible parameter

Adds |open_in_app_if_possible| to NavigateParams. When true, Navigate
will ignore |diposition| and open a new app window instead, if there is
an app installed for |url|. If there is no app installed for |url|
Navigate falls back to the provided disposition.

Bug:  823582 
Change-Id: Ice72f976f6868bc18930f1dc853f2157ae4e7d2d
Reviewed-on: https://chromium-review.googlesource.com/970101
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546649}
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/chrome/browser/ui/browser_navigator_browsertest.cc
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/chrome/browser/ui/browser_navigator_params.cc
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/content/public/browser/page_navigator.cc
[modify] https://crrev.com/df4c16e4c7f08c233a472867f69bfd1489a08f90/content/public/browser/page_navigator.h

Comment 3 by ortuno@chromium.org, Mar 28 2018

Status: Fixed (was: Started)

Sign in to add a comment