New issue
Advanced search Search tips

Issue 823578 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 20 2018

Issue description

"SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5JbnB1dEV2ZW50Um91dGVyR2VzdHVyZVRhcmdldE1hcFRlc3QvMQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by glider@chromium.org, Mar 21 2018

Cc: a...@chromium.org sadrul@chromium.org riajiang@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0caa5dd4109a31cd6b35ad06f6c0eda746bf3c3c

commit 0caa5dd4109a31cd6b35ad06f6c0eda746bf3c3c
Author: Alexander Potapenko <glider@google.com>
Date: Wed Mar 21 16:20:28 2018

Disable flaky SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest

BUG= 823578 
TBR=riajiang@chromium.org,sadrul@chromium.org,kenrb@chromium.org

Change-Id: Id67a578a183ad65a80f9a72f610cf554c164cd12
Reviewed-on: https://chromium-review.googlesource.com/973605
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544726}
[modify] https://crrev.com/0caa5dd4109a31cd6b35ad06f6c0eda746bf3c3c/content/browser/site_per_process_hit_test_browsertest.cc

 Issue 824127  has been merged into this issue.
Cc: -sadrul@chromium.org
Labels: -Sheriff-Chromium
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
Removing from chromium Sheriff queue.

Comment 5 by sadrul@chromium.org, Mar 21 2018

Cc: -riajiang@chromium.org sadrul@chromium.org wjmaclean@chromium.org moh...@chromium.org
Owner: riajiang@chromium.org
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Mar 21 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5JbnB1dEV2ZW50Um91dGVyR2VzdHVyZVRhcmdldE1hcFRlc3QvMQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
From sample report https://chromium-swarm.appspot.com/task?id=3c5d052b7fe07010&refresh=10&show_raw=1, both /0 and /1 can get to this failure:

[ RUN      ] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/0


DevTools listening on ws://127.0.0.1:54842/devtools/browser/d6371df5-68c7-42bd-b2f1-8208e9952ada
../../content/browser/site_per_process_hit_test_browsertest.cc(2272): error: Expected equality of these values:
  nullptr
    Which is: NULL
  router_touch_target
    Which is: 0000025DD9F076A0
[3244:3580:0320/092903.299:ERROR:node_channel.cc(904)] Dropping message on closed channel.
[3244:2052:0320/092903.310:WARNING:discardable_shared_memory_manager.cc(436)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[  FAILED  ] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/0, where GetParam() = (false, 1) (1647 ms)
[2300/2409] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/0 (1906 ms)
[ RUN      ] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1


DevTools listening on ws://127.0.0.1:54845/devtools/browser/6e244676-d7e5-4266-93a8-ae67e0f3dfbb
[5600:5712:0320/092902.710:ERROR:sync_point_manager.cc(136)] Client did not release sync token as expected

[5600:5712:0320/092902.711:ERROR:sync_point_manager.cc(136)] Client did not release sync token as expected

[5600:5712:0320/092903.022:ERROR:sync_point_manager.cc(136)] Client did not release sync token as expected

../../content/browser/site_per_process_hit_test_browsertest.cc(2272): error: Expected equality of these values:
  nullptr
    Which is: NULL
  router_touch_target
    Which is: 0000014E49718C40
[5612:5892:0320/092903.538:WARNING:discardable_shared_memory_manager.cc(436)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[  FAILED  ] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1, where GetParam() = (true, 1) (1685 ms)
[2301/2409] SitePerProcessHitTestBrowserTest.InputEventRouterGestureTargetMapTest/1 (1934 ms)

but /0 pass when rerun and /1 keeps getting timed out...

I found that flakiness started to happen after https://chromium-review.googlesource.com/c/chromium/src/+/957881, not quite sure if it's related to the /1 timeout yet.

Since it's only on windows, I'll re-enable it on other platforms first.
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec01ea9ce1b668d88f715373daf56fd392c53274

commit ec01ea9ce1b668d88f715373daf56fd392c53274
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu May 17 16:19:18 2018

Re-enable InputEventRouterTouchpadGestureTargetTest and InputEventRouterGestureTargetMapTest on non-win platforms.

InputEventRouterTouchpadGestureTargetTest and
InputEventRouterGestureTargetMapTest in
SitePerProcessHitTestBrowserTest are flaky for Viz hit-test but only
on Windows. Re-enable them on other platforms.

Bug: 838835,  823578 
Change-Id: I91d332036cb546d3606b3ea483b865496bc5a918
Reviewed-on: https://chromium-review.googlesource.com/1062828
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559557}
[modify] https://crrev.com/ec01ea9ce1b668d88f715373daf56fd392c53274/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330f08c7b9a1e1dd4ae81296dc5888f1001fc6b8

commit 330f08c7b9a1e1dd4ae81296dc5888f1001fc6b8
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Sep 10 20:55:36 2018

Tentatively re-enable InputEventRouterGestureTargetMapTest on Win.

This issue may be fixed by recent changes, but even if it isn't, it
would be nice to have some fresh data on it.

Bug:  823578 
Change-Id: I2568fad71686c658fbe9e26ffe1dfdcb09ff3891
Reviewed-on: https://chromium-review.googlesource.com/1217402
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590054}
[modify] https://crrev.com/330f08c7b9a1e1dd4ae81296dc5888f1001fc6b8/content/browser/site_per_process_hit_test_browsertest.cc

Status: Fixed (was: Assigned)
The test no longer seems to be flakey ... marking as fixed.

Sign in to add a comment