Cannot update saved password in chrome
Reported by
pbe...@gmail.com,
Mar 20 2018
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36 Steps to reproduce the problem: Same issue as Chromium bug 43039 1. Logging into a website. 2. Password that is encrypted is saved instead of the typed password 3. Go to settings, Advanced, Manage Passwords 4. Click on Details of one of the passwords 5. Not able to change the password. What is the expected behavior? 1. Should save entered password not the encrypted password sent by the website. 2. Should be able to modify the password that is saved in Chrome. What went wrong? Encrypted password is being stored instead of entered password. Does not allow to update the password saved in chrome. Did this work before? N/A Chrome version: 65.0.3325.162 Channel: stable OS Version: 10.0 Flash Version:
,
Mar 22 2018
Able to reproduce this issue on reported version 65.0.3325.162, on latest beta 66.0.3359.45 and on latest canary 67.0.3377.0 using Mac 10.13.3, Windows 10 and Ubuntu 14.04. This issue is seen from introduction of save password bubble in M-64. Hence considering this issue as Non-Regression and marking Untriaged. Thanks!
,
Mar 22 2018
What is the site page? Can you try to use the manual flow? - Type your credentials on the sign-in page but don't click "Sign in". - open the password bubble via the key icon in the omnibox. - Is it the update bubble? Is the captured password correct? As a second experiment please open chrome://password-manager-internals/ in a tab. Then navigate to the site and login there. Paste the log from the password manager here.
,
Apr 23 2018
Mac triage: assigning directly to vasilii@ for followup - it sounds like TE has a working repro.
,
Apr 23 2018
I can reproduce the issue
,
Apr 23 2018
Please answer the questions in comment #3.
,
Apr 23 2018
Website: https://www.hdfcbank.com/nri_banking/home.htm Click on netbanking, Login, Continue to netbanking I clicked on Key icon. Password is not visible, only a bunch of **** 2nd experiment opened chrome://password-manager-internals/ Getting message below. Captured password manager logs are listed below. Logs are cleared and no longer captured when all password-manager-internals pages are closed.
,
Apr 25 2018
The manual fallback works fine. I clicked the eye icon and the password is exactly what I typed. pbekal@ could you open chrome://password-manager-internals/ and then in the second tab login to the bank? The log from chrome://password-manager-internals/ shouldn't be empty.
,
Apr 26 2018
The password is not the same when google ask for it update. See screen shots.
,
Apr 26 2018
Logs attached
,
Apr 27 2018
No screeshot/logs attached. Please attach via the site crbug.com
,
Apr 27 2018
Password Issue Screen shots. The logs have account information so will not be able to attach. Let me know if you need to see any section of the logs.
,
Apr 27 2018
It shouldn't have both the username and the password. You can replace the account information with xxxx. The fact that some private information ended up in the log is also a bug that I'd like to investigate.
,
Apr 28 2018
Uploading log.
,
May 3 2018
Here is what happening. The login form is in the iframe and is has target="_top" parameter. - The user is typing the password. PasswordManager gets the signal and saves |provisional_save_manager_| (correct). - The user clicks "Login". The page JS replaces the password with a hash. Then the form is submitted. We have a protection against it but... - The iFrame with the form doesn't see the submission. Instead the top frame is notified and it has no idea about the typed value. PasswordManager::OnPasswordFormSubmitted is called and a valid |provisional_save_manager_| is replaced with the hashed value (wrong) - Still it doesn't trigger the bubble yet. - The frame with the form is destroyed and PasswordAutofillAgent::OnFrameDetached calls PasswordManager::OnSameDocumentNavigation with the correct password (correct). - Unthinkable happens. PasswordManager::OnPasswordFormSubmittedNoChecks must save |provisional_save_manager_| and it fails because we don't find PasswordFormManager handling the form. (wrong) - OnSameDocumentNavigation proceeds. OnLoginSuccessful() is called with the current |provisional_save_manager_|. It has the hashed value and that is what we show in the bubble.
,
May 10 2018
Can we get a fix for this ?
,
May 11 2018
I'm working on the fix. It's nontrivial so I have to change the tests first.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63317dd5fc2a3310dca673aafb45ee10511770bf commit 63317dd5fc2a3310dca673aafb45ee10511770bf Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu May 24 14:12:14 2018 Password Manager: don't drop the information about existing forms on submit. PasswordManager::OnPasswordFormSubmitted is called when a form is submitted. It doesn't mean that PasswordManager should forget about everything it saw before. Despite the data is provisionally saved, it's not time to show the bubble yet. Therefore, there may be another event coming that would trigger the bubble. For the concrete bug the consequences are the following: - the hashed password is still provisionally saved via OnPasswordFormSubmitted(). It's correct because we don't know that it's hashed. Ideally, we should protect against JS modifications in PasswordManager. Currently we do it in PasswordAutofillAgent::OnWillSubmitForm. - PasswordAutofillAgent::OnFrameDetached() later triggers the successful login. The data provided is actually correct and propagated to the bubble. Bug: 823562 Change-Id: Ib23f2d4188e57f04d766997367c69f8613dacb17 Reviewed-on: https://chromium-review.googlesource.com/1044605 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#561493} [modify] https://crrev.com/63317dd5fc2a3310dca673aafb45ee10511770bf/chrome/browser/password_manager/password_manager_browsertest.cc [add] https://crrev.com/63317dd5fc2a3310dca673aafb45ee10511770bf/chrome/test/data/password/password_form_with_hash.html [modify] https://crrev.com/63317dd5fc2a3310dca673aafb45ee10511770bf/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/63317dd5fc2a3310dca673aafb45ee10511770bf/components/password_manager/core/browser/password_manager_unittest.cc
,
May 24 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Mar 20 2018