New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 823546 link

Starred by 1 user
Status: Fixed
Owner:
█ hongjunchoi@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
engedy@chromium.org
kpaulhamus@chromium.org
jdoerrie@chromium.org
kenrb@chromium.org
martinkr@google.com
ssoneff@google.com
mknowles@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Feature

Blocking:
issue 780078



Sign in to add a comment

Add support for AuthenticatorSelectionCriteria on CTAP2 devices

Project Member Reported by hongjunchoi@chromium.org, Mar 20 2018 
Add authenticator filtering logic using AuthenticatorSelectionCriteria passed on from the relying party. Once device information has been received from AuthenticatorGetInfo command, filter requests based on AuthenticatorSelectionCriteria.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f379a62e28db60c8d92d153acadee0b5e67c6efd

commit f379a62e28db60c8d92d153acadee0b5e67c6efd
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Wed Mar 28 00:46:39 2018

Implement AuthenticatorSelectionCriteria logic

AuthenticatorSelectionCriteria adds extra constraints passed on from the
relying party to limit to type and properties of authenticators used in
MakeCredential command. Request to an authenticator that does not meet
AuthenticatorSelectionCriteria should be silently dropped.

Bug:  823546 
Change-Id: I48f4c0000b7f182f1e254b45c90e60642938a75a
Reviewed-on: https://chromium-review.googlesource.com/969799
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546340}
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/BUILD.gn
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/authenticator_get_info_response.h
[add] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/authenticator_selection_criteria.cc
[add] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/authenticator_selection_criteria.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/authenticator_supported_options.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/device_response_converter.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/fido_constants.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/fido_constants.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/fido_request_handler_unittest.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/fido_response_test_data.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/make_credential_request_handler.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/make_credential_request_handler.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/make_credential_task.cc
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/make_credential_task.h
[modify] https://crrev.com/f379a62e28db60c8d92d153acadee0b5e67c6efd/device/fido/make_credential_task_unittest.cc

Comment 2 by hongjunchoi@chromium.org, Mar 28 2018

Status: Fixed (was: Assigned)

Comment 3 by engedy@chromium.org, Mar 31 2018

Labels: -Pri-3 M-68 Pri-1
►

Sign in to add a comment