New issue
Advanced search Search tips

Issue 823543 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 817419



Sign in to add a comment

interactive_ui_tests MacViews Widget Activation State Issues

Project Member Reported by robliao@chromium.org, Mar 20 2018

Issue description

These tests are affected by Activation not quite working on Widget

Tests: SSLClientCertificateSelectorMultiProfileTest.Escape
       ToolbarViewTest.ToolbarCycleFocus
       ToolbarViewTest.ToolbarCycleFocusWithBookmarkBar
       LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility
 
Owner: robliao@chromium.org
Status: Started (was: Available)
BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor also breaks because of activation difficulties.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2

commit 77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2
Author: Elly Fong-Jones <ellyjones@google.com>
Date: Tue Mar 20 21:38:08 2018

polychrome: disable BrowserNonClientFrameViewBrowserTest on Mac

This test doesn't work on Mac right now because of issues around Views widget
activation.

Bug: 817408,823543
Change-Id: Icddd12e42900e287dc65ac3c20327cb22383c9eb
Reviewed-on: https://chromium-review.googlesource.com/972144
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544528}
[modify] https://crrev.com/77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0707af2a191731afa66e344f0adcf63f1b98b4cf

commit 0707af2a191731afa66e344f0adcf63f1b98b4cf
Author: Robert Liao <robliao@chromium.org>
Date: Wed Mar 21 22:24:20 2018

Properly Disable MacViews ToolbarViewTest.ToolbarCycleFocusWithBookmarkBar

A "MAYBE_" was lost in the shuffle.

BUG=823543
TBR=ellyjones@chromium.org
This missed the https://chromium-review.googlesource.com/c/chromium/src/+/972329 train.

Change-Id: I74a9037f6a8e35350203eae8136f9e9b6295501e
Reviewed-on: https://chromium-review.googlesource.com/974163
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544873}
[modify] https://crrev.com/0707af2a191731afa66e344f0adcf63f1b98b4cf/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

Labels: MacViews-Tests

Comment 7 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: -Pri-1 MacViews-Cleanup M-69 Target-69 Pri-2
Status: Assigned (was: Started)
Labels: -M-69 Group-Tests
Labels: M-69
Labels: -M-69 -Target-69 M-70 Target-70
Verified that LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility is still broken.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94

commit 3fd4d13e696ecb0568552b9ae12b941c1dbd5b94
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Nov 16 21:36:47 2018

Re-enable two disabled tests in c/b/ui/views/location_bar/.

This updates the comments on the other tests to have TODO form.

Bug: 163931, 823543, 824418
Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52
Reviewed-on: https://chromium-review.googlesource.com/c/1334842
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608959}
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 (6 days ago)

Sign in to add a comment