interactive_ui_tests MacViews Widget Activation State Issues |
||||||||
Issue description
These tests are affected by Activation not quite working on Widget
Tests: SSLClientCertificateSelectorMultiProfileTest.Escape
ToolbarViewTest.ToolbarCycleFocus
ToolbarViewTest.ToolbarCycleFocusWithBookmarkBar
LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility
,
Mar 20 2018
BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor also breaks because of activation difficulties.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2 commit 77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2 Author: Elly Fong-Jones <ellyjones@google.com> Date: Tue Mar 20 21:38:08 2018 polychrome: disable BrowserNonClientFrameViewBrowserTest on Mac This test doesn't work on Mac right now because of issues around Views widget activation. Bug: 817408,823543 Change-Id: Icddd12e42900e287dc65ac3c20327cb22383c9eb Reviewed-on: https://chromium-review.googlesource.com/972144 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544528} [modify] https://crrev.com/77ac9a3b1f3b051f57ceb77c58ca6948d42ad9b2/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/784198a062dc3a634347b04a3c4e5a0c126b1fdd commit 784198a062dc3a634347b04a3c4e5a0c126b1fdd Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 21 16:42:47 2018 Disable MacViews Tests Impacted by Activation Issues BUG=823543 Change-Id: Id6baed02122845092462a8166754acb28bbd3a9e Reviewed-on: https://chromium-review.googlesource.com/972329 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544733} [modify] https://crrev.com/784198a062dc3a634347b04a3c4e5a0c126b1fdd/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc [modify] https://crrev.com/784198a062dc3a634347b04a3c4e5a0c126b1fdd/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc [modify] https://crrev.com/784198a062dc3a634347b04a3c4e5a0c126b1fdd/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0707af2a191731afa66e344f0adcf63f1b98b4cf commit 0707af2a191731afa66e344f0adcf63f1b98b4cf Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 21 22:24:20 2018 Properly Disable MacViews ToolbarViewTest.ToolbarCycleFocusWithBookmarkBar A "MAYBE_" was lost in the shuffle. BUG=823543 TBR=ellyjones@chromium.org This missed the https://chromium-review.googlesource.com/c/chromium/src/+/972329 train. Change-Id: I74a9037f6a8e35350203eae8136f9e9b6295501e Reviewed-on: https://chromium-review.googlesource.com/974163 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544873} [modify] https://crrev.com/0707af2a191731afa66e344f0adcf63f1b98b4cf/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
,
Mar 23 2018
,
Apr 13 2018
,
Apr 17 2018
,
Jun 1 2018
,
Jul 12
,
Jul 12
,
Jul 26
,
Nov 16
Verified that LocationIconViewTest.ActivateFirstInactiveBubbleForAccessibility is still broken.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94 commit 3fd4d13e696ecb0568552b9ae12b941c1dbd5b94 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Nov 16 21:36:47 2018 Re-enable two disabled tests in c/b/ui/views/location_bar/. This updates the comments on the other tests to have TODO form. Bug: 163931, 823543, 824418 Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52 Reviewed-on: https://chromium-review.googlesource.com/c/1334842 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608959} [modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc [modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/star_view_browsertest.cc [modify] https://crrev.com/3fd4d13e696ecb0568552b9ae12b941c1dbd5b94/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
,
Jan 17
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e commit 632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e Author: Peter Kasting <pkasting@chromium.org> Date: Thu Jan 17 05:11:56 2019 Re-enable disabled tests in chrome/browser/ui/views/toolbar/. Bug: 163931, 401304 , 617056, 764111, 788112 , 823543, 824418 Change-Id: I6c1a8be7f5d30e0082b69af12aceb35851ce2f51 Reviewed-on: https://chromium-review.googlesource.com/c/1351805 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#623589} [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.cc [modify] https://crrev.com/632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e/chrome/test/base/view_event_test_base.h |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by robliao@chromium.org
, Mar 20 2018Status: Started (was: Available)