New issue
Advanced search Search tips

Issue 823541 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 852993



Sign in to add a comment

migration app: run analysis iff builder is not prod

Project Member Reported by no...@chromium.org, Mar 19 2018

Issue description

Now we allow task force to close bugs themselves:   bug 821257  

Update migration app to skip analysis of a "LUCI is prod" builder.
On the builder page, do not render red bold "outdated" if the builder is "luci is prod".
 

Comment 1 by efoo@chromium.org, Mar 20 2018

Labels: LUCI-Backlog

Comment 2 by no...@chromium.org, Mar 20 2018

Owner: jchin...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/98146523f4fcf7b1890dbbda05477299b760c5f7

commit 98146523f4fcf7b1890dbbda05477299b760c5f7
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Mar 22 19:36:16 2018

[monorail] add GetIssue RPC

Add GetIssue RPC to Monorail client.

Bug: 823541
Change-Id: I231de09d9e71d197d94d075b3b5835380391cfc6
Reviewed-on: https://chromium-review.googlesource.com/972149
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorailtest/server.go
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/appengine/cr-audit-commits/app/test_utils.go
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/endpoints.go
[add] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorail.mock.pb.go
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorail.pb.go
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorailtest/client.go
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorail.infra_testing
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/monorail.proto
[modify] https://crrev.com/98146523f4fcf7b1890dbbda05477299b760c5f7/go/src/infra/monorail/pb.discovery.go

Comment 4 by no...@chromium.org, Apr 17 2018

Did we decide to stop analyzing a builder bug is closed? was there any progress?

Under previous discussion, this is actually a WontFix, because the migration app and bug state communicate two separate pieces of information (whether LUCI builds are prod and whether Buildbot machines are decommissioned, etc.). This means that taskforce members should communicate them separately at the relevant times by marking LUCI-is-Prod, and closing the bug, respectively.

Has any part of this changed such that we again now wish to sync the migration app state with the bug state?

I still have the cleanup CL active and can land that; it doesn't affect taskforce workflow and hence is not time-sensitive.

Comment 6 by no...@chromium.org, Apr 17 2018

Description: Show this description

Comment 7 by no...@chromium.org, Apr 17 2018

ah thanks for helping me recalling what we want. You are totally right. Let me repurpose this bug.

Comment 8 by no...@chromium.org, Apr 27 2018

Summary: migration app: skip analysis if builder is prod (was: migration app: sync with bug state)

Comment 9 by no...@chromium.org, Jun 15 2018

Blocking: 852993

Comment 10 by efoo@chromium.org, Jun 15 2018

Jao-ke/Nodir, can you detail what the remaining work on this? 

Comment 12 by no...@chromium.org, Jun 27 2018

Summary: migration app: run analysis iff builder is not prod (was: migration app: skip analysis if builder is prod)

Sign in to add a comment