Expanding Scope...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8d3b1f804a2aaa1fc57cdb3b74a93a25a6c0a8

commit 7a8d3b1f804a2aaa1fc57cdb3b74a93a25a6c0a8
Author: Robert Liao <robliao@chromium.org>
Date: Thu Mar 22 12:55:02 2018

Disable Selected Tests That Get Text from a Textfield on MacViews

These textfields often return nothing.

BUG= 823532 

Change-Id: I3e55d7c26ad46f065101ab8b5cf0fc3f085ae8f3
Reviewed-on: https://chromium-review.googlesource.com/974644
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545052}
[modify] https://crrev.com/7a8d3b1f804a2aaa1fc57cdb3b74a93a25a6c0a8/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/7a8d3b1f804a2aaa1fc57cdb3b74a93a25a6c0a8/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc

Some context: all three of the tests in question involve tab switching.

The find bar ones are legitimate failures. AFAICT the actual text for these is reported correctly, but the selection ranges are not.

MacViews triage: let's target doing something here (maybe deciding that we don't care about the behavior, maybe fixing it) at M-67.

Closing this now since the FindInPage texts are fixed and the Omnibox is another issue

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0856b0ab431b7eec3a4bf12595549ece43d2f7c6

commit 0856b0ab431b7eec3a4bf12595549ece43d2f7c6
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Mar 30 17:00:11 2018

Polychrome: re-enable disabled FindInPageTest tests

...where by re-enable, I mean note that we intentionally don't support
this behavior on Mac and exit early.

Bug:  823532 
Change-Id: I49f3213fab7f156d6f262c3b448c54e99cf3520d
Reviewed-on: https://chromium-review.googlesource.com/981799
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547190}
[modify] https://crrev.com/0856b0ab431b7eec3a4bf12595549ece43d2f7c6/chrome/browser/ui/views/find_bar_views_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660ca3f59534cde9e55e0e694dae6f028e262277

commit 660ca3f59534cde9e55e0e694dae6f028e262277
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Nov 13 19:56:31 2018

Re-enable disabled tests in chrome/browser/ui/omnibox/.

These passed 50 times in a row on Windows.

This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation
observer in hopes of fixing observed flakiness in EnterToSearch.

Bug:  69433 ,  133341 ,  133344 ,  133347 ,  133355 ,  133360 ,  146953 ,  408634 ,  431575 , 751031,  751543 ,  823532 ,  841195 
Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c
Reviewed-on: https://chromium-review.googlesource.com/c/1332257
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607713}
[modify] https://crrev.com/660ca3f59534cde9e55e0e694dae6f028e262277/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc